public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: bin/, /
Date: Mon,  4 Nov 2024 20:52:41 +0000 (UTC)	[thread overview]
Message-ID: <1730753454.6648a0d37131534767f15542f1d2efc3d7201f55.zmedico@gentoo> (raw)

commit:     6648a0d37131534767f15542f1d2efc3d7201f55
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Mon Nov  4 20:50:54 2024 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Mon Nov  4 20:50:54 2024 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=6648a0d3

install_qa_check: Fix noclean interaction with merge-wait

Fixes: 8ac72ee300c1 ("install_qa_check: prematurely delete WORKDIR if FEATURES=merge-wait")
Bug: https://bugs.gentoo.org/942760
Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>

 NEWS                  | 2 ++
 bin/misc-functions.sh | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 8847f02098..ac0741d953 100644
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,8 @@ Bug fixes:
 
 * gpkg: do not consider symlinks targets for size estimation (bug #942512).
 
+* install_qa_check: Fix noclean interaction with merge-wait (bug #942760).
+
 portage-3.0.66.1 (2024-09-18)
 --------------
 

diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh
index e7ca2a8a92..386e50cc8d 100755
--- a/bin/misc-functions.sh
+++ b/bin/misc-functions.sh
@@ -259,7 +259,9 @@ install_qa_check() {
 	# Prematurely delete WORKDIR in case merge-wait is enabled to
 	# decrease the space used by portage build directories until the
 	# packages are merged and cleaned.
-	if has merge-wait ${FEATURES} && ! has keepwork ${FEATURES}; then
+	if has merge-wait ${FEATURES} &&
+		! has keepwork ${FEATURES} &&
+		! has noclean ${FEATURES} ; then
 		rm -rf "${WORKDIR}"
 	fi
 }


             reply	other threads:[~2024-11-04 20:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 20:52 Zac Medico [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-15 21:49 [gentoo-commits] proj/portage:master commit in: bin/, / Zac Medico
2025-01-09 17:10 James Le Cuirot
2024-12-15  7:58 Ulrich Müller
2024-11-21 12:22 Ulrich Müller
2023-08-02  6:31 Sam James
2023-06-09 13:03 Sam James
2023-05-14  5:04 Ulrich Müller
2023-05-01  7:21 Sam James
2023-04-18 15:22 Ulrich Müller
2023-04-09  6:52 Sam James
2022-11-30 22:29 Sam James
2022-11-30  1:22 Sam James
2022-10-04  0:25 Sam James
2022-09-29 20:45 Sam James
2022-09-29 20:45 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1730753454.6648a0d37131534767f15542f1d2efc3d7201f55.zmedico@gentoo \
    --to=zmedico@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox