public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/roctracer/
Date: Mon,  9 Sep 2024 18:20:40 +0000 (UTC)	[thread overview]
Message-ID: <1725905720.58ee8b5d08feb2cf8e7257f4033a19ba1cd2312e.sam@gentoo> (raw)

commit:     58ee8b5d08feb2cf8e7257f4033a19ba1cd2312e
Author:     Sv. Lockal <lockalsash <AT> gmail <DOT> com>
AuthorDate: Sat Jul 20 17:54:22 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Sep  9 18:15:20 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58ee8b5d

dev-util/roctracer: strip unsupported flags for potentially switched compiler

Also fix libc++ in hipcc (clang-18) has no <experimental/filesystem>.

Also remove unused cmake flag.

Bug: https://bugs.gentoo.org/936099
Closes: https://bugs.gentoo.org/854111
Signed-off-by: Sv. Lockal <lockalsash <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 .../{roctracer-6.1.1.ebuild => roctracer-6.1.1-r1.ebuild} | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/dev-util/roctracer/roctracer-6.1.1.ebuild b/dev-util/roctracer/roctracer-6.1.1-r1.ebuild
similarity index 82%
rename from dev-util/roctracer/roctracer-6.1.1.ebuild
rename to dev-util/roctracer/roctracer-6.1.1-r1.ebuild
index 61a5b02149f2..5ac47938ee4d 100644
--- a/dev-util/roctracer/roctracer-6.1.1.ebuild
+++ b/dev-util/roctracer/roctracer-6.1.1-r1.ebuild
@@ -7,7 +7,7 @@ PYTHON_COMPAT=( python3_{10..13} )
 LLVM_COMPAT=( 18 )
 ROCM_VERSION=${PV}
 
-inherit cmake prefix python-any-r1 rocm llvm-r1
+inherit cmake flag-o-matic llvm-r1 prefix python-any-r1 rocm toolchain-funcs
 
 DESCRIPTION="Callback/Activity Library for Performance tracing AMD GPU's"
 HOMEPAGE="https://github.com/ROCm/roctracer"
@@ -64,9 +64,21 @@ src_prepare() {
 
 	# bug #892732
 	sed -i -e 's/-Werror//' CMakeLists.txt || die
+
+	# libc++ may have no experimental/filesystem
+	sed -e 's|experimental/||' -e 's|experimental::||' \
+		-i plugin/file/file.cpp src/hip_stats/hip_stats.cpp \
+		src/roctracer/loader.h src/tracer_tool/tracer_tool.cpp || die
 }
 
 src_configure() {
+	rocm_use_hipcc
+
+	if [[ $(tc-get-cxx-stdlib) == "libc++" ]] ; then
+		# https://releases.llvm.org/9.0.0/projects/libcxx/docs/UsingLibcxx.html#using-filesystem
+		append-libs "-lc++fs"
+	fi
+
 	local mycmakeargs=(
 		-DCMAKE_MODULE_PATH="${EPREFIX}/usr/$(get_libdir)/cmake/hip"
 		-DFILE_REORG_BACKWARD_COMPATIBILITY=OFF
@@ -75,7 +87,6 @@ src_configure() {
 	)
 	use test && mycmakeargs+=(
 		-DHIP_ROOT_DIR="${EPREFIX}/usr"
-		-DHIP_CLANG_INSTALL_DIR="$(get_llvm_prefix)/bin"
 		-DGPU_TARGETS="$(get_amdgpu_flags)"
 	)
 


             reply	other threads:[~2024-09-09 18:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 18:20 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-03-04 10:55 [gentoo-commits] repo/gentoo:master commit in: dev-util/roctracer/ Patrick Lauer
2025-02-08 10:07 Patrick Lauer
2025-02-08 10:07 Patrick Lauer
2024-06-27  1:25 Sam James
2024-06-27  1:25 Sam James
2023-07-30  4:39 Benda XU
2023-07-29  2:56 Benda XU
2023-07-05 18:15 Craig Andrews
2022-10-08 16:49 Arthur Zamarin
2022-08-06 14:23 Benda XU
2022-06-22 18:35 Andrew Ammerlaan
2022-02-13 21:08 Conrad Kostecki
2022-01-30  8:07 Jason Zaman
2021-08-26 12:39 Benda XU
2021-08-13  8:08 Benda XU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1725905720.58ee8b5d08feb2cf8e7257f4033a19ba1cd2312e.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox