From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9835A1581FB for ; Mon, 26 Aug 2024 13:13:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E4F34E2AC4; Mon, 26 Aug 2024 13:13:29 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CE089E2AC4 for ; Mon, 26 Aug 2024 13:13:29 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1FC12340C3C for ; Mon, 26 Aug 2024 13:13:29 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 354FD1F20 for ; Mon, 26 Aug 2024 13:13:26 +0000 (UTC) From: "Eli Schwartz" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Eli Schwartz" Message-ID: <1724677963.1ca47163c2c7c223d2a120092c2489d007e4eeb7.eschwartz@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-lang/julia/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-lang/julia/julia-1.8.3-r4.ebuild dev-lang/julia/julia-1.8.5-r1.ebuild dev-lang/julia/julia-1.9.0.ebuild dev-lang/julia/julia-1.9.4.ebuild X-VCS-Directories: dev-lang/julia/ X-VCS-Committer: eschwartz X-VCS-Committer-Name: Eli Schwartz X-VCS-Revision: 1ca47163c2c7c223d2a120092c2489d007e4eeb7 X-VCS-Branch: master Date: Mon, 26 Aug 2024 13:13:26 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 8910bef0-8ba7-4de9-83f9-d675e1bdf816 X-Archives-Hash: 584166ddc6d98e4db5ca1fb5c4420a2e commit: 1ca47163c2c7c223d2a120092c2489d007e4eeb7 Author: Eli Schwartz gentoo org> AuthorDate: Mon Aug 26 06:02:46 2024 +0000 Commit: Eli Schwartz gentoo org> CommitDate: Mon Aug 26 13:12:43 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ca47163 dev-lang/julia: mark as LTO-unsafe julia has many problems, at many levels. Among these, it fails to build with LTO due to various errors somewhat more inventive than the norm when it comes to LTO issues. Iteration time on building and testing it is, of course, horrifically bad as it bundles its own private LLVM. I won't even try to run the testsuite. I tried that years ago on Arch. "Flaky" doesn't even begin to describe it -- an actual passing test result sometimes took me 7 builds in a row, and one is never sure why it actually passed for once. "Fortunately", the ebuild restricts tests anyway. Needless to say, who knows if it actually works. It seems to build. Probably. At least better than when -flto is used, so that's a win. On which note, it is worth pointing out: the ebuild *tried* to filter lto, but didn't do so early enough. This change simply lifts the filter early enough that it runs before a sed inserts CFLAGS into a Makefile, so that the filter actually takes effect. Bug NOT reported upstream. Julia is a language of all time, and reporting bugs gets you nowhere except the receiving end of a thorough gaslighting. I do not volunteer for this. The software is most likely broken (LTO warnings don't indicate a flawless codebase) but I simply don't care -- it's not my problem if this programming language is broken, as long as it isn't an obstacle to other, more useful packages, being safe to build by default with LTO enabled in make.conf. Closes: https://bugs.gentoo.org/855602 Signed-off-by: Eli Schwartz gentoo.org> dev-lang/julia/julia-1.8.3-r4.ebuild | 7 ++++--- dev-lang/julia/julia-1.8.5-r1.ebuild | 7 ++++--- dev-lang/julia/julia-1.9.0.ebuild | 7 ++++--- dev-lang/julia/julia-1.9.4.ebuild | 7 ++++--- 4 files changed, 16 insertions(+), 12 deletions(-) diff --git a/dev-lang/julia/julia-1.8.3-r4.ebuild b/dev-lang/julia/julia-1.8.3-r4.ebuild index c21a564cc460..997f4870446f 100644 --- a/dev-lang/julia/julia-1.8.3-r4.ebuild +++ b/dev-lang/julia/julia-1.8.3-r4.ebuild @@ -88,6 +88,10 @@ src_unpack() { src_prepare() { default + # Various LTO issues. + # https://bugs.gentoo.org/855602 + filter-lto + # Sledgehammer: # - prevent fetching of bundled stuff in compile and install phase # - respect CFLAGS @@ -106,9 +110,6 @@ src_prepare() { } src_configure() { - # bug #855602 - filter-lto - # julia does not play well with the system versions of libuv # Fails to compile with libpcre2 on split-usr, bug #893336 # USE_SYSTEM_LIBM=0 implies using external openlibm diff --git a/dev-lang/julia/julia-1.8.5-r1.ebuild b/dev-lang/julia/julia-1.8.5-r1.ebuild index c38278524dae..5c62824bd624 100644 --- a/dev-lang/julia/julia-1.8.5-r1.ebuild +++ b/dev-lang/julia/julia-1.8.5-r1.ebuild @@ -121,6 +121,10 @@ src_unpack() { src_prepare() { default + # Various LTO issues. + # https://bugs.gentoo.org/855602 + filter-lto + # Sledgehammer: # - prevent fetching of bundled stuff in compile and install phase # - respect CFLAGS @@ -146,9 +150,6 @@ src_prepare() { } src_configure() { - # bug #855602 - filter-lto - # julia does not play well with the system versions of libuv # Fails to compile with libpcre2 on split-usr, bug #893336 # USE_SYSTEM_LIBM=0 implies using external openlibm diff --git a/dev-lang/julia/julia-1.9.0.ebuild b/dev-lang/julia/julia-1.9.0.ebuild index 6dfef422bd55..d1c6e722a101 100644 --- a/dev-lang/julia/julia-1.9.0.ebuild +++ b/dev-lang/julia/julia-1.9.0.ebuild @@ -101,6 +101,10 @@ src_unpack() { src_prepare() { default + # Various LTO issues. + # https://bugs.gentoo.org/855602 + filter-lto + # Sledgehammer: # - prevent fetching of bundled stuff in compile and install phase # - respect CFLAGS @@ -126,9 +130,6 @@ src_prepare() { } src_configure() { - # bug #855602 - filter-lto - # julia does not play well with the system versions of libuv # Fails to compile with libpcre2 on split-usr, bug #893336 # USE_SYSTEM_LIBM=0 implies using external openlibm diff --git a/dev-lang/julia/julia-1.9.4.ebuild b/dev-lang/julia/julia-1.9.4.ebuild index 82e0fb7987d9..9a747305e8d0 100644 --- a/dev-lang/julia/julia-1.9.4.ebuild +++ b/dev-lang/julia/julia-1.9.4.ebuild @@ -91,6 +91,10 @@ src_unpack() { src_prepare() { default + # Various LTO issues. + # https://bugs.gentoo.org/855602 + filter-lto + # Sledgehammer: # - prevent fetching of bundled stuff in compile and install phase # - respect CFLAGS @@ -109,9 +113,6 @@ src_prepare() { } src_configure() { - # bug #855602 - filter-lto - # julia does not play well with the system versions of libuv # Fails to compile with libpcre2 on split-usr, bug #893336 # USE_SYSTEM_LIBM=0 implies using external openlibm