* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-18 21:36 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-18 21:36 UTC (permalink / raw
To: gentoo-commits
commit: 692bd572180be2bc47e6220d535416f699a65ea1
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Aug 18 21:36:01 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Aug 18 21:36:01 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=692bd572
dev-debug/dtrace: update HOMEPAGE, link to wiki page in pkg_postinst
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1.ebuild | 5 +++--
dev-debug/dtrace/dtrace-9999.ebuild | 4 +++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
index 7c697bf009cf..8d1b0b1a3b94 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
@@ -6,7 +6,7 @@ EAPI=8
inherit edo flag-o-matic linux-info systemd toolchain-funcs udev
DESCRIPTION="Dynamic systemwide tracing tool"
-HOMEPAGE="https://github.com/oracle/dtrace-utils"
+HOMEPAGE="https://github.com/oracle/dtrace-utils https://wiki.gentoo.org/wiki/DTrace"
if [[ ${PV} == 9999 ]]; then
EGIT_BRANCH="devel"
@@ -95,7 +95,6 @@ src_configure() {
tc-export CC
# TODO: Can drop once https://lore.kernel.org/dtrace/20240425164057.420580-1-nick.alcock@oracle.com/ is in
- # XXX: That wasn't enough, need to report upstream the other issues during build
tc-enables-fortify-source && append-cppflags -U_FORTIFY_SOURCE
# lld does this by default, so fix that, although lld fails anyway...
@@ -151,6 +150,8 @@ pkg_postinst() {
# TODO: Restart it on upgrade? (it will carry across its own persistent state)
if [[ -n ${REPLACING_VERSIONS} ]]; then
+ einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
+
# TODO: Make this more intelligent wrt comparison
if systemd_is_booted ; then
einfo "Restart the DTrace 'dtprobed' service after upgrades:"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 7c697bf009cf..c536eb50ce91 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -6,7 +6,7 @@ EAPI=8
inherit edo flag-o-matic linux-info systemd toolchain-funcs udev
DESCRIPTION="Dynamic systemwide tracing tool"
-HOMEPAGE="https://github.com/oracle/dtrace-utils"
+HOMEPAGE="https://github.com/oracle/dtrace-utils https://wiki.gentoo.org/wiki/DTrace"
if [[ ${PV} == 9999 ]]; then
EGIT_BRANCH="devel"
@@ -151,6 +151,8 @@ pkg_postinst() {
# TODO: Restart it on upgrade? (it will carry across its own persistent state)
if [[ -n ${REPLACING_VERSIONS} ]]; then
+ einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
+
# TODO: Make this more intelligent wrt comparison
if systemd_is_booted ; then
einfo "Restart the DTrace 'dtprobed' service after upgrades:"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-18 21:42 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-18 21:42 UTC (permalink / raw
To: gentoo-commits
commit: cd20b4254982e8a3b2107271d8c5f8765f429937
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Aug 18 21:42:18 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Aug 18 21:42:18 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd20b425
dev-debug/dtrace: cleanup kernel config checks
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1.ebuild | 6 +++---
dev-debug/dtrace/dtrace-9999.ebuild | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
index 8d1b0b1a3b94..88e94aeab587 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
@@ -70,11 +70,11 @@ pkg_pretend() {
# TODO: optional kernel patches
# Basics for debugging information, BPF
- local CONFIG_CHECK="~BPF ~DEBUG_INFO_BTF ~KALLSYMS_ALL ~CUSE"
+ local CONFIG_CHECK="~BPF ~DEBUG_INFO_BTF ~KALLSYMS_ALL"
+
+ CONFIG_CHECK+=" ~CUSE"
# Tracing
- # TODO: CONFIG_HAVE_SYSCALL_TRACEPOINTS - is it auto?
- # TODO: CONFIG_UPROBE_EVENTS maybe?
CONFIG_CHECK+=" ~FTRACE_SYSCALLS ~UPROBE_EVENTS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
# https://gcc.gnu.org/PR84052
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index c536eb50ce91..a4a42f455239 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -70,11 +70,11 @@ pkg_pretend() {
# TODO: optional kernel patches
# Basics for debugging information, BPF
- local CONFIG_CHECK="~BPF ~DEBUG_INFO_BTF ~KALLSYMS_ALL ~CUSE"
+ local CONFIG_CHECK="~BPF ~DEBUG_INFO_BTF ~KALLSYMS_ALL"
+
+ CONFIG_CHECK+=" ~CUSE"
# Tracing
- # TODO: CONFIG_HAVE_SYSCALL_TRACEPOINTS - is it auto?
- # TODO: CONFIG_UPROBE_EVENTS maybe?
CONFIG_CHECK+=" ~FTRACE_SYSCALLS ~UPROBE_EVENTS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
# https://gcc.gnu.org/PR84052
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-18 21:47 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-18 21:47 UTC (permalink / raw
To: gentoo-commits
commit: 9ca5f3ec5b020f13aaa9d1221bce9ae41ee34aaf
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Aug 18 21:47:04 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Aug 18 21:47:08 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ca5f3ec
dev-debug/dtrace: tweak DESCRIPTION, sort BDEPEND
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1.ebuild | 4 ++--
dev-debug/dtrace/dtrace-9999.ebuild | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
index 88e94aeab587..5baf5c47c35c 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
@@ -5,7 +5,7 @@ EAPI=8
inherit edo flag-o-matic linux-info systemd toolchain-funcs udev
-DESCRIPTION="Dynamic systemwide tracing tool"
+DESCRIPTION="Dynamic BPF-based system-wide tracing tool"
HOMEPAGE="https://github.com/oracle/dtrace-utils https://wiki.gentoo.org/wiki/DTrace"
if [[ ${PV} == 9999 ]]; then
@@ -60,9 +60,9 @@ RDEPEND="
"
BDEPEND="
dev-build/make
- >=sys-devel/bpf-toolchain-14.1.0
sys-apps/gawk
sys-devel/bison
+ >=sys-devel/bpf-toolchain-14.1.0
sys-devel/flex
"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index a4a42f455239..15e7ca0357a0 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -5,7 +5,7 @@ EAPI=8
inherit edo flag-o-matic linux-info systemd toolchain-funcs udev
-DESCRIPTION="Dynamic systemwide tracing tool"
+DESCRIPTION="Dynamic BPF-based system-wide tracing tool"
HOMEPAGE="https://github.com/oracle/dtrace-utils https://wiki.gentoo.org/wiki/DTrace"
if [[ ${PV} == 9999 ]]; then
@@ -60,9 +60,9 @@ RDEPEND="
"
BDEPEND="
dev-build/make
- >=sys-devel/bpf-toolchain-14.1.0
sys-apps/gawk
sys-devel/bison
+ >=sys-devel/bpf-toolchain-14.1.0
sys-devel/flex
"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-18 22:59 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-18 22:59 UTC (permalink / raw
To: gentoo-commits
commit: 3531903948fb3c0cba9448d23151900991674f0c
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Aug 18 22:58:35 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Aug 18 22:58:35 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=35319039
dev-debug/dtrace: add link to upstream bug re _F_S
Bug: https://github.com/oracle/dtrace-utils/issues/78
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-9999.ebuild | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 15e7ca0357a0..73afc981b1fd 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -94,8 +94,7 @@ src_configure() {
tc-export CC
- # TODO: Can drop once https://lore.kernel.org/dtrace/20240425164057.420580-1-nick.alcock@oracle.com/ is in
- # XXX: That wasn't enough, need to report upstream the other issues during build
+ # https://github.com/oracle/dtrace-utils/issues/78
tc-enables-fortify-source && append-cppflags -U_FORTIFY_SOURCE
# lld does this by default, so fix that, although lld fails anyway...
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-19 20:16 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-19 20:16 UTC (permalink / raw
To: gentoo-commits
commit: b2b727d8c6a6c01eac48781e78540a22b9960992
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Aug 19 20:14:59 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Aug 19 20:14:59 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2b727d8
dev-debug/dtrace: DEPEND on dev-debug/valgrind again for now, for valgrind.h
It's unconditionally included and I wrongly removed it because I grepped
badly. This will be fixed later but let's get the dep right for now.
Closes: https://bugs.gentoo.org/938190
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1.ebuild | 3 +++
dev-debug/dtrace/dtrace-9999.ebuild | 3 +++
2 files changed, 6 insertions(+)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
index 5baf5c47c35c..8f1cbd7f3011 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
@@ -65,6 +65,9 @@ BDEPEND="
>=sys-devel/bpf-toolchain-14.1.0
sys-devel/flex
"
+# TODO: Make this optional, valgrind.h is included unconditionally
+# https://github.com/oracle/dtrace-utils/issues/80
+DEPEND+=" dev-debug/valgrind"
pkg_pretend() {
# TODO: optional kernel patches
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 73afc981b1fd..8fb8a63fc9a2 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -65,6 +65,9 @@ BDEPEND="
>=sys-devel/bpf-toolchain-14.1.0
sys-devel/flex
"
+# TODO: Make this optional, valgrind.h is included unconditionally
+# https://github.com/oracle/dtrace-utils/issues/80
+DEPEND+=" dev-debug/valgrind"
pkg_pretend() {
# TODO: optional kernel patches
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-19 23:27 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-19 23:27 UTC (permalink / raw
To: gentoo-commits
commit: 850a084b7f9ba426afb1febec97c613c90498484
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Aug 19 23:26:26 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Aug 19 23:26:51 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=850a084b
dev-debug/dtrace: fix man page location
Bug: https://bugs.gentoo.org/938209
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/{dtrace-2.0.1.1.ebuild => dtrace-2.0.1.1-r1.ebuild} | 2 +-
dev-debug/dtrace/dtrace-9999.ebuild | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
similarity index 99%
rename from dev-debug/dtrace/dtrace-2.0.1.1.ebuild
rename to dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index 8f1cbd7f3011..4a48a07e8545 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -116,7 +116,7 @@ src_configure() {
local confargs=(
# TODO: Maybe we should set the UNPRIV_UID to something? -3 is a bit... kludgy
--prefix="${EPREFIX}"/usr
- --mandir="${EPREFIX}"/usr/share/man
+ --mandir="${EPREFIX}"/usr/share/man/man8
--docdir="${EPREFIX}"/usr/share/doc/${PF}
HAVE_LIBCTF=yes
HAVE_LIBSYSTEMD=$(usex systemd)
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 8fb8a63fc9a2..40c98e7440cd 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -116,7 +116,7 @@ src_configure() {
local confargs=(
# TODO: Maybe we should set the UNPRIV_UID to something? -3 is a bit... kludgy
--prefix="${EPREFIX}"/usr
- --mandir="${EPREFIX}"/usr/share/man
+ --mandir="${EPREFIX}"/usr/share/man/man8
--docdir="${EPREFIX}"/usr/share/doc/${PF}
HAVE_LIBCTF=yes
HAVE_LIBSYSTEMD=$(usex systemd)
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-20 1:49 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-20 1:49 UTC (permalink / raw
To: gentoo-commits
commit: 98aee34a2292d56d2132eb87542157537cb72a0a
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Aug 20 01:46:17 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Aug 20 01:48:16 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=98aee34a
dev-debug/dtrace: suppress binary warnings for USE=install-tests
We can't impose our requirements on parts of the testsuite.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 7 +++++++
dev-debug/dtrace/dtrace-9999.ebuild | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index 4a48a07e8545..be756c64a0bf 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -69,6 +69,13 @@ BDEPEND="
# https://github.com/oracle/dtrace-utils/issues/80
DEPEND+=" dev-debug/valgrind"
+QA_PRESTRIPPED="
+ usr/.*/dtrace/testsuite/test/triggers/.*
+"
+QA_FLAGS_IGNORED="
+ usr/.*/dtrace/testsuite/test/triggers/.*
+"
+
pkg_pretend() {
# TODO: optional kernel patches
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 40c98e7440cd..b43c5d9e4a8c 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -69,6 +69,13 @@ BDEPEND="
# https://github.com/oracle/dtrace-utils/issues/80
DEPEND+=" dev-debug/valgrind"
+QA_PRESTRIPPED="
+ usr/.*/dtrace/testsuite/test/triggers/.*
+"
+QA_FLAGS_IGNORED="
+ usr/.*/dtrace/testsuite/test/triggers/.*
+"
+
pkg_pretend() {
# TODO: optional kernel patches
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-20 1:49 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-20 1:49 UTC (permalink / raw
To: gentoo-commits
commit: 0cb548055bceec50d138901f610234b782e9da9e
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Aug 20 01:47:55 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Aug 20 01:48:18 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0cb54805
dev-debug/dtrace: update F_S comment in non-live
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index 146682a2fa83..f084535e5911 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -105,7 +105,7 @@ src_configure() {
tc-export CC
- # TODO: Can drop once https://lore.kernel.org/dtrace/20240425164057.420580-1-nick.alcock@oracle.com/ is in
+ # https://github.com/oracle/dtrace-utils/issues/78
tc-enables-fortify-source && append-cppflags -U_FORTIFY_SOURCE
# lld does this by default, so fix that, although lld fails anyway...
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-20 1:49 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-20 1:49 UTC (permalink / raw
To: gentoo-commits
commit: ba6a8a8586235fe618dbdf1d295f22237e857f56
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Aug 20 01:47:10 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Aug 20 01:48:17 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba6a8a85
dev-debug/dtrace: check for CONFIG_FPROBE
fbt can use the fprobe machinery.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 1 +
dev-debug/dtrace/dtrace-9999.ebuild | 1 +
2 files changed, 2 insertions(+)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index be756c64a0bf..146682a2fa83 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -86,6 +86,7 @@ pkg_pretend() {
# Tracing
CONFIG_CHECK+=" ~FTRACE_SYSCALLS ~UPROBE_EVENTS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
+ CONFIG_CHECK+=" ~FPROBE"
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index b43c5d9e4a8c..f084535e5911 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -86,6 +86,7 @@ pkg_pretend() {
# Tracing
CONFIG_CHECK+=" ~FTRACE_SYSCALLS ~UPROBE_EVENTS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
+ CONFIG_CHECK+=" ~FPROBE"
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-22 12:22 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-22 12:22 UTC (permalink / raw
To: gentoo-commits
commit: b2f1216adb56a434ab8e590cb530ce79c2e4da1a
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Aug 22 12:20:46 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Aug 22 12:21:41 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2f1216a
dev-debug/dtrace: improve config checks further (mostly pedantry, also for tests)
This adds some technically-required-but-already-covered-by-dependencies
CONFIG_* requirements in general, and then some real config requirements
we were missing for the testsuite.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 12 +++++++++++-
dev-debug/dtrace/dtrace-9999.ebuild | 12 +++++++++++-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index f084535e5911..04646e70ea08 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -85,12 +85,22 @@ pkg_pretend() {
CONFIG_CHECK+=" ~CUSE"
# Tracing
- CONFIG_CHECK+=" ~FTRACE_SYSCALLS ~UPROBE_EVENTS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
+ CONFIG_CHECK+=" ~TRACING"
+ CONFIG_CHECK+=" ~UPROBES ~UPROBE_EVENTS"
+ CONFIG_CHECK+=" ~FTRACE ~FTRACE_SYSCALLS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
CONFIG_CHECK+=" ~FPROBE"
+ # DTrace can fallback to kprobes for fbt but people often want them off
+ # for security and newer kernels work fine with BPF for that, so
+ # let's omit it.
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
+ if use install-tests ; then
+ # See test/modules
+ CONFIG_CHECK+=" ~EXT4_FS ~ISO9660_FS ~NFS_FS ~RDS ~TUN"
+ fi
+
check_extra_config
}
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index f084535e5911..04646e70ea08 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -85,12 +85,22 @@ pkg_pretend() {
CONFIG_CHECK+=" ~CUSE"
# Tracing
- CONFIG_CHECK+=" ~FTRACE_SYSCALLS ~UPROBE_EVENTS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
+ CONFIG_CHECK+=" ~TRACING"
+ CONFIG_CHECK+=" ~UPROBES ~UPROBE_EVENTS"
+ CONFIG_CHECK+=" ~FTRACE ~FTRACE_SYSCALLS ~DYNAMIC_FTRACE ~FUNCTION_TRACER"
CONFIG_CHECK+=" ~FPROBE"
+ # DTrace can fallback to kprobes for fbt but people often want them off
+ # for security and newer kernels work fine with BPF for that, so
+ # let's omit it.
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
+ if use install-tests ; then
+ # See test/modules
+ CONFIG_CHECK+=" ~EXT4_FS ~ISO9660_FS ~NFS_FS ~RDS ~TUN"
+ fi
+
check_extra_config
}
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-22 12:36 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-22 12:36 UTC (permalink / raw
To: gentoo-commits
commit: ccab49968707c2d257a8c1c779d31e467b3a166b
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Aug 22 12:34:33 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Aug 22 12:36:04 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ccab4996
dev-debug/dtrace: sort IUSE
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 2 +-
dev-debug/dtrace/dtrace-9999.ebuild | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index 04646e70ea08..d7e856a9d1c0 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -21,7 +21,7 @@ fi
LICENSE="UPL-1.0"
SLOT="0"
-IUSE="install-tests systemd"
+IUSE="systemd install-tests"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 04646e70ea08..d7e856a9d1c0 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -21,7 +21,7 @@ fi
LICENSE="UPL-1.0"
SLOT="0"
-IUSE="install-tests systemd"
+IUSE="systemd install-tests"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-22 12:36 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-22 12:36 UTC (permalink / raw
To: gentoo-commits
commit: 043b69dd2c5d70baf94cc934c7c3aa2b19e8f632
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Aug 22 12:35:35 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Aug 22 12:36:05 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=043b69dd
dev-debug/dtrace: fix branch for 'getting started' link
Show it on new installs, not upgrades.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 4 ++--
dev-debug/dtrace/dtrace-9999.ebuild | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index d7e856a9d1c0..adfca6d38fe1 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -171,8 +171,6 @@ pkg_postinst() {
# TODO: Restart it on upgrade? (it will carry across its own persistent state)
if [[ -n ${REPLACING_VERSIONS} ]]; then
- einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
-
# TODO: Make this more intelligent wrt comparison
if systemd_is_booted ; then
einfo "Restart the DTrace 'dtprobed' service after upgrades:"
@@ -182,6 +180,8 @@ pkg_postinst() {
einfo " /etc/init.d/dtprobed restart"
fi
else
+ einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
+
if systemd_is_booted ; then
einfo "Enable and start the DTrace 'dtprobed' service with:"
einfo " systemctl enable --now dtprobed"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index d7e856a9d1c0..adfca6d38fe1 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -171,8 +171,6 @@ pkg_postinst() {
# TODO: Restart it on upgrade? (it will carry across its own persistent state)
if [[ -n ${REPLACING_VERSIONS} ]]; then
- einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
-
# TODO: Make this more intelligent wrt comparison
if systemd_is_booted ; then
einfo "Restart the DTrace 'dtprobed' service after upgrades:"
@@ -182,6 +180,8 @@ pkg_postinst() {
einfo " /etc/init.d/dtprobed restart"
fi
else
+ einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
+
if systemd_is_booted ; then
einfo "Enable and start the DTrace 'dtprobed' service with:"
einfo " systemctl enable --now dtprobed"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-22 12:54 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-22 12:54 UTC (permalink / raw
To: gentoo-commits
commit: b04b4884fb067d279a308f149aee2b9dc11d09ca
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Aug 22 12:43:45 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Aug 22 12:43:45 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b04b4884
dev-debug/dtrace: elaborate on kprobes being bad
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 2 +-
dev-debug/dtrace/dtrace-9999.ebuild | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index adfca6d38fe1..250c9ddd9755 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -91,7 +91,7 @@ pkg_pretend() {
CONFIG_CHECK+=" ~FPROBE"
# DTrace can fallback to kprobes for fbt but people often want them off
# for security and newer kernels work fine with BPF for that, so
- # let's omit it.
+ # let's omit it. kprobes are slower and scale poorly.
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index adfca6d38fe1..250c9ddd9755 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -91,7 +91,7 @@ pkg_pretend() {
CONFIG_CHECK+=" ~FPROBE"
# DTrace can fallback to kprobes for fbt but people often want them off
# for security and newer kernels work fine with BPF for that, so
- # let's omit it.
+ # let's omit it. kprobes are slower and scale poorly.
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-25 18:49 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-25 18:49 UTC (permalink / raw
To: gentoo-commits
commit: 662dc63bd2323f7d62e8c16cf44e3e871051dd8a
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Aug 25 18:48:31 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Aug 25 18:48:55 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=662dc63b
dev-debug/dtrace: add upstream bug link for LTO
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild | 1 +
dev-debug/dtrace/dtrace-9999.ebuild | 1 +
2 files changed, 2 insertions(+)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
index 250c9ddd9755..1129df6ebaf6 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
@@ -129,6 +129,7 @@ src_configure() {
# that can't actually obtain results from probes, even trivial examples
# just hang.
filter-flags -fno-semantic-interposition
+ # https://github.com/oracle/dtrace-utils/issues/86
filter-lto
local confargs=(
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 250c9ddd9755..1129df6ebaf6 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -129,6 +129,7 @@ src_configure() {
# that can't actually obtain results from probes, even trivial examples
# just hang.
filter-flags -fno-semantic-interposition
+ # https://github.com/oracle/dtrace-utils/issues/86
filter-lto
local confargs=(
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-08-30 18:13 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-08-30 18:13 UTC (permalink / raw
To: gentoo-commits
commit: 585dabcee6b0dde736b9ea3f4d02948ec7af12b2
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Aug 30 18:10:57 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Aug 30 18:11:49 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=585dabce
dev-debug/dtrace: update dev-debug/systemtap blocker
We can now be coinstalled with dev-debug/systemtap if it has USE=-dtrace-symlink.
Bug: https://bugs.gentoo.org/938302
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/{dtrace-2.0.1.1-r1.ebuild => dtrace-2.0.1.1-r2.ebuild} | 2 +-
dev-debug/dtrace/dtrace-9999.ebuild | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
similarity index 99%
rename from dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
rename to dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 1129df6ebaf6..e160180fea3a 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r1.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -42,7 +42,7 @@ DEPEND="
"
RDEPEND="
${DEPEND}
- !dev-debug/systemtap
+ !dev-debug/systemtap[dtrace-symlink(+)]
net-analyzer/wireshark
install-tests? (
app-alternatives/bc
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 1129df6ebaf6..e160180fea3a 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -42,7 +42,7 @@ DEPEND="
"
RDEPEND="
${DEPEND}
- !dev-debug/systemtap
+ !dev-debug/systemtap[dtrace-symlink(+)]
net-analyzer/wireshark
install-tests? (
app-alternatives/bc
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-10 13:58 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-10 13:58 UTC (permalink / raw
To: gentoo-commits
commit: 0df5961ae367847be44f1f1f71fdd1b796c3e1d0
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Sep 10 13:57:28 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Sep 10 13:57:58 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0df5961a
dev-debug/dtrace: build with -j1 for now
Bug: https://github.com/oracle/dtrace-utils/issues/82
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 5 +++--
dev-debug/dtrace/dtrace-9999.ebuild | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index e160180fea3a..69752d8625d4 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -146,7 +146,8 @@ src_configure() {
}
src_compile() {
- emake verbose=1 $(usev !install-tests TRIGGERS='')
+ # -j1: https://github.com/oracle/dtrace-utils/issues/82
+ emake verbose=1 -j1 $(usev !install-tests TRIGGERS='')
}
src_test() {
@@ -155,7 +156,7 @@ src_test() {
}
src_install() {
- emake DESTDIR="${D}" install $(usev install-tests install-test)
+ emake DESTDIR="${D}" -j1 install $(usev install-tests install-test)
# Stripping the BPF libs breaks them
dostrip -x "/usr/$(get_libdir)"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index e160180fea3a..69752d8625d4 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -146,7 +146,8 @@ src_configure() {
}
src_compile() {
- emake verbose=1 $(usev !install-tests TRIGGERS='')
+ # -j1: https://github.com/oracle/dtrace-utils/issues/82
+ emake verbose=1 -j1 $(usev !install-tests TRIGGERS='')
}
src_test() {
@@ -155,7 +156,7 @@ src_test() {
}
src_install() {
- emake DESTDIR="${D}" install $(usev install-tests install-test)
+ emake DESTDIR="${D}" -j1 install $(usev install-tests install-test)
# Stripping the BPF libs breaks them
dostrip -x "/usr/$(get_libdir)"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-11 3:35 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-11 3:35 UTC (permalink / raw
To: gentoo-commits
commit: 6934a79ec72f4b72bb82b91618307d49d5230709
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Sep 11 03:35:10 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Sep 11 03:35:10 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6934a79e
dev-debug/dtrace: Stabilize 2.0.1.1-r2 amd64, #939447
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 69752d8625d4..0cc975299382 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -16,7 +16,7 @@ else
SRC_URI="https://github.com/oracle/dtrace-utils/archive/refs/tags/${PV}.tar.gz -> ${P}.tar.gz"
S="${WORKDIR}"/dtrace-utils-${PV}
- KEYWORDS="-* ~amd64"
+ KEYWORDS="-* amd64"
fi
LICENSE="UPL-1.0"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-11 23:59 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-11 23:59 UTC (permalink / raw
To: gentoo-commits
commit: 063c07a77f3d3b04649bf1e00bc90b1fcd316d1a
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Sep 11 23:56:28 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Sep 11 23:58:31 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=063c07a7
dev-debug/dtrace: rename USE=install-tests -> USE=test-install
Following discussion with mgorny and us agreeing to use test-install
for Python.
Bug: https://bugs.gentoo.org/531648
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 10 +++++-----
dev-debug/dtrace/dtrace-9999.ebuild | 10 +++++-----
dev-debug/dtrace/metadata.xml | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 0cc975299382..413cba677aed 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -21,7 +21,7 @@ fi
LICENSE="UPL-1.0"
SLOT="0"
-IUSE="systemd install-tests"
+IUSE="systemd test-install"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
@@ -44,7 +44,7 @@ RDEPEND="
${DEPEND}
!dev-debug/systemtap[dtrace-symlink(+)]
net-analyzer/wireshark
- install-tests? (
+ test-install? (
app-alternatives/bc
app-editors/vim-core
dev-build/make
@@ -96,7 +96,7 @@ pkg_pretend() {
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
- if use install-tests ; then
+ if use test-install ; then
# See test/modules
CONFIG_CHECK+=" ~EXT4_FS ~ISO9660_FS ~NFS_FS ~RDS ~TUN"
fi
@@ -147,7 +147,7 @@ src_configure() {
src_compile() {
# -j1: https://github.com/oracle/dtrace-utils/issues/82
- emake verbose=1 -j1 $(usev !install-tests TRIGGERS='')
+ emake verbose=1 -j1 $(usev !test-install TRIGGERS='')
}
src_test() {
@@ -156,7 +156,7 @@ src_test() {
}
src_install() {
- emake DESTDIR="${D}" -j1 install $(usev install-tests install-test)
+ emake DESTDIR="${D}" -j1 install $(usev test-install install-test)
# Stripping the BPF libs breaks them
dostrip -x "/usr/$(get_libdir)"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 69752d8625d4..1b544c426da4 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -21,7 +21,7 @@ fi
LICENSE="UPL-1.0"
SLOT="0"
-IUSE="systemd install-tests"
+IUSE="systemd test-install"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
@@ -44,7 +44,7 @@ RDEPEND="
${DEPEND}
!dev-debug/systemtap[dtrace-symlink(+)]
net-analyzer/wireshark
- install-tests? (
+ test-install? (
app-alternatives/bc
app-editors/vim-core
dev-build/make
@@ -96,7 +96,7 @@ pkg_pretend() {
# https://gcc.gnu.org/PR84052
CONFIG_CHECK+=" !GCC_PLUGIN_RANDSTRUCT"
- if use install-tests ; then
+ if use test-install ; then
# See test/modules
CONFIG_CHECK+=" ~EXT4_FS ~ISO9660_FS ~NFS_FS ~RDS ~TUN"
fi
@@ -147,7 +147,7 @@ src_configure() {
src_compile() {
# -j1: https://github.com/oracle/dtrace-utils/issues/82
- emake verbose=1 -j1 $(usev !install-tests TRIGGERS='')
+ emake verbose=1 -j1 $(usev !test-install TRIGGERS='')
}
src_test() {
@@ -156,7 +156,7 @@ src_test() {
}
src_install() {
- emake DESTDIR="${D}" -j1 install $(usev install-tests install-test)
+ emake DESTDIR="${D}" -j1 install $(usev test-install install-test)
# Stripping the BPF libs breaks them
dostrip -x "/usr/$(get_libdir)"
diff --git a/dev-debug/dtrace/metadata.xml b/dev-debug/dtrace/metadata.xml
index 00989594025b..815fdabd199d 100644
--- a/dev-debug/dtrace/metadata.xml
+++ b/dev-debug/dtrace/metadata.xml
@@ -10,7 +10,7 @@
<description>Arsen Arsenović</description>
</maintainer>
<use>
- <flag name="install-tests">
+ <flag name="test-install">
Install the testsuite for manual use. It is not suitable
for automatic execution within the ebuild because it
requires root privlieges.
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 0:10 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 0:10 UTC (permalink / raw
To: gentoo-commits
commit: 0b93226603134a169a41d1ae2213688167bd2b2c
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 00:06:23 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 00:06:31 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b932266
dev-debug/dtrace: rework pkg_postinst
For first installs, we enable the service and start it.
This is unusual, but the behaviour without dtprobed running is
untested/unsupported. It's not a network service, it has no configuration,
reads a single device node, and does all parsing within a seccomp jail. It
also leads to hard-to-diagnose issues because USDT probes won't be registered
and an application might have already started up which needs to be traced.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 42 +++++++++++++++++++++++++------
dev-debug/dtrace/dtrace-9999.ebuild | 42 +++++++++++++++++++++++++------
2 files changed, 70 insertions(+), 14 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 413cba677aed..3032bf884998 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -171,26 +171,54 @@ pkg_postinst() {
# We need a udev reload to pick up the CUSE device node rules.
udev_reload
- # TODO: Restart it on upgrade? (it will carry across its own persistent state)
+ # TODO: One option for this is to detect when it's needed (DOF stash layout changes)
+ # and then e.g. sleep and restart for the user.
if [[ -n ${REPLACING_VERSIONS} ]]; then
# TODO: Make this more intelligent wrt comparison
if systemd_is_booted ; then
- einfo "Restart the DTrace 'dtprobed' service after upgrades:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades"
+ einfo "once all dtraces are stopped with:"
einfo " systemctl try-restart dtprobed"
else
- einfo "Restart the DTrace 'dtprobed' service with:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades"
+ einfo "once all dtraces are stopped with:"
einfo " /etc/init.d/dtprobed restart"
fi
else
einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
- if systemd_is_booted ; then
- einfo "Enable and start the DTrace 'dtprobed' service with:"
+ # We can't do magic for people with ROOT=.
+ if [[ -n ${ROOT} ]] ; then
+ einfo "Enable and start the DTrace 'dtprobed' service for systemd with:"
einfo " systemctl enable --now dtprobed"
- else
- einfo "Enable and start the DTrace 'dtprobed' service with:"
+ einfo
+ einfo "Enable and start the DTrace 'dtprobed' service for OpenRC with:"
einfo " rc-update add dtprobed"
einfo " /etc/init.d/dtprobed start"
+ return
+ fi
+
+ # For first installs, we enable the service and start it.
+ #
+ # This is unusual, but the behaviour without dtprobed running
+ # is untested/unsupported. It's not a network service, it
+ # has no configuration, reads a single device node, and
+ # does all parsing within a seccomp jail. It also leads
+ # to hard-to-diagnose issues because USDT probes won't
+ # be registered and an application might have already
+ # started up which needs to be traced.
+ if systemd_is_booted ; then
+ ebegin "Enabling & starting DTrace 'dtprobed' service"
+ systemctl enable --now dtprobed
+ eend $?
+ else
+ ebegin "Enabling DTrace 'dtprobed' service"
+ rc-update add dtprobed
+ eend $?
+
+ ebegin "Starting DTrace 'dtprobed' service"
+ rc-service start dtprobed
+ eend $?
fi
fi
}
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 1b544c426da4..9eb7d366c037 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -171,26 +171,54 @@ pkg_postinst() {
# We need a udev reload to pick up the CUSE device node rules.
udev_reload
- # TODO: Restart it on upgrade? (it will carry across its own persistent state)
+ # TODO: One option for this is to detect when it's needed (DOF stash layout changes)
+ # and then e.g. sleep and restart for the user.
if [[ -n ${REPLACING_VERSIONS} ]]; then
# TODO: Make this more intelligent wrt comparison
if systemd_is_booted ; then
- einfo "Restart the DTrace 'dtprobed' service after upgrades:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades"
+ einfo "once all dtraces are stopped with:"
einfo " systemctl try-restart dtprobed"
else
- einfo "Restart the DTrace 'dtprobed' service with:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades"
+ einfo "once all dtraces are stopped with:"
einfo " /etc/init.d/dtprobed restart"
fi
else
einfo "See https://wiki.gentoo.org/wiki/DTrace for getting started."
- if systemd_is_booted ; then
- einfo "Enable and start the DTrace 'dtprobed' service with:"
+ # We can't do magic for people with ROOT=.
+ if [[ -n ${ROOT} ]] ; then
+ einfo "Enable and start the DTrace 'dtprobed' service for systemd with:"
einfo " systemctl enable --now dtprobed"
- else
- einfo "Enable and start the DTrace 'dtprobed' service with:"
+ einfo
+ einfo "Enable and start the DTrace 'dtprobed' service for OpenRC with:"
einfo " rc-update add dtprobed"
einfo " /etc/init.d/dtprobed start"
+ return
+ fi
+
+ # For first installs, we enable the service and start it.
+ #
+ # This is unusual, but the behaviour without dtprobed running
+ # is untested/unsupported. It's not a network service, it
+ # has no configuration, reads a single device node, and
+ # does all parsing within a seccomp jail. It also leads
+ # to hard-to-diagnose issues because USDT probes won't
+ # be registered and an application might have already
+ # started up which needs to be traced.
+ if systemd_is_booted ; then
+ ebegin "Enabling & starting DTrace 'dtprobed' service"
+ systemctl enable --now dtprobed
+ eend $?
+ else
+ ebegin "Enabling DTrace 'dtprobed' service"
+ rc-update add dtprobed
+ eend $?
+
+ ebegin "Starting DTrace 'dtprobed' service"
+ rc-service start dtprobed
+ eend $?
fi
fi
}
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 0:30 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 0:30 UTC (permalink / raw
To: gentoo-commits
commit: 5c77941f4535cf5bfc76f84c6d48bafb4465a6b9
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 00:28:00 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 00:28:07 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c77941f
dev-debug/dtrace: suppress harmless execstack warning for BPF object
Bug: https://bugs.gentoo.org/938221
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 6 ++++++
dev-debug/dtrace/dtrace-9999.ebuild | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 3032bf884998..cac701e8eb10 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -76,6 +76,12 @@ QA_FLAGS_IGNORED="
usr/.*/dtrace/testsuite/test/triggers/.*
"
+# TODO: report upstream (bug #938221) although it seems like it's
+# not relevant given it's a BPF object.
+QA_EXECSTACK="
+ usr/*/dtrace/bpf_dlib.*
+"
+
pkg_pretend() {
# TODO: optional kernel patches
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 9eb7d366c037..643f3f5873f4 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -76,6 +76,12 @@ QA_FLAGS_IGNORED="
usr/.*/dtrace/testsuite/test/triggers/.*
"
+# TODO: report upstream (bug #938221) although it seems like it's
+# not relevant given it's a BPF object.
+QA_EXECSTACK="
+ usr/*/dtrace/bpf_dlib.*
+"
+
pkg_pretend() {
# TODO: optional kernel patches
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 0:38 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 0:38 UTC (permalink / raw
To: gentoo-commits
commit: 350c1d4e4771b3a72fc6b1f7378efb4a18538400
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 00:36:18 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 00:36:20 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=350c1d4e
dev-debug/dtrace: add upstream bug link re mandir
Bug: https://github.com/oracle/dtrace-utils/issues/106
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 1 +
dev-debug/dtrace/dtrace-9999.ebuild | 1 +
2 files changed, 2 insertions(+)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index cac701e8eb10..2fb1849deaed 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -141,6 +141,7 @@ src_configure() {
local confargs=(
# TODO: Maybe we should set the UNPRIV_UID to something? -3 is a bit... kludgy
--prefix="${EPREFIX}"/usr
+ # See https://github.com/oracle/dtrace-utils/issues/106 for man8 suffix
--mandir="${EPREFIX}"/usr/share/man/man8
--docdir="${EPREFIX}"/usr/share/doc/${PF}
HAVE_LIBCTF=yes
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 643f3f5873f4..0c033c425cb5 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -141,6 +141,7 @@ src_configure() {
local confargs=(
# TODO: Maybe we should set the UNPRIV_UID to something? -3 is a bit... kludgy
--prefix="${EPREFIX}"/usr
+ # See https://github.com/oracle/dtrace-utils/issues/106 for man8 suffix
--mandir="${EPREFIX}"/usr/share/man/man8
--docdir="${EPREFIX}"/usr/share/doc/${PF}
HAVE_LIBCTF=yes
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 0:38 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 0:38 UTC (permalink / raw
To: gentoo-commits
commit: faa6748a876769c5cada11f8189c9185ecc7a6c3
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 00:37:02 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 00:37:02 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=faa6748a
dev-debug/dtrace: drop obsolete binutils-libs comment
I've asked dilfridge to update binutils-2.42 when he gets a chance
for one libctf patch we don't have yet but IIRC that patch doesn't
actually affect DTrace, just it came up in libabigail discussions.
Let's drop the comment as it's not really relevant now.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 4 ----
dev-debug/dtrace/dtrace-9999.ebuild | 4 ----
2 files changed, 8 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 2fb1849deaed..3db32276421a 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -25,10 +25,6 @@ IUSE="systemd test-install"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
-#
-# XXX: binutils-libs will need an extra patch for what dtrace does with
-# it in the absence of in-kernel CTF: it will be backported
-# to 2.42, but perhaps a patch would be a good idea before that?
DEPEND="
dev-libs/elfutils
dev-libs/libbpf
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 0c033c425cb5..3435783376e2 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -25,10 +25,6 @@ IUSE="systemd test-install"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
-#
-# XXX: binutils-libs will need an extra patch for what dtrace does with
-# it in the absence of in-kernel CTF: it will be backported
-# to 2.42, but perhaps a patch would be a good idea before that?
DEPEND="
dev-libs/elfutils
dev-libs/libbpf
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 0:42 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 0:42 UTC (permalink / raw
To: gentoo-commits
commit: 9751cb69aed06f2178ed56807f0eca32123cc999
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 00:41:11 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 00:41:15 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9751cb69
dev-debug/dtrace: tidy up more TODOs
Some of the TODOs were really upstream bugs we're waiting for resolution
on, not something we need to take action on at this time.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 4 +++-
dev-debug/dtrace/dtrace-9999.ebuild | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 7925d047db23..955143cae695 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -25,6 +25,8 @@ IUSE="systemd test-install"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
+#
+# TODO: can we make the wireshark dep conditional?
DEPEND="
dev-libs/elfutils
dev-libs/libbpf
@@ -61,7 +63,7 @@ BDEPEND="
>=sys-devel/bpf-toolchain-14.1.0
sys-devel/flex
"
-# TODO: Make this optional, valgrind.h is included unconditionally
+# This isn't yet optional, valgrind.h is included unconditionally
# https://github.com/oracle/dtrace-utils/issues/80
DEPEND+=" dev-debug/valgrind"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index ef9e581a040a..bf3f510929ed 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -25,6 +25,8 @@ IUSE="systemd test-install"
# XXX: right now, we auto-adapt to whether multilibs are present:
# should we force them to be? how?
+#
+# TODO: can we make the wireshark dep conditional?
DEPEND="
dev-libs/elfutils
dev-libs/libbpf
@@ -61,7 +63,7 @@ BDEPEND="
>=sys-devel/bpf-toolchain-14.1.0
sys-devel/flex
"
-# TODO: Make this optional, valgrind.h is included unconditionally
+# This isn't yet optional, valgrind.h is included unconditionally
# https://github.com/oracle/dtrace-utils/issues/80
DEPEND+=" dev-debug/valgrind"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 0:42 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 0:42 UTC (permalink / raw
To: gentoo-commits
commit: 32f33bd323a0fa640a017d945179f32bca672814
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 00:40:12 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 00:40:12 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32f33bd3
dev-debug/dtrace: consolidate comparison comments
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 4 ++--
dev-debug/dtrace/dtrace-9999.ebuild | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 3db32276421a..7925d047db23 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -174,10 +174,10 @@ pkg_postinst() {
# We need a udev reload to pick up the CUSE device node rules.
udev_reload
- # TODO: One option for this is to detect when it's needed (DOF stash layout changes)
- # and then e.g. sleep and restart for the user.
if [[ -n ${REPLACING_VERSIONS} ]]; then
# TODO: Make this more intelligent wrt comparison
+ # One option for this is to detect when it's needed (DOF stash layout changes)
+ # and then e.g. sleep and restart for the user.
if systemd_is_booted ; then
einfo "Restart the DTrace 'dtprobed' service after upgrades"
einfo "once all dtraces are stopped with:"
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index 3435783376e2..ef9e581a040a 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -174,10 +174,10 @@ pkg_postinst() {
# We need a udev reload to pick up the CUSE device node rules.
udev_reload
- # TODO: One option for this is to detect when it's needed (DOF stash layout changes)
- # and then e.g. sleep and restart for the user.
if [[ -n ${REPLACING_VERSIONS} ]]; then
# TODO: Make this more intelligent wrt comparison
+ # One option for this is to detect when it's needed (DOF stash layout changes)
+ # and then e.g. sleep and restart for the user.
if systemd_is_booted ; then
einfo "Restart the DTrace 'dtprobed' service after upgrades"
einfo "once all dtraces are stopped with:"
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 0:43 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 0:43 UTC (permalink / raw
To: gentoo-commits
commit: caf59e101d0c0e8bcd442268c993edec227597d6
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 00:43:01 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 00:43:01 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=caf59e10
dev-debug/dtrace: don't wrap einfo line so hard
I have a tendency to do this when something is indented as it's not
then obvious what the limit is. Oops.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild | 6 ++----
dev-debug/dtrace/dtrace-9999.ebuild | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
index 955143cae695..d3a2543a5f97 100644
--- a/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
+++ b/dev-debug/dtrace/dtrace-2.0.1.1-r2.ebuild
@@ -181,12 +181,10 @@ pkg_postinst() {
# One option for this is to detect when it's needed (DOF stash layout changes)
# and then e.g. sleep and restart for the user.
if systemd_is_booted ; then
- einfo "Restart the DTrace 'dtprobed' service after upgrades"
- einfo "once all dtraces are stopped with:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades once all dtraces are stopped with:"
einfo " systemctl try-restart dtprobed"
else
- einfo "Restart the DTrace 'dtprobed' service after upgrades"
- einfo "once all dtraces are stopped with:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades once all dtraces are stopped with:"
einfo " /etc/init.d/dtprobed restart"
fi
else
diff --git a/dev-debug/dtrace/dtrace-9999.ebuild b/dev-debug/dtrace/dtrace-9999.ebuild
index bf3f510929ed..5c1b20ad3238 100644
--- a/dev-debug/dtrace/dtrace-9999.ebuild
+++ b/dev-debug/dtrace/dtrace-9999.ebuild
@@ -181,12 +181,10 @@ pkg_postinst() {
# One option for this is to detect when it's needed (DOF stash layout changes)
# and then e.g. sleep and restart for the user.
if systemd_is_booted ; then
- einfo "Restart the DTrace 'dtprobed' service after upgrades"
- einfo "once all dtraces are stopped with:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades once all dtraces are stopped with:"
einfo " systemctl try-restart dtprobed"
else
- einfo "Restart the DTrace 'dtprobed' service after upgrades"
- einfo "once all dtraces are stopped with:"
+ einfo "Restart the DTrace 'dtprobed' service after upgrades once all dtraces are stopped with:"
einfo " /etc/init.d/dtprobed restart"
fi
else
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/
@ 2024-09-12 1:06 Sam James
0 siblings, 0 replies; 26+ messages in thread
From: Sam James @ 2024-09-12 1:06 UTC (permalink / raw
To: gentoo-commits
commit: 4ea63d2846762b2387678b5e35a8e866d819d9e3
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Sep 12 01:05:36 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Sep 12 01:05:36 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ea63d28
dev-debug/dtrace: fix metadata tag
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-debug/dtrace/metadata.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev-debug/dtrace/metadata.xml b/dev-debug/dtrace/metadata.xml
index 815fdabd199d..f9149c67c8a0 100644
--- a/dev-debug/dtrace/metadata.xml
+++ b/dev-debug/dtrace/metadata.xml
@@ -7,7 +7,7 @@
</maintainer>
<maintainer type="person">
<email>arsen@gentoo.org</email>
- <description>Arsen Arsenović</description>
+ <name>Arsen Arsenović</name>
</maintainer>
<use>
<flag name="test-install">
^ permalink raw reply related [flat|nested] 26+ messages in thread
end of thread, other threads:[~2024-09-12 1:06 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-19 23:27 [gentoo-commits] repo/gentoo:master commit in: dev-debug/dtrace/ Sam James
-- strict thread matches above, loose matches on Subject: below --
2024-09-12 1:06 Sam James
2024-09-12 0:43 Sam James
2024-09-12 0:42 Sam James
2024-09-12 0:42 Sam James
2024-09-12 0:38 Sam James
2024-09-12 0:38 Sam James
2024-09-12 0:30 Sam James
2024-09-12 0:10 Sam James
2024-09-11 23:59 Sam James
2024-09-11 3:35 Sam James
2024-09-10 13:58 Sam James
2024-08-30 18:13 Sam James
2024-08-25 18:49 Sam James
2024-08-22 12:54 Sam James
2024-08-22 12:36 Sam James
2024-08-22 12:36 Sam James
2024-08-22 12:22 Sam James
2024-08-20 1:49 Sam James
2024-08-20 1:49 Sam James
2024-08-20 1:49 Sam James
2024-08-19 20:16 Sam James
2024-08-18 22:59 Sam James
2024-08-18 21:47 Sam James
2024-08-18 21:42 Sam James
2024-08-18 21:36 Sam James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox