From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 08617159C9B for ; Sun, 11 Aug 2024 10:11:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5D6922BC140; Sun, 11 Aug 2024 10:11:16 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 42ACA2BC140 for ; Sun, 11 Aug 2024 10:11:16 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E8075343127 for ; Sun, 11 Aug 2024 10:11:14 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id D512B1EEE for ; Sun, 11 Aug 2024 10:11:10 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1723371062.e28b1e4e0053c1f2827ba62eaf2da3b7b8b824de.sam@gentoo> Subject: [gentoo-commits] proj/gentoo-functions:master commit in: / X-VCS-Repository: proj/gentoo-functions X-VCS-Files: test-functions X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: e28b1e4e0053c1f2827ba62eaf2da3b7b8b824de X-VCS-Branch: master Date: Sun, 11 Aug 2024 10:11:10 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 9ef0b217-7e9f-4b66-b399-b32c23852f6e X-Archives-Hash: 2f3b578f3b4e4841a934c34135cc65e5 commit: e28b1e4e0053c1f2827ba62eaf2da3b7b8b824de Author: Kerin Millar plushkava net> AuthorDate: Fri Aug 9 10:36:58 2024 +0000 Commit: Sam James gentoo org> CommitDate: Sun Aug 11 10:11:02 2024 +0000 URL: https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=e28b1e4e test-functions: comment as to the implications of test_local() failing In particular, comment as to why the test can be expected to fail for ksh93 and - in some cases - yash. Signed-off-by: Kerin Millar plushava.net> Signed-off-by: Sam James gentoo.org> test-functions | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test-functions b/test-functions index 7c848c1..0ab203b 100755 --- a/test-functions +++ b/test-functions @@ -1180,6 +1180,14 @@ if [ "${PORTAGE_BIN_PATH}" ] && [ "${S}" ]; then fi if ! test_local; then + # Currently, this test is known to fail for ksh93 and yash. As regards + # the former, the commonly implemented behaviour of "local" can be + # approximated with "typeset". However, to use typeset in this way + # requires the use of the function f { ...; } syntax instead of the + # POSIX-compatible f() compound-command syntax. Further, ksh93 + # implements static scoping. As regards the latter, yash is rather + # stringent and simply disables its local builtin if in its posix mode. + # Running yash as "sh" would be one way of activating said mode. rc=1 elif ! GENFUN_MODULES="portage rc" . ./functions.sh; then bailout "Couldn't source ./functions.sh"