From: "Andreas Sturmlechner" <asturm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-frameworks/sonnet/files/, kde-frameworks/sonnet/
Date: Fri, 5 Jul 2024 13:16:56 +0000 (UTC) [thread overview]
Message-ID: <1720185349.34eccab8e4f02db922e8ff0915c79db5ef36c960.asturm@gentoo> (raw)
commit: 34eccab8e4f02db922e8ff0915c79db5ef36c960
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Fri Jul 5 13:09:11 2024 +0000
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Fri Jul 5 13:15:49 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34eccab8
kde-frameworks/sonnet: Fix build with USE=-qml
Pending upstream MR:
https://invent.kde.org/frameworks/sonnet/-/merge_requests/108
Closes: https://bugs.gentoo.org/935488
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
.../sonnet/files/sonnet-6.3.0-cmake.patch | 42 ++++++++++++++++++++++
kde-frameworks/sonnet/sonnet-6.3.0.ebuild | 3 ++
2 files changed, 45 insertions(+)
diff --git a/kde-frameworks/sonnet/files/sonnet-6.3.0-cmake.patch b/kde-frameworks/sonnet/files/sonnet-6.3.0-cmake.patch
new file mode 100644
index 000000000000..b218b5618339
--- /dev/null
+++ b/kde-frameworks/sonnet/files/sonnet-6.3.0-cmake.patch
@@ -0,0 +1,42 @@
+From 7ee068b3da7e8b60a6c0a5c95b9026ef2c82ebb7 Mon Sep 17 00:00:00 2001
+From: Andreas Sturmlechner <asturm@gentoo.org>
+Date: Fri, 5 Jul 2024 15:03:09 +0200
+Subject: [PATCH] Fix SONNET_USE_QML=OFF by moving ECMQmlModule behind the
+ conditional
+
+Otherwise we still end up with
+
+> -- Could NOT find Qt6Qml (missing: Qt6Qml_DIR)
+
+and finally
+
+> Failed setting up ECMQmlModule
+
+Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
+---
+ CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 3427bb12..892f77d7 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -22,7 +22,6 @@ include(ECMSetupVersion)
+ include(ECMGenerateHeaders)
+ include(ECMGenerateQmlTypes)
+ include(ECMFindQmlModule)
+-include(ECMQmlModule)
+ include(ECMDeprecationSettings)
+ include(ECMAddQch)
+ include(ECMPoQmTools)
+@@ -39,6 +38,7 @@ if(SONNET_USE_WIDGETS)
+ endif()
+
+ if(SONNET_USE_QML)
++ include(ECMQmlModule)
+ find_package(Qt6 ${REQUIRED_QT_VERSION} CONFIG REQUIRED Quick)
+ endif()
+
+--
+2.45.2
+
diff --git a/kde-frameworks/sonnet/sonnet-6.3.0.ebuild b/kde-frameworks/sonnet/sonnet-6.3.0.ebuild
index ce1b9390145e..91f260142222 100644
--- a/kde-frameworks/sonnet/sonnet-6.3.0.ebuild
+++ b/kde-frameworks/sonnet/sonnet-6.3.0.ebuild
@@ -22,6 +22,9 @@ DEPEND="
RDEPEND="${DEPEND}"
BDEPEND=">=dev-qt/qttools-${QTMIN}:6[linguist]"
+# Pending: https://invent.kde.org/frameworks/sonnet/-/merge_requests/108
+PATCHES=( "${FILESDIR}/${P}-cmake.patch" ) # bug 935488
+
CMAKE_SKIP_TESTS=(
# bug 779994
sonnet-test_autodetect
next reply other threads:[~2024-07-05 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 13:16 Andreas Sturmlechner [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-28 18:37 [gentoo-commits] repo/gentoo:master commit in: kde-frameworks/sonnet/files/, kde-frameworks/sonnet/ Johannes Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1720185349.34eccab8e4f02db922e8ff0915c79db5ef36c960.asturm@gentoo \
--to=asturm@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox