public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/pahole/
Date: Thu, 20 Jun 2024 10:31:38 +0000 (UTC)	[thread overview]
Message-ID: <1718879166.642e5d4d082fd1ea2546d701cedc05dffb67cc41.sam@gentoo> (raw)

commit:     642e5d4d082fd1ea2546d701cedc05dffb67cc41
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Jun 20 10:26:06 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Jun 20 10:26:06 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=642e5d4d

dev-util/pahole: optimize src_unpack

As just done in util-linux & btrfs-progs.

Signed-off-by: Sam James <sam <AT> gentoo.org>

 dev-util/pahole/pahole-1.26-r1.ebuild | 22 +++++++++-------------
 dev-util/pahole/pahole-9999.ebuild    | 22 +++++++++-------------
 2 files changed, 18 insertions(+), 26 deletions(-)

diff --git a/dev-util/pahole/pahole-1.26-r1.ebuild b/dev-util/pahole/pahole-1.26-r1.ebuild
index e9c3238b4568..8fd7c7683406 100644
--- a/dev-util/pahole/pahole-1.26-r1.ebuild
+++ b/dev-util/pahole/pahole-1.26-r1.ebuild
@@ -52,21 +52,17 @@ src_unpack() {
 	if [[ ${PV} == 9999 ]] ; then
 		git-r3_src_unpack
 		return
-	elif use verify-sig ; then
-		mkdir "${T}"/verify-sig || die
-		pushd "${T}"/verify-sig &>/dev/null || die
-
-		# Upstream sign the decompressed .tar
-		# Let's do it separately in ${T} then cleanup to avoid external
-		# effects on normal unpack.
-		xz -d -c "${DISTDIR}"/${MY_P}.tar.xz > ${MY_P}.tar || die
-		verify-sig_verify_detached ${MY_P}.tar "${DISTDIR}"/${MY_P}.tar.sign
-
-		popd &>/dev/null || die
-		rm -r "${T}"/verify-sig || die
 	fi
 
-	default
+	# Upstream sign the decompressed .tar
+	if use verify-sig; then
+		einfo "Unpacking ${MY_P}.tar.xz ..."
+		verify-sig_verify_detached - "${DISTDIR}"/${MY_P}.tar.sign \
+			< <(xz -cd "${DISTDIR}"/${MY_P}.tar.xz | tee >(tar -x))
+		assert "Unpack failed"
+	else
+		default
+	fi
 }
 
 src_prepare() {

diff --git a/dev-util/pahole/pahole-9999.ebuild b/dev-util/pahole/pahole-9999.ebuild
index e9c3238b4568..8fd7c7683406 100644
--- a/dev-util/pahole/pahole-9999.ebuild
+++ b/dev-util/pahole/pahole-9999.ebuild
@@ -52,21 +52,17 @@ src_unpack() {
 	if [[ ${PV} == 9999 ]] ; then
 		git-r3_src_unpack
 		return
-	elif use verify-sig ; then
-		mkdir "${T}"/verify-sig || die
-		pushd "${T}"/verify-sig &>/dev/null || die
-
-		# Upstream sign the decompressed .tar
-		# Let's do it separately in ${T} then cleanup to avoid external
-		# effects on normal unpack.
-		xz -d -c "${DISTDIR}"/${MY_P}.tar.xz > ${MY_P}.tar || die
-		verify-sig_verify_detached ${MY_P}.tar "${DISTDIR}"/${MY_P}.tar.sign
-
-		popd &>/dev/null || die
-		rm -r "${T}"/verify-sig || die
 	fi
 
-	default
+	# Upstream sign the decompressed .tar
+	if use verify-sig; then
+		einfo "Unpacking ${MY_P}.tar.xz ..."
+		verify-sig_verify_detached - "${DISTDIR}"/${MY_P}.tar.sign \
+			< <(xz -cd "${DISTDIR}"/${MY_P}.tar.xz | tee >(tar -x))
+		assert "Unpack failed"
+	else
+		default
+	fi
 }
 
 src_prepare() {


             reply	other threads:[~2024-06-20 10:31 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 10:31 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-04-08 11:58 [gentoo-commits] repo/gentoo:master commit in: dev-util/pahole/ Arthur Zamarin
2025-04-08  9:02 Sam James
2025-04-08  9:02 Sam James
2025-04-08  9:02 Sam James
2025-04-08  9:02 Sam James
2025-04-08  9:02 Sam James
2025-04-08  2:53 Sam James
2025-04-08  1:21 Sam James
2025-01-23 15:53 Matthias Schwarzott
2025-01-22 20:16 Matthias Schwarzott
2025-01-22 20:16 Matthias Schwarzott
2025-01-12 21:22 David Seifert
2024-10-04  7:58 Sam James
2024-09-05 17:59 Sam James
2024-09-05 14:32 Sam James
2024-09-05 14:30 Sam James
2024-09-05 14:30 Sam James
2024-09-05 12:35 Sam James
2024-09-05 12:33 Sam James
2024-09-05 12:33 Sam James
2024-08-25 10:18 Jakov Smolić
2024-08-25 10:18 Jakov Smolić
2024-08-25 10:18 Jakov Smolić
2024-08-25 10:18 Jakov Smolić
2024-08-25  9:51 Arthur Zamarin
2024-08-25  9:51 Arthur Zamarin
2024-06-24 13:06 Matthias Schwarzott
2024-06-22  5:50 Matthias Schwarzott
2024-06-05  6:32 Matthias Schwarzott
2024-05-28 13:54 Matthias Schwarzott
2024-03-13  4:48 Sam James
2024-03-10 23:21 Jakov Smolić
2024-03-10 20:00 Arthur Zamarin
2024-03-10 20:00 Arthur Zamarin
2024-03-10 19:52 Arthur Zamarin
2024-03-10 19:52 Arthur Zamarin
2024-02-28 20:10 Matthias Schwarzott
2023-07-16 14:23 Sam James
2023-07-16 14:23 Sam James
2023-07-16 14:23 Sam James
2023-07-16 14:23 Sam James
2023-07-16 14:20 Sam James
2023-07-11 11:03 WANG Xuerui
2023-06-30  4:37 Matthias Schwarzott
2023-04-15  7:17 Matthias Schwarzott
2023-03-22 18:45 Andreas Sturmlechner
2023-03-13 22:11 Sam James
2023-03-13 21:24 Sam James
2023-03-13 20:51 Sam James
2023-03-13 20:51 Sam James
2023-03-13 20:35 Arthur Zamarin
2023-01-19  2:49 Sam James
2022-09-05  7:35 Matthias Schwarzott
2022-06-05  2:32 Matt Turner
2022-05-22  0:54 Yixun Lan
2022-05-20  6:11 Matthias Schwarzott
2022-05-20  6:11 Matthias Schwarzott
2022-04-15  6:36 Arthur Zamarin
2022-04-13 23:01 Sam James
2022-03-12 16:26 Arthur Zamarin
2022-03-10 10:10 Jakov Smolić
2022-03-10  9:03 Jakov Smolić
2021-12-17 11:45 Matthias Schwarzott
2021-12-16 21:45 Georgy Yakovlev
2021-11-07 16:16 罗百科
2021-06-02  8:20 Matthias Schwarzott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1718879166.642e5d4d082fd1ea2546d701cedc05dffb67cc41.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox