From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-commits+bounces-1644261-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id A229E15817D
for <garchives@archives.gentoo.org>; Tue, 18 Jun 2024 02:09:21 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 8C4F9E2A81;
Tue, 18 Jun 2024 02:09:20 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 69B0EE2A83
for <gentoo-commits@lists.gentoo.org>; Tue, 18 Jun 2024 02:09:20 +0000 (UTC)
Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by smtp.gentoo.org (Postfix) with ESMTPS id D857A335D0F
for <gentoo-commits@lists.gentoo.org>; Tue, 18 Jun 2024 02:09:18 +0000 (UTC)
Received: from localhost.localdomain (localhost [IPv6:::1])
by oystercatcher.gentoo.org (Postfix) with ESMTP id 13A7D1D29
for <gentoo-commits@lists.gentoo.org>; Tue, 18 Jun 2024 02:09:17 +0000 (UTC)
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: 8bit
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org>
Message-ID: <1718676532.5037161d1847e7b51fac52e304fb120682455d8b.sam@gentoo>
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-cpp/gtest/
X-VCS-Repository: repo/gentoo
X-VCS-Files: dev-cpp/gtest/gtest-1.14.0-r1.ebuild dev-cpp/gtest/gtest-9999.ebuild
X-VCS-Directories: dev-cpp/gtest/
X-VCS-Committer: sam
X-VCS-Committer-Name: Sam James
X-VCS-Revision: 5037161d1847e7b51fac52e304fb120682455d8b
X-VCS-Branch: master
Date: Tue, 18 Jun 2024 02:09:17 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-Archives-Salt: 8e544458-0b4b-4820-a868-27a416012014
X-Archives-Hash: 00d29419abe1decbccfd3b6a54c941f1
commit: 5037161d1847e7b51fac52e304fb120682455d8b
Author: Peter Levine <plevine457 <AT> gmail <DOT> com>
AuthorDate: Tue Jun 18 01:38:20 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Jun 18 02:08:52 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5037161d
dev-cpp/gtest: fix test failure on x86
Testing on x86 architecture causes a unittest to fail due to
a floating-point precision discrepancy. Like Debian, we add
-ffloat-store until upstream addresses the issue.
Closes: https://bugs.gentoo.org/905007
Closes: https://github.com/gentoo/gentoo/pull/37191
Suggested-by: Sam James <sam <AT> gentoo.org>
Signed-off-by: Peter Levine <plevine457 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-cpp/gtest/gtest-1.14.0-r1.ebuild | 7 ++++++-
dev-cpp/gtest/gtest-9999.ebuild | 7 ++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/dev-cpp/gtest/gtest-1.14.0-r1.ebuild b/dev-cpp/gtest/gtest-1.14.0-r1.ebuild
index aed50c96f6e4..ecb89314e216 100644
--- a/dev-cpp/gtest/gtest-1.14.0-r1.ebuild
+++ b/dev-cpp/gtest/gtest-1.14.0-r1.ebuild
@@ -51,7 +51,12 @@ multilib_src_configure() {
-Dgmock_build_tests=$(usex test)
-Dgtest_build_tests=$(usex test)
)
- use test && mycmakeargs+=( -DPython3_EXECUTABLE="${PYTHON}" )
+ if use test; then
+ if use x86 || use x86-linux; then
+ append-cxxflags -ffloat-store # bug #905007
+ fi
+ mycmakeargs+=( -DPython3_EXECUTABLE="${PYTHON}" )
+ fi
cmake_src_configure
}
diff --git a/dev-cpp/gtest/gtest-9999.ebuild b/dev-cpp/gtest/gtest-9999.ebuild
index aed50c96f6e4..ecb89314e216 100644
--- a/dev-cpp/gtest/gtest-9999.ebuild
+++ b/dev-cpp/gtest/gtest-9999.ebuild
@@ -51,7 +51,12 @@ multilib_src_configure() {
-Dgmock_build_tests=$(usex test)
-Dgtest_build_tests=$(usex test)
)
- use test && mycmakeargs+=( -DPython3_EXECUTABLE="${PYTHON}" )
+ if use test; then
+ if use x86 || use x86-linux; then
+ append-cxxflags -ffloat-store # bug #905007
+ fi
+ mycmakeargs+=( -DPython3_EXECUTABLE="${PYTHON}" )
+ fi
cmake_src_configure
}