From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2B019158064 for ; Fri, 10 May 2024 03:03:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3B115E2B14; Fri, 10 May 2024 03:03:22 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1E72CE2B14 for ; Fri, 10 May 2024 03:03:22 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 064FF343095 for ; Fri, 10 May 2024 03:03:21 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 1E70A1A38 for ; Fri, 10 May 2024 03:03:19 +0000 (UTC) From: "Ionen Wolkens" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ionen Wolkens" Message-ID: <1715310043.4778d9cbaca208869cb80f606db24d857c75aa3f.ionen@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/mingw64-toolchain/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-util/mingw64-toolchain/mingw64-toolchain-11.0.0_p2.ebuild dev-util/mingw64-toolchain/mingw64-toolchain-11.0.1.ebuild X-VCS-Directories: dev-util/mingw64-toolchain/ X-VCS-Committer: ionen X-VCS-Committer-Name: Ionen Wolkens X-VCS-Revision: 4778d9cbaca208869cb80f606db24d857c75aa3f X-VCS-Branch: master Date: Fri, 10 May 2024 03:03:19 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: f6964bce-2ff2-4e40-b9ef-249e6aa25406 X-Archives-Hash: 813d36ff5b792f834881bee1fe539ad3 commit: 4778d9cbaca208869cb80f606db24d857c75aa3f Author: Ionen Wolkens gentoo org> AuthorDate: Fri May 10 02:36:23 2024 +0000 Commit: Ionen Wolkens gentoo org> CommitDate: Fri May 10 03:00:43 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4778d9cb dev-util/mingw64-toolchain: filter -fstack-protector* again Used to be done because it was straight up broken (couldn't build), but now it's successfully causing problems and it's not obvious for upstreams to fix these issues with mingw. There may be real issues in dxvk & others, but support for this is new in mingw (also only partial), and believe using this can be considered too experimental/early "here". Still allowing it with USE=custom-cflags for those that really want it and don't mind if it breaks some components they don't use. Skipping revbump given it's an unusual configuration given users normally don't pass this in *FLAGS but rather rely on the toolchain's defaults. mingw64-toolchain-11.0.1 will also be keyworded in not that long for rebuilds. Only needed for mingw runtime, so the toolchain itself is still using it through the system-wide defaults. May revisit eventually. Not doing this for crossdev+mingw64-runtime main package again, these are for more expert use in the first place. Bug: https://bugs.gentoo.org/870136 Closes: https://bugs.gentoo.org/931512 Signed-off-by: Ionen Wolkens gentoo.org> dev-util/mingw64-toolchain/mingw64-toolchain-11.0.0_p2.ebuild | 6 ++++++ dev-util/mingw64-toolchain/mingw64-toolchain-11.0.1.ebuild | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.0_p2.ebuild b/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.0_p2.ebuild index 68c62e65ac14..1e512377b27b 100644 --- a/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.0_p2.ebuild +++ b/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.0_p2.ebuild @@ -211,6 +211,12 @@ src_compile() { filter-flags '-fuse-ld=*' filter-flags '-mfunction-return=thunk*' #878849 + # support for stack-protector is still new and experimental + # for mingw and issues can also be harder to debug + fix for + # upstreams using it, if feeling concerned about security + # would advise to either not use wine or at least contain it + use custom-cflags || filter-flags '-fstack-protector*' #931512 + # some bashrc-mv users tend to do CFLAGS="${LDFLAGS}" and then # strip-unsupported-flags miss these during compile-only tests # (primarily done for 23.0 profiles' -z, not full coverage) diff --git a/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.1.ebuild b/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.1.ebuild index 4003b26827a8..09f8b50f64a4 100644 --- a/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.1.ebuild +++ b/dev-util/mingw64-toolchain/mingw64-toolchain-11.0.1.ebuild @@ -221,6 +221,12 @@ src_compile() { filter-flags '-fuse-ld=*' filter-flags '-mfunction-return=thunk*' #878849 + # support for stack-protector is still new and experimental + # for mingw and issues can also be harder to debug + fix for + # upstreams using it, if feeling concerned about security + # would advise to either not use wine or at least contain it + use custom-cflags || filter-flags '-fstack-protector*' #931512 + # some bashrc-mv users tend to do CFLAGS="${LDFLAGS}" and then # strip-unsupported-flags miss these during compile-only tests # (primarily done for 23.0 profiles' -z, not full coverage)