From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/ruff/
Date: Fri, 10 May 2024 01:58:48 +0000 (UTC) [thread overview]
Message-ID: <1715306260.f1376d3cec40d14442c4c48acb053ea9a4e3d37c.sam@gentoo> (raw)
commit: f1376d3cec40d14442c4c48acb053ea9a4e3d37c
Author: Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Fri May 10 01:49:57 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri May 10 01:57:40 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1376d3c
dev-util/ruff: fix tests rebuilding jemalloc against vendored copy
I will never understand why people INSIST on "local -x GLOBAL_VAR" as
though it is somehow clean when its fundamental intention is to be
global.
End result: repeating the same block of code multiple times so you can
pseudo-globally set it locally each time you use it. *After* the code is
buggy for a while.
I have a recentish custom QA check that catches it though:
* QA Notice: cargo built package contains possibly vendored code
*
* crate tikv-jemalloc-sys: jemalloc.sym.o arena.sym.o background_thread.sym.o base.sym.o bin.sym.o bin_info.sym.o bitmap.sym.o buf_writer.sym.o cache_bin.sym.o ckh.sym.o counter.sym.o ctl.sym.o decay.sym.o ecache.sym.o div.sym.o edata.sym.o edata_cache.sym.o ehooks.sym.o emap.sym.o eset.sym.o exp_grow.sym.o extent.sym.o extent_dss.sym.o extent_mmap.sym.o fxp.sym.o san.sym.o san_bump.sym.o hook.sym.o hpa.sym.o hpa_hooks.sym.o hpdata.sym.o inspect.sym.o large.sym.o log.sym.o malloc_io.sym.o mutex.sym.o nstime.sym.o pa.sym.o pa_extra.sym.o pai.sym.o pac.sym.o pages.sym.o peak_event.sym.o prof.sym.o prof_data.sym.o prof_log.sym.o prof_recent.sym.o prof_stats.sym.o prof_sys.sym.o psset.sym.o rtree.sym.o safety_check.sym.o sc.sym.o sec.sym.o stats.sym.o sz.sym.o tcache.sym.o test_hooks.sym.o thread_event.sym.o ticker.sym.o tsd.sym.o witness.sym.o jemalloc.o arena.o background_thread.o base.o bin.o bin_info.o bitmap.o buf_writer.o cache_bin.o ckh.o counter.o ctl.o decay.o div.o ecache.o ed
ata.o edata_cache.o ehooks.o emap.o eset.o exp_grow.o extent.o extent_dss.o extent_mmap.o fxp.o san.o san_bump.o hook.o hpa.o hpa_hooks.o hpdata.o inspect.o large.o log.o malloc_io.o mutex.o nstime.o pa.o pa_extra.o pai.o pac.o pages.o peak_event.o prof.o prof_data.o prof_log.o prof_recent.o prof_stats.o prof_sys.o psset.o rtree.o safety_check.o sc.o sec.o stats.o sz.o tcache.o test_hooks.o thread_event.o ticker.o tsd.o witness.o jemalloc.pic.o arena.pic.o background_thread.pic.o base.pic.o bin.pic.o bin_info.pic.o bitmap.pic.o buf_writer.pic.o cache_bin.pic.o ckh.pic.o counter.pic.o ctl.pic.o decay.pic.o div.pic.o ecache.pic.o edata.pic.o edata_cache.pic.o ehooks.pic.o emap.pic.o eset.pic.o exp_grow.pic.o extent.pic.o extent_dss.pic.o extent_mmap.pic.o fxp.pic.o san.pic.o san_bump.pic.o hook.pic.o hpa.pic.o hpa_hooks.pic.o hpdata.pic.o inspect.pic.o large.pic.o log.pic.o malloc_io.pic.o mutex.pic.o nstime.pic.o pa.pic.o pa_extra.pic.o pai.pic.o pac.pic.o pages.pic.o peak_event.pic.
o prof.pic.o prof_data.pic.o prof_log.pic.o prof_recent.pic.o prof_stats.pic.o prof_sys.pic.o psset.pic.o rtree.pic.o safety_check.pic.o sc.pic.o sec.pic.o stats.pic.o sz.pic.o tcache.pic.o test_hooks.pic.o thread_event.pic.o ticker.pic.o tsd.pic.o witness.pic.o
* QA Notice: cargo built package contains possibly vendored code from unsolvable crates
*
* ring
Only reproducible when building with FEATURES=test, however, which I
don't usually do on syncing @world.
Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-util/ruff/ruff-0.4.4.ebuild | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/dev-util/ruff/ruff-0.4.4.ebuild b/dev-util/ruff/ruff-0.4.4.ebuild
index 437bdd839436..da6cf3e1d708 100644
--- a/dev-util/ruff/ruff-0.4.4.ebuild
+++ b/dev-util/ruff/ruff-0.4.4.ebuild
@@ -427,6 +427,11 @@ src_compile() {
}
src_test() {
+ # Gentoo bug #927338
+ if use !elibc_musl && use !elibc_Darwin && use !elibc_bionic; then
+ local -x CARGO_FEATURE_UNPREFIXED_MALLOC_ON_SUPPORTED_PLATFORMS=1
+ local -x JEMALLOC_OVERRIDE="${ESYSROOT}/usr/$(get_libdir)"/libjemalloc.so
+ fi
cargo_src_test
}
next reply other threads:[~2024-05-10 1:58 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 1:58 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-15 23:00 [gentoo-commits] repo/gentoo:master commit in: dev-util/ruff/ Patrick McLean
2024-11-15 23:00 Patrick McLean
2024-11-11 19:17 Patrick McLean
2024-11-11 19:17 Patrick McLean
2024-11-03 19:11 Eli Schwartz
2024-10-30 17:21 Arthur Zamarin
2024-10-24 16:38 Patrick McLean
2024-10-24 16:38 Patrick McLean
2024-10-24 0:12 Jakov Smolić
2024-10-17 20:57 Patrick McLean
2024-10-17 20:57 Patrick McLean
2024-10-09 17:31 Eli Schwartz
2024-09-26 16:13 Patrick McLean
2024-09-26 16:13 Patrick McLean
2024-09-25 4:30 Eli Schwartz
2024-09-20 18:12 Eli Schwartz
2024-09-13 23:11 Patrick McLean
2024-09-13 23:11 Patrick McLean
2024-09-05 18:17 Patrick McLean
2024-09-05 18:17 Patrick McLean
2024-08-29 19:01 Patrick McLean
2024-08-29 19:00 Patrick McLean
2024-08-22 17:56 Patrick McLean
2024-08-22 17:56 Patrick McLean
2024-08-17 0:10 Patrick McLean
2024-08-16 23:35 Patrick McLean
2024-08-15 17:36 Patrick McLean
2024-08-15 17:36 Patrick McLean
2024-08-09 17:46 Patrick McLean
2024-07-29 1:19 Eli Schwartz
2024-07-22 4:50 Eli Schwartz
2024-07-16 4:11 Eli Schwartz
2024-06-28 16:58 Patrick McLean
2024-06-28 16:57 Patrick McLean
2024-06-17 9:39 James Le Cuirot
2024-06-06 0:44 Patrick McLean
2024-06-04 6:56 Sam James
2024-05-30 2:21 Sam James
2024-05-23 21:52 Sam James
2024-05-23 16:43 Patrick McLean
2024-05-10 1:58 Sam James
2024-05-07 15:13 Patrick McLean
2024-04-25 21:07 Patrick McLean
2024-04-19 18:41 Patrick McLean
2024-04-18 21:49 Patrick McLean
2024-04-18 21:49 Patrick McLean
2024-04-01 20:11 Patrick McLean
2024-04-01 19:50 Patrick McLean
2024-03-22 5:33 Sam James
2024-03-18 16:29 Patrick McLean
2024-03-14 6:40 Sam James
2024-03-14 6:40 Sam James
2024-03-14 6:40 Sam James
2024-03-14 6:40 Sam James
2024-03-14 6:40 Sam James
2024-02-29 17:15 Patrick McLean
2024-02-21 22:15 Patrick McLean
2024-02-06 18:56 Patrick McLean
2024-02-04 17:10 WANG Xuerui
2024-01-15 14:01 Sam James
2024-01-15 9:17 Ulrich Müller
2024-01-12 20:39 Patrick McLean
2024-01-12 19:49 Patrick McLean
2023-12-13 20:55 Patrick McLean
2023-12-05 1:00 Patrick McLean
2023-11-17 21:43 Patrick McLean
2023-11-09 1:54 Patrick McLean
2023-10-26 21:18 Patrick McLean
2023-10-24 18:48 Patrick McLean
2023-10-19 22:07 Patrick McLean
2023-10-16 23:25 Patrick McLean
2023-10-16 23:13 Patrick McLean
2023-10-02 20:04 Patrick McLean
2023-09-22 21:57 Patrick McLean
2023-09-16 0:32 Patrick McLean
2023-09-12 17:43 Patrick McLean
2023-09-11 18:50 Patrick McLean
2023-09-11 18:50 Patrick McLean
2023-09-11 18:50 Patrick McLean
2023-09-08 19:36 Patrick McLean
2023-09-08 19:29 Patrick McLean
2023-08-26 0:14 Patrick McLean
2023-08-10 21:55 Patrick McLean
2023-08-08 20:48 Patrick McLean
2023-08-07 23:38 Patrick McLean
2023-07-31 22:58 Patrick McLean
2023-07-24 22:15 Patrick McLean
2023-07-22 1:22 Patrick McLean
2023-07-13 0:03 Patrick McLean
2023-07-05 16:17 Patrick McLean
2023-06-22 18:07 Patrick McLean
2023-06-21 19:04 Patrick McLean
2023-06-21 4:52 Patrick McLean
2023-06-21 4:42 Patrick McLean
2023-06-21 4:42 Patrick McLean
2023-06-21 4:42 Patrick McLean
2023-06-20 21:27 Patrick McLean
2023-06-08 20:55 Patrick McLean
2023-06-08 20:38 Patrick McLean
2023-06-01 20:34 Patrick McLean
2023-05-05 17:58 Patrick McLean
2023-05-02 18:02 Patrick McLean
2023-04-25 19:20 Patrick McLean
2023-04-25 19:00 Patrick McLean
2023-04-25 18:08 Patrick McLean
2023-04-21 1:07 Patrick McLean
2023-04-21 1:07 Patrick McLean
2023-04-10 19:21 Patrick McLean
2023-03-24 19:29 Patrick McLean
2023-03-23 1:31 Patrick McLean
2023-03-23 1:27 Patrick McLean
2023-02-28 18:43 Patrick McLean
2023-02-28 18:43 Patrick McLean
2023-02-23 19:55 Patrick McLean
2023-02-22 20:24 Patrick McLean
2023-02-15 23:19 Patrick McLean
2023-02-15 21:36 Patrick McLean
2023-02-15 21:15 Patrick McLean
2023-02-09 20:04 Patrick McLean
2023-02-08 23:13 Patrick McLean
2023-02-08 20:34 Patrick McLean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1715306260.f1376d3cec40d14442c4c48acb053ea9a4e3d37c.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox