From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id AE00C158043 for ; Fri, 29 Mar 2024 18:47:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CC8C4E2A92; Fri, 29 Mar 2024 18:47:52 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B5686E2A92 for ; Fri, 29 Mar 2024 18:47:52 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id EDCCA34311F for ; Fri, 29 Mar 2024 18:47:51 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 2FA601609 for ; Fri, 29 Mar 2024 18:47:50 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1711737909.304ed046251c64dedc3e34e54b3de6e2edbc0f9f.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: metadata/install-qa-check.d/ X-VCS-Repository: repo/gentoo X-VCS-Files: metadata/install-qa-check.d/08gentoo-paths X-VCS-Directories: metadata/install-qa-check.d/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 304ed046251c64dedc3e34e54b3de6e2edbc0f9f X-VCS-Branch: master Date: Fri, 29 Mar 2024 18:47:50 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: bb6aedf1-6cea-44b4-9717-cda2cbf274fb X-Archives-Hash: 15d9f0c3956e491af53afb553559b3dd commit: 304ed046251c64dedc3e34e54b3de6e2edbc0f9f Author: Eli Schwartz gmail com> AuthorDate: Thu Mar 28 06:34:51 2024 +0000 Commit: Sam James gentoo org> CommitDate: Fri Mar 29 18:45:09 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=304ed046 metadata/install-qa-check.d: make the FHS paths warning easier to read * QA Notice: The ebuild is installing to one or more unexpected paths: * * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/legion_prof_files * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/serializer_examples * * Please fix the ebuild to use correct FHS/Gentoo policy paths. This message is hard to understand. Is it saying that the resulting package contains files prefixed with ${D} which would be immensely broken? Is it saying that these paths are *directories* and the FHS does not approve of directories in /usr/bin/*/? In fact, it's the latter. Fix this in two ways: - clarify that it's an unexpected directory, not just some kind of path - strip ${D} so that people can better visualize what sort of path gets installed. This has the downside of not being able to copy/paste the path in order to inspect the image directory, but I think this is a very small downside. Usually by the time you see this message, portage has cleaned up. And if it hasn't, you can still copy/paste that from: Completed installing sys-cluster/legion-9999 into /var/tmp/portage/sys-cluster/legion-9999/image Signed-off-by: Eli Schwartz gmail.com> Signed-off-by: Sam James gentoo.org> metadata/install-qa-check.d/08gentoo-paths | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/metadata/install-qa-check.d/08gentoo-paths b/metadata/install-qa-check.d/08gentoo-paths index 5b8607fd5f96..0b92a7a1c132 100644 --- a/metadata/install-qa-check.d/08gentoo-paths +++ b/metadata/install-qa-check.d/08gentoo-paths @@ -70,9 +70,9 @@ gentoo_path_check() { # report # ------ if [[ -n ${bad_paths[@]} ]]; then - eqawarn "QA Notice: The ebuild is installing to one or more unexpected paths:" + eqawarn "QA Notice: The ebuild is installing to one or more unexpected directories:" eqawarn - eqatag -v non-gentoo-paths "${bad_paths[@]}" + eqatag -v non-gentoo-paths "${bad_paths[@]#${D%/}}" eqawarn eqawarn "Please fix the ebuild to use correct FHS/Gentoo policy paths." fi