From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5E3FE158041 for ; Fri, 29 Mar 2024 02:29:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3D2D42BC019; Fri, 29 Mar 2024 02:28:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1CC272BC019 for ; Fri, 29 Mar 2024 02:28:59 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 43856343073 for ; Fri, 29 Mar 2024 02:28:58 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 5726315E2 for ; Fri, 29 Mar 2024 02:28:56 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1711679302.411f7e106012a6af37a5d14e2a62572c2f0b4f6a.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-build/libtool/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-build/libtool/libtool-2.4.7-r4.ebuild X-VCS-Directories: dev-build/libtool/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 411f7e106012a6af37a5d14e2a62572c2f0b4f6a X-VCS-Branch: master Date: Fri, 29 Mar 2024 02:28:56 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: a8a9f4ec-8a6e-4d71-b988-5f1305fdbdd0 X-Archives-Hash: 44db05b47af7c0a78476e013eba621e4 commit: 411f7e106012a6af37a5d14e2a62572c2f0b4f6a Author: Eli Schwartz gmail com> AuthorDate: Wed Mar 27 06:16:21 2024 +0000 Commit: Sam James gentoo org> CommitDate: Fri Mar 29 02:28:22 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=411f7e10 dev-build/libtool: simplify defining tool names to their basename Recently a bunch more got added following the original sed style. The whole thing is incredibly wasteful and difficult to read, however. - type -P xxx will always return ${path}/xxx or nothing, which includes failing to fork in low-memory conditions, catastrophically failing the build, but NOT running "die" - basename ${path}/xxx will always return "xxx" We can simply write xxx directly. This is a confusing 2016 hack that doesn't need to be continued. Bug: https://bugs.gentoo.org/574550 Signed-off-by: Eli Schwartz gmail.com> Signed-off-by: Sam James gentoo.org> dev-build/libtool/libtool-2.4.7-r4.ebuild | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dev-build/libtool/libtool-2.4.7-r4.ebuild b/dev-build/libtool/libtool-2.4.7-r4.ebuild index d165475452d8..73de49e5d15f 100644 --- a/dev-build/libtool/libtool-2.4.7-r4.ebuild +++ b/dev-build/libtool/libtool-2.4.7-r4.ebuild @@ -101,12 +101,12 @@ src_configure() { # Do not bother hardcoding the full path to sed. # Just rely on $PATH. bug #574550 export CONFIG_SHELL="${EPREFIX}"/bin/bash - export ac_cv_path_SED="$(basename "$(type -P sed)")" - export ac_cv_path_EGREP="$(basename "$(type -P grep)") -E" - export ac_cv_path_EGREP_TRADITIONAL="$(basename "$(type -P grep)") -E" - export ac_cv_path_FGREP="$(basename "$(type -P grep)") -F" - export ac_cv_path_GREP="$(basename "$(type -P grep)")" - export ac_cv_path_lt_DD="$(basename "$(type -P dd)")" + export ac_cv_path_SED="sed" + export ac_cv_path_EGREP="grep -E" + export ac_cv_path_EGREP_TRADITIONAL="grep -E" + export ac_cv_path_FGREP="grep -F" + export ac_cv_path_GREP="grep" + export ac_cv_path_lt_DD="dd" [[ ${CHOST} == *-darwin* ]] && local myconf="--program-prefix=g"