[gentoo-commits] repo/gentoo:master commit in: media-sound/audacity/

["Sam James" <sam@gentoo.org>]

commit:     54238035c9abd9b278e2fd14312e893922c3be5f
Author:     Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Tue Mar  5 00:49:58 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Mar  5 04:47:49 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54238035

media-sound/audacity: mark as LTO-unsafe, strict-aliasing unsafe

Bug report says ODR violations, but I could not reproduce since I hit
strict-aliasing issues first. I'm assuming both are an issue, but on the
other hand either one is a good reason to turn off LTO.

Closes: https://bugs.gentoo.org/915226
Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 media-sound/audacity/audacity-3.3.3.ebuild | 9 ++++++++-
 media-sound/audacity/audacity-9999.ebuild  | 9 ++++++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/media-sound/audacity/audacity-3.3.3.ebuild b/media-sound/audacity/audacity-3.3.3.ebuild
index a839024bcc60..2cba5da71a87 100644
--- a/media-sound/audacity/audacity-3.3.3.ebuild
+++ b/media-sound/audacity/audacity-3.3.3.ebuild
@@ -5,7 +5,7 @@ EAPI=8
 
 WX_GTK_VER="3.2-gtk3"
 
-inherit cmake wxwidgets xdg virtualx
+inherit cmake flag-o-matic wxwidgets xdg virtualx
 
 DESCRIPTION="Free crossplatform audio editor"
 HOMEPAGE="https://www.audacityteam.org/"
@@ -157,6 +157,13 @@ src_prepare() {
 }
 
 src_configure() {
+	# -Werror=strict-aliasing
+	# Reportedly also -Werror=odr but I could not get that far.
+	# https://bugs.gentoo.org/915226
+	# https://github.com/audacity/audacity/issues/6096
+	append-flags -fno-strict-aliasing
+	filter-lto
+
 	setup-wxwidgets
 
 	# * always use system libraries if possible

diff --git a/media-sound/audacity/audacity-9999.ebuild b/media-sound/audacity/audacity-9999.ebuild
index f00f0a9e1f66..be537c7c96c0 100644
--- a/media-sound/audacity/audacity-9999.ebuild
+++ b/media-sound/audacity/audacity-9999.ebuild
@@ -5,7 +5,7 @@ EAPI=8
 
 WX_GTK_VER="3.2-gtk3"
 
-inherit cmake wxwidgets xdg virtualx
+inherit cmake flag-o-matic wxwidgets xdg virtualx
 
 DESCRIPTION="Free crossplatform audio editor"
 HOMEPAGE="https://www.audacityteam.org/"
@@ -144,6 +144,13 @@ src_prepare() {
 }
 
 src_configure() {
+	# -Werror=strict-aliasing
+	# Reportedly also -Werror=odr but I could not get that far.
+	# https://bugs.gentoo.org/915226
+	# https://github.com/audacity/audacity/issues/6096
+	append-flags -fno-strict-aliasing
+	filter-lto
+
 	setup-wxwidgets
 
 	# * always use system libraries if possible