From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1D43F158041 for ; Wed, 28 Feb 2024 22:57:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 230E0E2A33; Wed, 28 Feb 2024 22:57:19 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 01EC8E2A2F for ; Wed, 28 Feb 2024 22:57:18 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 17F6D34306B for ; Wed, 28 Feb 2024 22:57:18 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 7295614E1 for ; Wed, 28 Feb 2024 22:57:16 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1709161021.aec66421746a0ac2dc2b2eebed6e0f0d2abe3405.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: media-libs/plib/ X-VCS-Repository: repo/gentoo X-VCS-Files: media-libs/plib/plib-1.8.5-r4.ebuild X-VCS-Directories: media-libs/plib/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: aec66421746a0ac2dc2b2eebed6e0f0d2abe3405 X-VCS-Branch: master Date: Wed, 28 Feb 2024 22:57:16 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 36a4f247-6794-48ee-ad0c-ec96129c2aef X-Archives-Hash: 1170c51e3d1cadaadbb93cb3af610fc9 commit: aec66421746a0ac2dc2b2eebed6e0f0d2abe3405 Author: Eli Schwartz gmail com> AuthorDate: Wed Feb 28 22:30:22 2024 +0000 Commit: Sam James gentoo org> CommitDate: Wed Feb 28 22:57:01 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aec66421 media-libs/plib: mark LTO-unsafe, mark strict-aliasing unsafe This code is formally terrible. It is so terrible, because upstream claims: "PLIB has been obsolete and unmaintained for at LEAST 15 years!!" https://sourceforge.net/p/plib/bugs/55/#88e9 And that was already 3 years ago. We can't fix it so limit the extent to which compilers are allowed to misinterpret it. Closes: https://bugs.gentoo.org/860048 Signed-off-by: Eli Schwartz gmail.com> Signed-off-by: Sam James gentoo.org> media-libs/plib/plib-1.8.5-r4.ebuild | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/media-libs/plib/plib-1.8.5-r4.ebuild b/media-libs/plib/plib-1.8.5-r4.ebuild index 3e4494514020..b5769bd1ab11 100644 --- a/media-libs/plib/plib-1.8.5-r4.ebuild +++ b/media-libs/plib/plib-1.8.5-r4.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2023 Gentoo Authors +# Copyright 1999-2024 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 EAPI=8 @@ -32,6 +32,12 @@ src_prepare() { src_configure() { append-cxxflags -std=c++03 + # violates strict aliasing rules and is LTO-unsafe: https://bugs.gentoo.org/860048 + # Per upstream in 2021, "PLIB has been obsolete and unmaintained for at LEAST 15 years!!" + # so this is getting fixed exactly never and getting worse. + append-cxxflags -fno-strict-aliasing + filter-lto + local myconf=( --enable-shared )