* [gentoo-commits] repo/proj/guru:master commit in: dev-libs/gbinder/, dev-libs/gbinder/files/
@ 2022-12-20 17:23 Haelwenn Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Haelwenn Monnier @ 2022-12-20 17:23 UTC (permalink / raw
To: gentoo-commits
commit: 26ec25c8258ca7ab45c9421770d75fc156096d15
Author: Denis Reva <denis7774 <AT> gmail <DOT> com>
AuthorDate: Tue Dec 20 11:07:43 2022 +0000
Commit: Haelwenn Monnier <contact <AT> hacktivis <DOT> me>
CommitDate: Tue Dec 20 11:07:43 2022 +0000
URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=26ec25c8
dev-libs/gbinder: bug fixes for gbinder: fixed ranlib, debug and user optimisations, fixed tests
Closes: https://bugs.gentoo.org/843899
Closes: https://bugs.gentoo.org/843902
Closes: https://bugs.gentoo.org/887297
Closes: https://bugs.gentoo.org/859736
Closes: https://bugs.gentoo.org/887299
Signed-off-by: Denis Reva <denis7774 <AT> gmail.com>
.../gbinder/files/gbinder-1.1.30-respect-env.patch | 49 ++++++++++++++++++++++
...r-1.1.30-r1.ebuild => gbinder-1.1.30-r2.ebuild} | 24 +++++++++--
2 files changed, 70 insertions(+), 3 deletions(-)
diff --git a/dev-libs/gbinder/files/gbinder-1.1.30-respect-env.patch b/dev-libs/gbinder/files/gbinder-1.1.30-respect-env.patch
new file mode 100644
index 000000000..62358758b
--- /dev/null
+++ b/dev-libs/gbinder/files/gbinder-1.1.30-respect-env.patch
@@ -0,0 +1,49 @@
+diff --git a/Makefile b/Makefile
+index e838b7e..adb886f 100644
+--- a/Makefile
++++ b/Makefile
+@@ -140,15 +140,15 @@ DEBUG_FLAGS = -g
+ RELEASE_FLAGS =
+ COVERAGE_FLAGS = -g
+
+-KEEP_SYMBOLS ?= 0
+-ifneq ($(KEEP_SYMBOLS),0)
+-RELEASE_FLAGS += -g
+-endif
++#KEEP_SYMBOLS ?= 0
++#ifneq ($(KEEP_SYMBOLS),0)
++#RELEASE_FLAGS += -g
++#endif
+
+ DEBUG_LDFLAGS = $(FULL_LDFLAGS) $(DEBUG_LIBS) $(DEBUG_FLAGS)
+ RELEASE_LDFLAGS = $(FULL_LDFLAGS) $(RELEASE_LIBS) $(RELEASE_FLAGS)
+ DEBUG_CFLAGS = $(FULL_CFLAGS) $(DEBUG_FLAGS) -DDEBUG
+-RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS) -O2
++RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS)
+ COVERAGE_CFLAGS = $(FULL_CFLAGS) $(COVERAGE_FLAGS) --coverage
+
+ #
+@@ -274,17 +274,17 @@ $(DEBUG_SO): $(DEBUG_OBJS)
+
+ $(RELEASE_SO): $(RELEASE_OBJS)
+ $(LD) $(RELEASE_OBJS) $(RELEASE_LDFLAGS) -o $@
+-ifeq ($(KEEP_SYMBOLS),0)
+- $(STRIP) $@
+-endif
++#ifeq ($(KEEP_SYMBOLS),0)
++# $(STRIP) $@
++#endif
+
+ $(DEBUG_LIB): $(DEBUG_OBJS)
+ $(AR) rc $@ $?
+ ranlib $@
+
+-$(RELEASE_LIB): $(RELEASE_OBJS)
+- $(AR) rc $@ $?
+- ranlib $@
++$(RELEASE_LIB): $(RELEASE_OBJS)
++ $(AR) rc $@ $?
++ ranlib $@
+
+ $(DEBUG_LINK):
+ ln -sf $(LIB_SO) $@
diff --git a/dev-libs/gbinder/gbinder-1.1.30-r1.ebuild b/dev-libs/gbinder/gbinder-1.1.30-r2.ebuild
similarity index 64%
rename from dev-libs/gbinder/gbinder-1.1.30-r1.ebuild
rename to dev-libs/gbinder/gbinder-1.1.30-r2.ebuild
index 8caa9ed80..cd97f3663 100644
--- a/dev-libs/gbinder/gbinder-1.1.30-r1.ebuild
+++ b/dev-libs/gbinder/gbinder-1.1.30-r2.ebuild
@@ -3,6 +3,8 @@
EAPI=8
+inherit toolchain-funcs
+
if [[ ${PV} == 9999 ]]; then
inherit git-r3
EGIT_REPO_URI="https://github.com/mer-hybris/libgbinder.git"
@@ -18,15 +20,31 @@ DESCRIPTION="GLib-style interface to binder"
HOMEPAGE="https://github.com/mer-hybris/libgbinder"
LICENSE="BSD"
SLOT="0"
+IUSE=""
DEPEND="dev-libs/libglibutil"
RDEPEND="${DEPEND}"
-BDEPEND="virtual/pkgconfig"
+BDEPEND="virtual/pkgconfig
+ sys-apps/sed"
+
+PATCHES=(
+ "${FILESDIR}/gbinder-1.1.30-respect-env.patch"
+)
+src_prepare() {
+ default
+ sed -i -e "s|ranlib|$(tc-getRANLIB)|" \
+ Makefile \
+ || die
+}
src_compile() {
- emake KEEP_SYMBOLS=1 ABS_LIBDIR="/usr/$(get_libdir)" LIBDIR="/usr/$(get_libdir)"
+ emake LIBDIR="/usr/$(get_libdir)"
}
src_install() {
- emake DESTDIR="${D}" ABS_LIBDIR="/usr/$(get_libdir)" LIBDIR="/usr/$(get_libdir)" install-dev
+ emake DESTDIR="${D}" LIBDIR="/usr/$(get_libdir)" install-dev
+}
+
+src_test() {
+ emake test
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [gentoo-commits] repo/proj/guru:master commit in: dev-libs/gbinder/, dev-libs/gbinder/files/
@ 2024-02-19 22:00 Julien Roy
0 siblings, 0 replies; 3+ messages in thread
From: Julien Roy @ 2024-02-19 22:00 UTC (permalink / raw
To: gentoo-commits
commit: e509d3d4c37d7e83db42ad2a99e2894b3748706f
Author: Denis Reva <denis7774 <AT> gmail <DOT> com>
AuthorDate: Mon Feb 19 13:44:03 2024 +0000
Commit: Julien Roy <julien <AT> jroy <DOT> ca>
CommitDate: Mon Feb 19 13:44:03 2024 +0000
URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=e509d3d4
dev-libs/gbinder: add 1.1.36, updated 9999
Signed-off-by: Denis Reva <denis7774 <AT> gmail.com>
dev-libs/gbinder/Manifest | 1 +
.../gbinder/files/gbinder-1.1.36-respect-env.patch | 40 ++++++++++++++++++++++
.../{gbinder-9999.ebuild => gbinder-1.1.36.ebuild} | 2 +-
dev-libs/gbinder/gbinder-9999.ebuild | 2 +-
4 files changed, 43 insertions(+), 2 deletions(-)
diff --git a/dev-libs/gbinder/Manifest b/dev-libs/gbinder/Manifest
index dc65cca8b7..54ba7b09ab 100644
--- a/dev-libs/gbinder/Manifest
+++ b/dev-libs/gbinder/Manifest
@@ -1,2 +1,3 @@
DIST gbinder-1.1.30.tar.gz 205795 BLAKE2B a61b720a3d2b9fe79a4754c2e58569d05d8a16bd5dd35ac4e7616401b804604245e2b13a6ef12043737a00ce2f983bc01b408c5b2b68fe0db1b9c9e15b68ca84 SHA512 24e4e5156ab3f90dc2255b40ed6e74d0f14bce61879891179ae7291622b4179dd769749635f2811bc8a9f868257224385cf90ab43bd36a52e2f30e92ecb7ffd4
DIST gbinder-1.1.32.tar.gz 204284 BLAKE2B 8a4f62c0d4988a02b32b659ea0f959e465ead1ea962504f7ae1aa36687235e522deeba3dc7206e32bb1d7c292de760266d8bb18a85da29df06affe49cd59c95f SHA512 3e4fbfbda627b189faf3eee183548cd4cda8a8b1b94b9f8d03572f1d3bc6fe13907f19104f28e5609f266d4c05c4bdb54c1c5ffbc6c537c9774d1def1d4cb09b
+DIST gbinder-1.1.36.tar.gz 204122 BLAKE2B f48fff65f2cf9dd8674110edb77116a6ef5cd621e81d32aae8b3cbf3cb96e8bc825087dd834853c509c6e89c73cf5a24b21c0e5443dfe13747ce1125523d7d30 SHA512 5727b25299286e8238a9b526fec9f72d631f584cabb21021d9f12e550059fe746e1165d5bb47ba79db52e2ccb5a3ce96dbd97761df78f13cf7e9a1554d1c3876
diff --git a/dev-libs/gbinder/files/gbinder-1.1.36-respect-env.patch b/dev-libs/gbinder/files/gbinder-1.1.36-respect-env.patch
new file mode 100644
index 0000000000..747683164b
--- /dev/null
+++ b/dev-libs/gbinder/files/gbinder-1.1.36-respect-env.patch
@@ -0,0 +1,40 @@
+diff --git a/Makefile b/Makefile
+index 0e25e90..862d5df 100644
+--- a/Makefile
++++ b/Makefile
+@@ -139,20 +139,20 @@ FULL_CFLAGS = $(BASE_FLAGS) $(CFLAGS) $(DEFINES) $(WARNINGS) $(INCLUDES) \
+ -MMD -MP $(shell $(PKG_CONFIG) --cflags $(PKGS))
+ FULL_LDFLAGS = $(BASE_FLAGS) $(LDFLAGS) -shared -Wl,-soname,$(LIB_SONAME) \
+ $(shell $(PKG_CONFIG) --libs $(PKGS)) -lpthread
+-DEBUG_FLAGS = -g
++DEBUG_FLAGS =
+ RELEASE_FLAGS =
+-COVERAGE_FLAGS = -g
++COVERAGE_FLAGS =
+
+ KEEP_SYMBOLS ?= 0
+ ifneq ($(KEEP_SYMBOLS),0)
+-RELEASE_FLAGS += -g
++RELEASE_FLAGS +=
+ endif
+
+ DEBUG_LDFLAGS = $(FULL_LDFLAGS) $(DEBUG_LIBS) $(DEBUG_FLAGS)
+ RELEASE_LDFLAGS = $(FULL_LDFLAGS) $(RELEASE_LIBS) $(RELEASE_FLAGS)
+-DEBUG_CFLAGS = $(FULL_CFLAGS) $(DEBUG_FLAGS) -DDEBUG
+-RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS) -O2
+-COVERAGE_CFLAGS = $(FULL_CFLAGS) $(COVERAGE_FLAGS) --coverage
++DEBUG_CFLAGS = $(FULL_CFLAGS) $(DEBUG_FLAGS)
++RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS)
++COVERAGE_CFLAGS = $(FULL_CFLAGS) $(COVERAGE_FLAGS)
+
+ #
+ # Files
+@@ -278,7 +278,7 @@ $(DEBUG_SO): $(DEBUG_OBJS)
+ $(RELEASE_SO): $(RELEASE_OBJS)
+ $(LD) $(RELEASE_OBJS) $(RELEASE_LDFLAGS) -o $@
+ ifeq ($(KEEP_SYMBOLS),0)
+- $(STRIP) $@
++# $(STRIP) $@
+ endif
+
+ $(DEBUG_LIB): $(DEBUG_OBJS)
diff --git a/dev-libs/gbinder/gbinder-9999.ebuild b/dev-libs/gbinder/gbinder-1.1.36.ebuild
similarity index 94%
copy from dev-libs/gbinder/gbinder-9999.ebuild
copy to dev-libs/gbinder/gbinder-1.1.36.ebuild
index c900ed13fc..66491f86d0 100644
--- a/dev-libs/gbinder/gbinder-9999.ebuild
+++ b/dev-libs/gbinder/gbinder-1.1.36.ebuild
@@ -28,7 +28,7 @@ BDEPEND="virtual/pkgconfig
sys-apps/sed"
PATCHES=(
- "${FILESDIR}/gbinder-1.1.30-r3-respect-env.patch"
+ "${FILESDIR}/gbinder-1.1.36-respect-env.patch"
)
src_prepare() {
default
diff --git a/dev-libs/gbinder/gbinder-9999.ebuild b/dev-libs/gbinder/gbinder-9999.ebuild
index c900ed13fc..66491f86d0 100644
--- a/dev-libs/gbinder/gbinder-9999.ebuild
+++ b/dev-libs/gbinder/gbinder-9999.ebuild
@@ -28,7 +28,7 @@ BDEPEND="virtual/pkgconfig
sys-apps/sed"
PATCHES=(
- "${FILESDIR}/gbinder-1.1.30-r3-respect-env.patch"
+ "${FILESDIR}/gbinder-1.1.36-respect-env.patch"
)
src_prepare() {
default
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [gentoo-commits] repo/proj/guru:master commit in: dev-libs/gbinder/, dev-libs/gbinder/files/
@ 2025-01-11 14:36 Julien Roy
0 siblings, 0 replies; 3+ messages in thread
From: Julien Roy @ 2025-01-11 14:36 UTC (permalink / raw
To: gentoo-commits
commit: 79713fd5fb94135acd5f95922c95134e890c7238
Author: Denis Reva <denis7774 <AT> gmail <DOT> com>
AuthorDate: Sat Jan 11 12:51:47 2025 +0000
Commit: Julien Roy <julien <AT> jroy <DOT> ca>
CommitDate: Sat Jan 11 12:51:58 2025 +0000
URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=79713fd5
dev-libs/gbinder: add 1.1.42, drop 1.1.41
Closes: https://bugs.gentoo.org/944771
Signed-off-by: Denis Reva <denis7774 <AT> gmail.com>
dev-libs/gbinder/Manifest | 2 +-
.../files/gbinder-1.1.30-r3-respect-env.patch | 40 ------------------
.../gbinder/files/gbinder-1.1.30-respect-env.patch | 49 ----------------------
.../gbinder/files/gbinder-1.1.42-C23-compat.patch | 24 +++++++++++
...gbinder-1.1.41.ebuild => gbinder-1.1.42.ebuild} | 1 +
5 files changed, 26 insertions(+), 90 deletions(-)
diff --git a/dev-libs/gbinder/Manifest b/dev-libs/gbinder/Manifest
index 02628c71e..f3d0a1075 100644
--- a/dev-libs/gbinder/Manifest
+++ b/dev-libs/gbinder/Manifest
@@ -1 +1 @@
-DIST gbinder-1.1.41.tar.gz 206398 BLAKE2B 47f841f00a4f1e5730adf7e31b8bc09d029235048315458fd0eed3ca437f29f6a02bc4a6921d6378bb8c16ae97a6e85bcdf68253504f37ad4e8e0921869f18d1 SHA512 f2131a08ba4498b72ad39f1844cd415e182cce394bc5834c1ae188928700188ded7b0d826a74ea7e261cfb0ebb773f829c6eb017d6bef606f3f2837559bb9277
+DIST gbinder-1.1.42.tar.gz 207656 BLAKE2B 5f278490720f9b95f94a63d718d30e7a61c53ba4f943e676b7d76899660da91603a37953c764e1810eaea088de29f50e07ae8cb90cfbd17bd6a5db03bdffc314 SHA512 4d229e957188064817d6b40f693cf6fe9b44efae34ad15ac4314c7f0e3c49dc17835984fa741f7b90d8a2016234f2e7e78cc56f73625156e2aedab73faa93553
diff --git a/dev-libs/gbinder/files/gbinder-1.1.30-r3-respect-env.patch b/dev-libs/gbinder/files/gbinder-1.1.30-r3-respect-env.patch
deleted file mode 100644
index 5f9d974f9..000000000
--- a/dev-libs/gbinder/files/gbinder-1.1.30-r3-respect-env.patch
+++ /dev/null
@@ -1,40 +0,0 @@
-diff --git a/Makefile b/Makefile
-index e838b7e..4ce2039 100644
---- a/Makefile
-+++ b/Makefile
-@@ -136,20 +136,20 @@ FULL_CFLAGS = $(BASE_FLAGS) $(CFLAGS) $(DEFINES) $(WARNINGS) $(INCLUDES) \
- -MMD -MP $(shell pkg-config --cflags $(PKGS))
- FULL_LDFLAGS = $(BASE_FLAGS) $(LDFLAGS) -shared -Wl,-soname,$(LIB_SONAME) \
- $(shell pkg-config --libs $(PKGS)) -lpthread
--DEBUG_FLAGS = -g
-+DEBUG_FLAGS =
- RELEASE_FLAGS =
--COVERAGE_FLAGS = -g
-+COVERAGE_FLAGS =
-
- KEEP_SYMBOLS ?= 0
- ifneq ($(KEEP_SYMBOLS),0)
--RELEASE_FLAGS += -g
-+#RELEASE_FLAGS += -g
- endif
-
- DEBUG_LDFLAGS = $(FULL_LDFLAGS) $(DEBUG_LIBS) $(DEBUG_FLAGS)
- RELEASE_LDFLAGS = $(FULL_LDFLAGS) $(RELEASE_LIBS) $(RELEASE_FLAGS)
--DEBUG_CFLAGS = $(FULL_CFLAGS) $(DEBUG_FLAGS) -DDEBUG
--RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS) -O2
--COVERAGE_CFLAGS = $(FULL_CFLAGS) $(COVERAGE_FLAGS) --coverage
-+DEBUG_CFLAGS = $(FULL_CFLAGS) $(DEBUG_FLAGS)
-+RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS)
-+COVERAGE_CFLAGS = $(FULL_CFLAGS) $(COVERAGE_FLAGS)
-
- #
- # Files
-@@ -275,7 +275,7 @@ $(DEBUG_SO): $(DEBUG_OBJS)
- $(RELEASE_SO): $(RELEASE_OBJS)
- $(LD) $(RELEASE_OBJS) $(RELEASE_LDFLAGS) -o $@
- ifeq ($(KEEP_SYMBOLS),0)
-- $(STRIP) $@
-+# $(STRIP) $@
- endif
-
- $(DEBUG_LIB): $(DEBUG_OBJS)
diff --git a/dev-libs/gbinder/files/gbinder-1.1.30-respect-env.patch b/dev-libs/gbinder/files/gbinder-1.1.30-respect-env.patch
deleted file mode 100644
index 62358758b..000000000
--- a/dev-libs/gbinder/files/gbinder-1.1.30-respect-env.patch
+++ /dev/null
@@ -1,49 +0,0 @@
-diff --git a/Makefile b/Makefile
-index e838b7e..adb886f 100644
---- a/Makefile
-+++ b/Makefile
-@@ -140,15 +140,15 @@ DEBUG_FLAGS = -g
- RELEASE_FLAGS =
- COVERAGE_FLAGS = -g
-
--KEEP_SYMBOLS ?= 0
--ifneq ($(KEEP_SYMBOLS),0)
--RELEASE_FLAGS += -g
--endif
-+#KEEP_SYMBOLS ?= 0
-+#ifneq ($(KEEP_SYMBOLS),0)
-+#RELEASE_FLAGS += -g
-+#endif
-
- DEBUG_LDFLAGS = $(FULL_LDFLAGS) $(DEBUG_LIBS) $(DEBUG_FLAGS)
- RELEASE_LDFLAGS = $(FULL_LDFLAGS) $(RELEASE_LIBS) $(RELEASE_FLAGS)
- DEBUG_CFLAGS = $(FULL_CFLAGS) $(DEBUG_FLAGS) -DDEBUG
--RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS) -O2
-+RELEASE_CFLAGS = $(FULL_CFLAGS) $(RELEASE_FLAGS)
- COVERAGE_CFLAGS = $(FULL_CFLAGS) $(COVERAGE_FLAGS) --coverage
-
- #
-@@ -274,17 +274,17 @@ $(DEBUG_SO): $(DEBUG_OBJS)
-
- $(RELEASE_SO): $(RELEASE_OBJS)
- $(LD) $(RELEASE_OBJS) $(RELEASE_LDFLAGS) -o $@
--ifeq ($(KEEP_SYMBOLS),0)
-- $(STRIP) $@
--endif
-+#ifeq ($(KEEP_SYMBOLS),0)
-+# $(STRIP) $@
-+#endif
-
- $(DEBUG_LIB): $(DEBUG_OBJS)
- $(AR) rc $@ $?
- ranlib $@
-
--$(RELEASE_LIB): $(RELEASE_OBJS)
-- $(AR) rc $@ $?
-- ranlib $@
-+$(RELEASE_LIB): $(RELEASE_OBJS)
-+ $(AR) rc $@ $?
-+ ranlib $@
-
- $(DEBUG_LINK):
- ln -sf $(LIB_SO) $@
diff --git a/dev-libs/gbinder/files/gbinder-1.1.42-C23-compat.patch b/dev-libs/gbinder/files/gbinder-1.1.42-C23-compat.patch
new file mode 100644
index 000000000..8da1e882e
--- /dev/null
+++ b/dev-libs/gbinder/files/gbinder-1.1.42-C23-compat.patch
@@ -0,0 +1,24 @@
+From 46d9899f5a512d0e9b851cb55b06a27fc2b7a638 Mon Sep 17 00:00:00 2001
+From: Takuya Wakazono <pastalian46@gmail.com>
+Date: Wed, 1 Jan 2025 21:03:48 +0900
+Subject: [PATCH] Explicitly declare function parameters for C23 compatibility
+
+In C23, void foo() is equivalent to void foo(void). Therefore, functions
+must explicitly declare their parameters.
+---
+ src/gbinder_writer.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/gbinder_writer.c b/src/gbinder_writer.c
+index 1e93700..7308818 100644
+--- a/src/gbinder_writer.c
++++ b/src/gbinder_writer.c
+@@ -1324,7 +1324,7 @@ gbinder_writer_alloc(
+ GBinderWriter* self,
+ gsize size,
+ gpointer (*alloc)(gsize),
+- void (*dealloc)())
++ void (*dealloc)(gpointer))
+ {
+ GBinderWriterData* data = gbinder_writer_data(self);
+
diff --git a/dev-libs/gbinder/gbinder-1.1.41.ebuild b/dev-libs/gbinder/gbinder-1.1.42.ebuild
similarity index 95%
rename from dev-libs/gbinder/gbinder-1.1.41.ebuild
rename to dev-libs/gbinder/gbinder-1.1.42.ebuild
index 45bba5264..0c032fae7 100644
--- a/dev-libs/gbinder/gbinder-1.1.41.ebuild
+++ b/dev-libs/gbinder/gbinder-1.1.42.ebuild
@@ -31,6 +31,7 @@ BDEPEND="
PATCHES=(
"${FILESDIR}/gbinder-1.1.36-respect-env.patch"
+ "${FILESDIR}/gbinder-1.1.42-C23-compat.patch"
)
src_prepare() {
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-11 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-19 22:00 [gentoo-commits] repo/proj/guru:master commit in: dev-libs/gbinder/, dev-libs/gbinder/files/ Julien Roy
-- strict thread matches above, loose matches on Subject: below --
2025-01-11 14:36 Julien Roy
2022-12-20 17:23 Haelwenn Monnier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox