public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ionen Wolkens" <ionen@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: x11-drivers/nvidia-drivers/files/, x11-drivers/nvidia-drivers/
Date: Mon,  8 Jan 2024 21:09:41 +0000 (UTC)	[thread overview]
Message-ID: <1704748086.0cb6966bc9c75c16bf3a1fb7e36e28ce1e1a453a.ionen@gentoo> (raw)

commit:     0cb6966bc9c75c16bf3a1fb7e36e28ce1e1a453a
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Mon Jan  8 20:50:15 2024 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Mon Jan  8 21:08:06 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0cb6966b

x11-drivers/nvidia-drivers: fix with linux-6.7 and some configs

Looked fine for me but turns out the issue is conditional to kernel
configs and it was not enabling USE_LKCA with mines. Also needed
USE=kernel-open to run into this.

An NVIDIA representative has offered a fix, so may as well use it
this time around.

525 and older branches did not use this function.

Should be harmless for older kernels, but have not really tested
so only applying if >6.7 as a precaution, esp. for stable 535.

Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 .../nvidia-drivers-535.43.22-kernel-6.7.patch      | 24 ++++++++++++++++++++++
 .../nvidia-drivers-535.146.02.ebuild               |  3 +++
 .../nvidia-drivers/nvidia-drivers-535.43.22.ebuild |  3 +++
 .../nvidia-drivers-545.29.06-r1.ebuild             |  3 +++
 4 files changed, 33 insertions(+)

diff --git a/x11-drivers/nvidia-drivers/files/nvidia-drivers-535.43.22-kernel-6.7.patch b/x11-drivers/nvidia-drivers/files/nvidia-drivers-535.43.22-kernel-6.7.patch
new file mode 100644
index 000000000000..08833de8344a
--- /dev/null
+++ b/x11-drivers/nvidia-drivers/files/nvidia-drivers-535.43.22-kernel-6.7.patch
@@ -0,0 +1,24 @@
+Typically opt not to patch for kernel support downstream, but in this
+case it's only conditionally broken depending on kernel crypto configs
+and USE=kernel-open, then an (official) NVIDIA representative has
+responded with a fix in [1] which should be safe.
+
+[1] https://github.com/NVIDIA/open-gpu-kernel-modules/issues/574#issuecomment-1809283181
+--- a/kernel/nvidia/libspdm_shash.c
++++ b/kernel/nvidia/libspdm_shash.c
+@@ -89,4 +89,4 @@
+         struct crypto_shash *dst_tfm = dst->tfm;
+-        char *src_ipad = crypto_tfm_ctx_aligned(&src_tfm->base);
+-        char *dst_ipad = crypto_tfm_ctx_aligned(&dst_tfm->base);
++        char *src_ipad = crypto_tfm_ctx_align(&src_tfm->base, crypto_tfm_alg_alignmask(&src_tfm->base) + 1);
++        char *dst_ipad = crypto_tfm_ctx_align(&dst_tfm->base, crypto_tfm_alg_alignmask(&dst_tfm->base) + 1);
+         int ss = crypto_shash_statesize(dst_tfm);
+--- a/kernel-module-source/kernel-open/nvidia/libspdm_shash.c
++++ b/kernel-module-source/kernel-open/nvidia/libspdm_shash.c
+@@ -89,4 +89,4 @@
+         struct crypto_shash *dst_tfm = dst->tfm;
+-        char *src_ipad = crypto_tfm_ctx_aligned(&src_tfm->base);
+-        char *dst_ipad = crypto_tfm_ctx_aligned(&dst_tfm->base);
++        char *src_ipad = crypto_tfm_ctx_align(&src_tfm->base, crypto_tfm_alg_alignmask(&src_tfm->base) + 1);
++        char *dst_ipad = crypto_tfm_ctx_align(&dst_tfm->base, crypto_tfm_alg_alignmask(&dst_tfm->base) + 1);
+         int ss = crypto_shash_statesize(dst_tfm);

diff --git a/x11-drivers/nvidia-drivers/nvidia-drivers-535.146.02.ebuild b/x11-drivers/nvidia-drivers/nvidia-drivers-535.146.02.ebuild
index 4e12ff078da1..8bc1465f4494 100644
--- a/x11-drivers/nvidia-drivers/nvidia-drivers-535.146.02.ebuild
+++ b/x11-drivers/nvidia-drivers/nvidia-drivers-535.146.02.ebuild
@@ -137,6 +137,9 @@ src_prepare() {
 
 	default
 
+	kernel_is -ge 6 7 &&
+		eapply "${FILESDIR}"/nvidia-drivers-535.43.22-kernel-6.7.patch
+
 	# prevent detection of incomplete kernel DRM support (bug #603818)
 	sed 's/defined(CONFIG_DRM/defined(CONFIG_DRM_KMS_HELPER/g' \
 		-i kernel{,-module-source/kernel-open}/conftest.sh || die

diff --git a/x11-drivers/nvidia-drivers/nvidia-drivers-535.43.22.ebuild b/x11-drivers/nvidia-drivers/nvidia-drivers-535.43.22.ebuild
index ae62cbc6f0ea..4932e930c654 100644
--- a/x11-drivers/nvidia-drivers/nvidia-drivers-535.43.22.ebuild
+++ b/x11-drivers/nvidia-drivers/nvidia-drivers-535.43.22.ebuild
@@ -140,6 +140,9 @@ src_prepare() {
 
 	default
 
+	kernel_is -ge 6 7 &&
+		eapply "${FILESDIR}"/nvidia-drivers-535.43.22-kernel-6.7.patch
+
 	# prevent detection of incomplete kernel DRM support (bug #603818)
 	sed 's/defined(CONFIG_DRM/defined(CONFIG_DRM_KMS_HELPER/g' \
 		-i kernel{,-module-source/kernel-open}/conftest.sh || die

diff --git a/x11-drivers/nvidia-drivers/nvidia-drivers-545.29.06-r1.ebuild b/x11-drivers/nvidia-drivers/nvidia-drivers-545.29.06-r1.ebuild
index bf4959d91524..e74a99ad11e1 100644
--- a/x11-drivers/nvidia-drivers/nvidia-drivers-545.29.06-r1.ebuild
+++ b/x11-drivers/nvidia-drivers/nvidia-drivers-545.29.06-r1.ebuild
@@ -134,6 +134,9 @@ src_prepare() {
 
 	default
 
+	kernel_is -ge 6 7 &&
+		eapply "${FILESDIR}"/nvidia-drivers-535.43.22-kernel-6.7.patch
+
 	# prevent detection of incomplete kernel DRM support (bug #603818)
 	sed 's/defined(CONFIG_DRM/defined(CONFIG_DRM_KMS_HELPER/g' \
 		-i kernel{,-module-source/kernel-open}/conftest.sh || die


             reply	other threads:[~2024-01-08 21:09 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 21:09 Ionen Wolkens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-28 22:31 [gentoo-commits] repo/gentoo:master commit in: x11-drivers/nvidia-drivers/files/, x11-drivers/nvidia-drivers/ Ionen Wolkens
2025-01-30 16:33 Ionen Wolkens
2024-11-18  9:06 Ionen Wolkens
2024-10-23 20:25 Ionen Wolkens
2024-09-18 22:43 Ionen Wolkens
2024-06-26  0:16 Ionen Wolkens
2024-01-28 16:34 Ionen Wolkens
2023-10-17 17:52 Ionen Wolkens
2023-02-03 18:15 Ionen Wolkens
2022-12-11 19:12 Ionen Wolkens
2022-11-10 22:22 Ionen Wolkens
2022-09-27 23:46 Ionen Wolkens
2022-09-23  2:05 Ionen Wolkens
2022-09-19 11:36 Ionen Wolkens
2022-05-21  0:38 Ionen Wolkens
2021-12-14 15:56 Ionen Wolkens
2021-07-23 15:39 Ionen Wolkens
2021-07-22 15:08 Ionen Wolkens
2021-07-21 19:44 Ionen Wolkens
2021-07-21 19:44 Ionen Wolkens
2021-07-20  1:23 Ionen Wolkens
2021-04-21 12:22 David Seifert
2021-02-08  9:39 David Seifert
2020-08-26 16:55 Matt Turner
2020-08-26  5:32 Matt Turner
2020-04-29  8:08 Jeroen Roovers
2020-01-27 19:55 Jeroen Roovers
2019-10-22  9:17 Jeroen Roovers
2019-01-16 10:32 Jeroen Roovers
2018-01-04 19:08 Jeroen Roovers
2017-11-27 23:31 Jeroen Roovers
2017-11-27 23:31 Jeroen Roovers
2017-11-22  9:55 Jeroen Roovers
2017-09-27 16:26 Jeroen Roovers
2017-04-11  7:07 Jeroen Roovers
2017-01-09  3:38 Richard Farina
2016-12-15 10:31 Jeroen Roovers
2016-11-21 19:10 Jeroen Roovers
2016-10-25 19:44 Richard Farina
2016-10-11  7:22 Jeroen Roovers
2016-09-10 12:33 Jeroen Roovers
2016-09-10 12:33 Jeroen Roovers
2016-08-28  8:14 Jeroen Roovers
2016-03-25  3:30 Jeroen Roovers
2016-03-24  5:05 Jeroen Roovers
2015-09-20 21:29 Richard Farina
2015-09-18 18:24 Richard Farina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1704748086.0cb6966bc9c75c16bf3a1fb7e36e28ce1e1a453a.ionen@gentoo \
    --to=ionen@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox