From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7DD63158015 for ; Wed, 20 Dec 2023 14:04:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9806F2BC022; Wed, 20 Dec 2023 14:04:27 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7BC572BC022 for ; Wed, 20 Dec 2023 14:04:27 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 71E5A3408DD for ; Wed, 20 Dec 2023 14:04:26 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id D6F831441 for ; Wed, 20 Dec 2023 14:04:24 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1703081052.b39e1edca0ee73f29b5513ab30f00da14d1291bc.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/package/ebuild/ X-VCS-Repository: proj/portage X-VCS-Files: lib/portage/package/ebuild/doebuild.py X-VCS-Directories: lib/portage/package/ebuild/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: b39e1edca0ee73f29b5513ab30f00da14d1291bc X-VCS-Branch: master Date: Wed, 20 Dec 2023 14:04:24 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: d3126226-2870-4b4a-be2b-31899c2974b0 X-Archives-Hash: 2a9d12ad0951da3d92af4f87d14ce6e8 commit: b39e1edca0ee73f29b5513ab30f00da14d1291bc Author: Eli Schwartz gmail com> AuthorDate: Wed Dec 20 06:36:38 2023 +0000 Commit: Sam James gentoo org> CommitDate: Wed Dec 20 14:04:12 2023 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=b39e1edc ebuild: command not found QA: don't skip QA warnings that come from ./configure Down through the twisting trail of history, we find a 2008 bug report and commit 930bbbf31c10265b27825426f1eff6d7f17395e6, which disabled detecting "command not found" in ./configure scripts with the following rationale: > This is actually a false positive. I'll fix it to filter out the ones that are generated by configure scripts. As far as I can tell it wasn't a false positive though. Looking up the source code for that old project reveals no indication that it can misfire in "expected" ways. More generally, this obscures real issues in configure scripts -- why should configure scripts be special here? -- which have *zero* guarantee of resulting in failure. Anecdotally, they usually do not. Whatever the underlying issue is, it's *definitely* an upstream bug and *almost certainly* indicates that there may be situations where the project miscompiles against expectations. Bug: https://bugs.gentoo.org/245716 Signed-off-by: Eli Schwartz gmail.com> Closes: https://github.com/gentoo/portage/pull/1210 Signed-off-by: Sam James gentoo.org> lib/portage/package/ebuild/doebuild.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/portage/package/ebuild/doebuild.py b/lib/portage/package/ebuild/doebuild.py index e651f28d06..b10bbaf30d 100644 --- a/lib/portage/package/ebuild/doebuild.py +++ b/lib/portage/package/ebuild/doebuild.py @@ -2275,7 +2275,6 @@ def _check_build_log(mysettings, out=None): r"(.*): line (\d*): (.*): command not found$" ) dash_command_not_found_re = re.compile(r"(.*): (\d+): (.*): not found$") - command_not_found_exclude_re = re.compile(r"/configure: line ") helper_missing_file = [] helper_missing_file_re = re.compile(r"^!!! (do|new).*: .* does not exist$") @@ -2379,16 +2378,10 @@ def _check_build_log(mysettings, out=None): ): am_maintainer_mode.append(line.rstrip("\n")) - if ( - bash_command_not_found_re.match(line) is not None - and command_not_found_exclude_re.search(line) is None - ): + if bash_command_not_found_re.match(line) is not None: command_not_found.append(line.rstrip("\n")) - if ( - dash_command_not_found_re.match(line) is not None - and command_not_found_exclude_re.search(line) is None - ): + if dash_command_not_found_re.match(line) is not None: command_not_found.append(line.rstrip("\n")) if helper_missing_file_re.match(line) is not None: