From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C3919158015 for ; Mon, 18 Dec 2023 03:54:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 50D742BC029; Mon, 18 Dec 2023 03:54:14 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 396A82BC029 for ; Mon, 18 Dec 2023 03:54:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 8325A33CEF2 for ; Mon, 18 Dec 2023 03:54:13 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id ABBD914AB for ; Mon, 18 Dec 2023 03:54:10 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1702871604.fd6b80fed96eadee8e30f9d644f7a206143b1f7f.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-print/cups-browsed/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-print/cups-browsed/cups-browsed-2.0.0.ebuild X-VCS-Directories: net-print/cups-browsed/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: fd6b80fed96eadee8e30f9d644f7a206143b1f7f X-VCS-Branch: master Date: Mon, 18 Dec 2023 03:54:10 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 443dd409-f23a-44fc-90f2-b8a64d60c27a X-Archives-Hash: afea8a21ec0e8bc8cd3b7a31e356d35b commit: fd6b80fed96eadee8e30f9d644f7a206143b1f7f Author: Eli Schwartz gmail com> AuthorDate: Sun Nov 12 21:38:24 2023 +0000 Commit: Sam James gentoo org> CommitDate: Mon Dec 18 03:53:24 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd6b80fe net-print/cups-browsed: restrict tests The tests are newly created during the 2.x upgrade. They will hang forever if they cannot run properly. And running them properly has hit a wall. I'm not sure where to go on from here. Even getting this far means stepping outside of what portage can reasonably require. Avahi only runs as root, and doesn't seem to have a mocking mode, and even if it is running, the sandbox prevents src_test from seeing it. Signed-off-by: Eli Schwartz gmail.com> Signed-off-by: Sam James gentoo.org> net-print/cups-browsed/cups-browsed-2.0.0.ebuild | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/net-print/cups-browsed/cups-browsed-2.0.0.ebuild b/net-print/cups-browsed/cups-browsed-2.0.0.ebuild index 6baeb697f2cd..0232d57c8b51 100644 --- a/net-print/cups-browsed/cups-browsed-2.0.0.ebuild +++ b/net-print/cups-browsed/cups-browsed-2.0.0.ebuild @@ -29,6 +29,18 @@ BDEPEND=" virtual/pkgconfig " +# The tests are new since the split out of cups-filters. Actually running them +# seems to be challenging. You need: +# - cups tools that are USE-optional +# - running avahi-daemon (as root!) +# - disable portage's pid-sandbox, which interferes with avahi +# - ipptool still fails to connect to port 8xxx +# +# If anything fails, a `while true` loop fails to successfully launch and break +# out of the loop, leading to a hang. Until there's an obvious recipe for +# successfully running the tests, restrict it. +RESTRICT="test" + PATCHES=( "${FILESDIR}"/0001-cups-browsed.c-Fix-build-with-avahi-disabled-20.patch ) @@ -47,6 +59,13 @@ src_configure() { econf "${myeconfargs[@]}" } +src_test() { + # Requires avahi running. Hangs forever if not available. + avahi-daemon --check 2>/dev/null || die "no running avahi daemon found, cannot run tests" + + default +} + src_install() { default