public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/cdk/
Date: Wed,  6 Dec 2023 16:01:42 +0000 (UTC)	[thread overview]
Message-ID: <1701878458.3c6244c59141bcdd5144430a42b87ab90cea2f19.sam@gentoo> (raw)

commit:     3c6244c59141bcdd5144430a42b87ab90cea2f19
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Dec  6 15:59:05 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Dec  6 16:00:58 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c6244c5

dev-libs/cdk: build with --enable-const

I don't understand why, in the year 2023, this is optional or at the very least
not default-on, but whatever.

It turns out that Fedora and openSUSE at least, probably many others, are building
cdk with --enable-const which is why this only showed up on Gentoo. We do the same
--enable-const dance for ncurses so I suppose I should've known.

Enable it for parity given it should be fine to go in this direction anyway.

Bug: https://github.com/gphoto/gphoto2/issues/615
Closes: https://bugs.gentoo.org/919279
Signed-off-by: Sam James <sam <AT> gentoo.org>

 dev-libs/cdk/cdk-5.0.20230201-r1.ebuild | 63 +++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/dev-libs/cdk/cdk-5.0.20230201-r1.ebuild b/dev-libs/cdk/cdk-5.0.20230201-r1.ebuild
new file mode 100644
index 000000000000..3faa9c0c03f7
--- /dev/null
+++ b/dev-libs/cdk/cdk-5.0.20230201-r1.ebuild
@@ -0,0 +1,63 @@
+# Copyright 1999-2023 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=8
+
+MY_P="${PN}-$(ver_rs 2 -)"
+
+VERIFY_SIG_OPENPGP_KEY_PATH=/usr/share/openpgp-keys/thomasdickey.asc
+inherit verify-sig
+
+DESCRIPTION="A library of curses widgets"
+HOMEPAGE="https://dickey.his.com/cdk/cdk.html https://github.com/ThomasDickey/cdk-snapshots"
+SRC_URI="https://invisible-island.net/archives/${PN}/${MY_P}.tgz"
+SRC_URI+=" verify-sig? ( https://invisible-island.net/archives/${PN}/${MY_P}.tgz.asc )"
+S="${WORKDIR}"/${MY_P}
+
+LICENSE="MIT"
+SLOT="0/6" # subslot = soname version
+KEYWORDS="~alpha ~amd64 ~arm64 ~hppa ~ia64 ~ppc ~ppc64 ~s390 ~sparc ~x86 ~amd64-linux ~x86-linux"
+IUSE="examples unicode"
+
+DEPEND="sys-libs/ncurses:=[unicode(+)?]"
+RDEPEND="${DEPEND}"
+BDEPEND="
+	virtual/pkgconfig
+	verify-sig? ( sec-keys/openpgp-keys-thomasdickey )
+"
+
+src_configure() {
+	if [[ ${CHOST} == *-*-darwin* ]] ; then
+		export ac_cv_prog_LIBTOOL=glibtool
+	fi
+
+	# --with-libtool dropped for now because of broken Makefile
+	# bug #790773
+	#
+	# Fedora and openSUSE at least both build with --enable-const. Without
+	# this, consumers end up broken like gphoto2 in bug #919279.
+	econf \
+		--disable-rpath-hack \
+		--enable-const \
+		--with-shared \
+		--with-pkg-config \
+		--with-ncurses$(usex unicode "w" "")
+}
+
+src_install() {
+	# parallel make installs duplicate libs
+	emake -j1 \
+		DESTDIR="${D}" \
+		DOCUMENT_DIR="${ED}/usr/share/doc/${PF}" \
+		install
+
+	if use examples ; then
+		local x
+		for x in include c++ demos examples cli cli/utils cli/samples ; do
+			docinto ${x}
+			find ${x} -maxdepth 1 -mindepth 1 -type f -print0 | xargs -0 dodoc || die
+		done
+	fi
+
+	find "${ED}" \( -name '*.a' -or -name '*.la' \) -delete || die
+}


             reply	other threads:[~2023-12-06 16:01 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 16:01 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-04-07  3:51 [gentoo-commits] repo/gentoo:master commit in: dev-libs/cdk/ Sam James
2025-04-07  3:48 Sam James
2025-01-18 18:41 Arthur Zamarin
2024-11-23 17:21 Michał Górny
2024-11-23 10:32 Sam James
2024-11-23 10:24 Sam James
2024-11-23 10:24 Sam James
2024-11-23 10:20 Sam James
2024-11-23 10:20 Sam James
2024-04-06  9:11 Sam James
2023-04-05 12:39 Arthur Zamarin
2023-04-04 23:17 Sam James
2023-04-04 22:52 Sam James
2023-04-04 22:42 Sam James
2023-04-04 22:42 Sam James
2023-02-26 18:35 Arthur Zamarin
2023-02-25 18:21 Arthur Zamarin
2023-02-25 18:20 Arthur Zamarin
2023-02-25 18:18 Arthur Zamarin
2023-02-25 18:18 Arthur Zamarin
2023-02-05 19:54 Sam James
2023-02-05 19:54 Sam James
2022-10-27  5:31 Sam James
2022-08-10 20:29 Sam James
2022-01-23 16:23 Jonas Stein
2021-12-20  4:08 Sam James
2021-07-27  3:16 Sam James
2021-07-26 11:17 Sam James
2021-07-18  6:35 Agostino Sarubbo
2021-07-18  6:34 Agostino Sarubbo
2021-07-18  6:33 Agostino Sarubbo
2021-05-19  3:23 Sam James
2021-05-17 22:36 Sam James
2021-05-17 22:36 Sam James
2021-05-09 12:53 David Seifert
2020-08-05  1:03 Sam James
2019-04-06 22:23 Patrice Clement
2019-01-27 11:05 Pacho Ramos
2017-11-08 22:27 Sergei Trofimovich
2017-10-29 21:08 Thomas Deutschmann
2017-10-05  8:37 Sergei Trofimovich
2017-09-15 15:38 Tobias Klausmann
2017-09-10 20:46 Sergei Trofimovich
2017-09-07 20:50 Sergei Trofimovich
2017-09-07 19:24 Sergei Trofimovich
2017-01-29 16:07 Fabian Groffen
2016-10-02  8:13 Jeroen Roovers
2016-08-20 23:23 Tim Harder
2016-08-19  3:13 Tim Harder
2016-05-26  8:34 Tobias Klausmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1701878458.3c6244c59141bcdd5144430a42b87ab90cea2f19.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox