From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9C53F158089 for ; Tue, 14 Nov 2023 02:25:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DF5712BC022; Tue, 14 Nov 2023 02:25:21 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 621CC2BC022 for ; Tue, 14 Nov 2023 02:25:21 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 56EF3335C2E for ; Tue, 14 Nov 2023 02:25:20 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id D1FC2132E for ; Tue, 14 Nov 2023 02:25:18 +0000 (UTC) From: "Michael Orlitzky" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michael Orlitzky" Message-ID: <1699928670.d5cad95f6c02a29cf004130f715d994b66a4b07a.mjo@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: sci-mathematics/polymake/, sci-mathematics/polymake/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: sci-mathematics/polymake/files/polymake-4.11-barycentric-subdiv.patch sci-mathematics/polymake/polymake-4.11.ebuild X-VCS-Directories: sci-mathematics/polymake/ sci-mathematics/polymake/files/ X-VCS-Committer: mjo X-VCS-Committer-Name: Michael Orlitzky X-VCS-Revision: d5cad95f6c02a29cf004130f715d994b66a4b07a X-VCS-Branch: master Date: Tue, 14 Nov 2023 02:25:18 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: aed5100a-4fd3-4405-9018-44fb5d9efd56 X-Archives-Hash: 10ea3650b394758014369808b3b27231 commit: d5cad95f6c02a29cf004130f715d994b66a4b07a Author: Michael Orlitzky gentoo org> AuthorDate: Tue Nov 14 02:23:11 2023 +0000 Commit: Michael Orlitzky gentoo org> CommitDate: Tue Nov 14 02:24:30 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5cad95f sci-mathematics/polymake: re-enable the test suite After adding another patch, the test suite once again passes for me (it hasn't for a few versions, but it did a long time ago). Let's enable it and get some feedback. Signed-off-by: Michael Orlitzky gentoo.org> .../files/polymake-4.11-barycentric-subdiv.patch | 23 ++++++++++++++++++++++ sci-mathematics/polymake/polymake-4.11.ebuild | 10 ++++------ 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/sci-mathematics/polymake/files/polymake-4.11-barycentric-subdiv.patch b/sci-mathematics/polymake/files/polymake-4.11-barycentric-subdiv.patch new file mode 100644 index 000000000000..2f58b0f76299 --- /dev/null +++ b/sci-mathematics/polymake/files/polymake-4.11-barycentric-subdiv.patch @@ -0,0 +1,23 @@ +commit d55dc6bd7f2da9245884f86706cb96e2d11fa83a +Author: Benjamin Lorenz +Date: Tue Nov 7 16:49:33 2023 +0100 + + barycentric_subdivision: dont call back on empty strings + + thanks jamesjer + + @Jenkins: merge + +diff --git a/apps/topaz/src/barycentric_subdivision.cc b/apps/topaz/src/barycentric_subdivision.cc +index 753afb4040..e2d4130bc3 100644 +--- a/apps/topaz/src/barycentric_subdivision.cc ++++ b/apps/topaz/src/barycentric_subdivision.cc +@@ -139,7 +139,7 @@ bs_data2Object(const bool realize, + else + desc << k << "th "; + desc << "barycentric subdivision of " << description; +- if (description.back() != '\n') ++ if (description.empty() || description.back() != '\n') + desc << endl; + p_out.set_description() << desc.str(); + return p_out; diff --git a/sci-mathematics/polymake/polymake-4.11.ebuild b/sci-mathematics/polymake/polymake-4.11.ebuild index 56790dcb5cc9..5feccaae668e 100644 --- a/sci-mathematics/polymake/polymake-4.11.ebuild +++ b/sci-mathematics/polymake/polymake-4.11.ebuild @@ -53,12 +53,10 @@ RDEPEND="${DEPEND} dev-perl/XML-SAX dev-perl/XML-Writer" -# Tests observed failing after upgrade to polymake-4.5. No idea if they -# worked prior to that. Someone who actually understands polymake will -# have to get these working (at least briefly) before we re-enable them. -RESTRICT=test - -PATCHES=( "${FILESDIR}/${P}-singular-sat.patch" ) +PATCHES=( + "${FILESDIR}/${P}-singular-sat.patch" + "${FILESDIR}/${P}-barycentric-subdiv.patch" +) src_configure() { # Without this, the build system tries to use "the highest possible"