public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/icu/, dev-libs/icu/files/
Date: Mon, 13 Nov 2023 06:07:26 +0000 (UTC)	[thread overview]
Message-ID: <1699855613.c4fa72f65cc6718ff3f584647759020788a211e6.sam@gentoo> (raw)

commit:     c4fa72f65cc6718ff3f584647759020788a211e6
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Nov 13 05:31:30 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Nov 13 06:06:53 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4fa72f6

dev-libs/icu: backport test-only fix

No runtime changes, fix is to the test itself.

Closes: https://bugs.gentoo.org/914887
Signed-off-by: Sam James <sam <AT> gentoo.org>

 ...TestHebrewCalendarInTemporalLeapYear-test.patch | 31 ++++++++++++++++++++++
 dev-libs/icu/icu-73.2.ebuild                       |  1 +
 2 files changed, 32 insertions(+)

diff --git a/dev-libs/icu/files/icu-73.2-fix-TestHebrewCalendarInTemporalLeapYear-test.patch b/dev-libs/icu/files/icu-73.2-fix-TestHebrewCalendarInTemporalLeapYear-test.patch
new file mode 100644
index 000000000000..df4dd0793837
--- /dev/null
+++ b/dev-libs/icu/files/icu-73.2-fix-TestHebrewCalendarInTemporalLeapYear-test.patch
@@ -0,0 +1,31 @@
+https://bugs.gentoo.org/914887
+https://github.com/unicode-org/icu/commit/f3b869cbb0b9ced42d7ca4e24626a868a14ddcfc
+
+From f3b869cbb0b9ced42d7ca4e24626a868a14ddcfc Mon Sep 17 00:00:00 2001
+From: Frank Tang <ftang@chromium.org>
+Date: Mon, 18 Sep 2023 20:20:42 -0700
+Subject: [PATCH] ICU-22512 Fix broken TestHebrewCalendarInTemporalLeapYear
+
+Fix broken test mistakenly landed in
+https://github.com/unicode-org/icu/pull/2274
+
+Some important steps were missed in the last landing.
+--- a/test/intltest/caltest.cpp
++++ b/test/intltest/caltest.cpp
+@@ -4028,6 +4028,7 @@ void CalendarTest::TestHebrewCalendarInTemporalLeapYear() {
+     for (gc.set(startYear, UCAL_JANUARY, 1);
+          gc.get(UCAL_YEAR, status) <= stopYear;
+          gc.add(UCAL_DATE, incrementDays, status)) {
++        cal->setTime(gc.getTime(status), status);
+         if (failure(status, "add/get/set/getTime/setTime incorrect")) return;
+ 
+         int32_t cal_year = cal->get(UCAL_EXTENDED_YEAR, status);
+@@ -4036,6 +4037,7 @@ void CalendarTest::TestHebrewCalendarInTemporalLeapYear() {
+             leapTest->set(UCAL_MONTH, 0);
+             leapTest->set(UCAL_DATE, 1);
+             // If 10 months after TISHRI is TAMUZ, then it is a leap year.
++            leapTest->add(UCAL_MONTH, 10, status);
+             hasLeapMonth = leapTest->get(UCAL_MONTH, status) == icu::HebrewCalendar::TAMUZ;
+             yearForHasLeapMonth = cal_year;
+         }
+

diff --git a/dev-libs/icu/icu-73.2.ebuild b/dev-libs/icu/icu-73.2.ebuild
index 84eeae5d9534..870eed474993 100644
--- a/dev-libs/icu/icu-73.2.ebuild
+++ b/dev-libs/icu/icu-73.2.ebuild
@@ -42,6 +42,7 @@ PATCHES=(
 	"${FILESDIR}/${PN}-65.1-remove-bashisms.patch"
 	"${FILESDIR}/${PN}-64.2-darwin.patch"
 	"${FILESDIR}/${PN}-68.1-nonunicode.patch"
+	"${FILESDIR}/${P}-fix-TestHebrewCalendarInTemporalLeapYear-test.patch"
 )
 
 src_prepare() {


             reply	other threads:[~2023-11-13  6:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13  6:07 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-10 19:49 [gentoo-commits] repo/gentoo:master commit in: dev-libs/icu/, dev-libs/icu/files/ Sam James
2022-06-19  9:13 Andreas Sturmlechner
2022-05-18 11:13 Andreas Sturmlechner
2019-10-15 12:04 Lars Wendler
2019-06-27 10:48 Andreas Sturmlechner
2019-04-21 11:35 Lars Wendler
2019-03-30  9:59 Andreas Sturmlechner
2018-11-09  2:11 Andreas Sturmlechner
2017-09-22  6:36 Andreas Hüttel
2017-05-26 15:50 Andreas Hüttel
2017-02-18 16:49 Andreas Hüttel
2017-01-15 21:28 Andreas Hüttel
2016-11-08 17:09 Andreas Hüttel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1699855613.c4fa72f65cc6718ff3f584647759020788a211e6.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox