public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Georgy Yakovlev" <gyakovlev@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-process/numad/files/, sys-process/numad/
Date: Sun, 24 Sep 2023 20:43:15 +0000 (UTC)	[thread overview]
Message-ID: <1695588125.ddd56d6a0ab0ceee1de2ef95c3d88e1d3e780c49.gyakovlev@gentoo> (raw)

commit:     ddd56d6a0ab0ceee1de2ef95c3d88e1d3e780c49
Author:     Georgy Yakovlev <gyakovlev <AT> gentoo <DOT> org>
AuthorDate: Sun Sep 24 20:14:31 2023 +0000
Commit:     Georgy Yakovlev <gyakovlev <AT> gentoo <DOT> org>
CommitDate: Sun Sep 24 20:42:05 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ddd56d6a

sys-process/numad: fix buffer overflow, remove workaround.

Closes: https://bugs.gentoo.org/890985
Signed-off-by: Georgy Yakovlev <gyakovlev <AT> gentoo.org>

 .../files/0001-numad_log-fix-buffer-overflow.patch | 25 ++++++++++++++++++++++
 ...531-r1.ebuild => numad-0.5_p20180531-r2.ebuild} | 10 ++++-----
 2 files changed, 29 insertions(+), 6 deletions(-)

diff --git a/sys-process/numad/files/0001-numad_log-fix-buffer-overflow.patch b/sys-process/numad/files/0001-numad_log-fix-buffer-overflow.patch
new file mode 100644
index 000000000000..c67d58192169
--- /dev/null
+++ b/sys-process/numad/files/0001-numad_log-fix-buffer-overflow.patch
@@ -0,0 +1,25 @@
+From a9e6f292f4ce9443ee95c77c60dd8da68d0db7e9 Mon Sep 17 00:00:00 2001
+From: Lukas Nykryn <lnykryn@redhat.com>
+Date: Wed, 6 Sep 2023 12:27:47 +0200
+Subject: [PATCH] numad_log: fix buffer overflow
+
+---
+ numad.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/numad.c b/numad.c
+index 4c85486..2923842 100644
+--- a/numad.c
++++ b/numad.c
+@@ -153,7 +153,7 @@ void numad_log(int level, const char *fmt, ...) {
+     *p++ = ' ';
+     va_list ap;
+     va_start(ap, fmt);
+-    vsnprintf(p, BUF_SIZE, fmt, ap);
++    vsnprintf(p, BUF_SIZE - strlen(buf) , fmt, ap);
+     va_end(ap);
+     fprintf(log_fs, "%s", buf);
+     fflush(log_fs);
+-- 
+2.39.2
+

diff --git a/sys-process/numad/numad-0.5_p20180531-r1.ebuild b/sys-process/numad/numad-0.5_p20180531-r2.ebuild
similarity index 86%
rename from sys-process/numad/numad-0.5_p20180531-r1.ebuild
rename to sys-process/numad/numad-0.5_p20180531-r2.ebuild
index 229cae6f6556..ce503112f43e 100644
--- a/sys-process/numad/numad-0.5_p20180531-r1.ebuild
+++ b/sys-process/numad/numad-0.5_p20180531-r2.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit flag-o-matic linux-info systemd toolchain-funcs
+inherit linux-info systemd toolchain-funcs
 
 if [[ ${PV} == 9999 ]]; then
 	EGIT_REPO_URI="https://pagure.io/numad.git"
@@ -31,15 +31,13 @@ PATCHES=(
 
 	# from debian/ubuntu: https://sources.debian.org/patches/numad
 	"${FILESDIR}/${PN}-0.5-fix-build-for-no-NR-migrate-pages.patch"
+
+	# from fedora: https://src.fedoraproject.org/rpms/numad/c/b9fdb5b1b09611ba164c04cd994e5e9ddf7fb8f4
+	"${FILESDIR}/0001-numad_log-fix-buffer-overflow.patch"
 )
 
 src_configure() {
 	tc-export AR CC RANLIB
-
-	# FIXME: https://bugs.gentoo.org/890985
-	# temp workaround
-	filter-flags -D_FORTIFY_SOURCE=3
-	append-cppflags -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
 }
 
 src_compile() {


             reply	other threads:[~2023-09-24 20:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-24 20:43 Georgy Yakovlev [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-15 22:53 [gentoo-commits] repo/gentoo:master commit in: sys-process/numad/files/, sys-process/numad/ Georgy Yakovlev
2022-06-20  5:04 Sam James
2018-12-20  1:12 Georgy Yakovlev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1695588125.ddd56d6a0ab0ceee1de2ef95c3d88e1d3e780c49.gyakovlev@gentoo \
    --to=gyakovlev@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox