From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C0CEF158089 for ; Sun, 24 Sep 2023 17:09:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0FE9F2BC039; Sun, 24 Sep 2023 17:09:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EB4212BC039 for ; Sun, 24 Sep 2023 17:09:03 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 3DFB43409C8 for ; Sun, 24 Sep 2023 17:09:03 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 8A48D125C for ; Sun, 24 Sep 2023 17:09:01 +0000 (UTC) From: "WANG Xuerui" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "WANG Xuerui" Message-ID: <1695575119.efa8fedcff3a8c52d5cc6091d7cdd4b7971c9898.xen0n@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-qt/qtbase/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-qt/qtbase/qtbase-6.5.2-r2.ebuild X-VCS-Directories: dev-qt/qtbase/ X-VCS-Committer: xen0n X-VCS-Committer-Name: WANG Xuerui X-VCS-Revision: efa8fedcff3a8c52d5cc6091d7cdd4b7971c9898 X-VCS-Branch: master Date: Sun, 24 Sep 2023 17:09:01 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: fdf9fd5b-96cb-47f2-94c1-ac37196e4b98 X-Archives-Hash: 1f8bd52b8fac00e66934d7fd5c9c9768 commit: efa8fedcff3a8c52d5cc6091d7cdd4b7971c9898 Author: WANG Xuerui gentoo org> AuthorDate: Sun Sep 24 15:48:01 2023 +0000 Commit: WANG Xuerui gentoo org> CommitDate: Sun Sep 24 17:05:19 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=efa8fedc dev-qt/qtbase: keyword 6.5.2-r2 for ~loong Two test cases are failing on a Loongson 3A6000 box: 71 - tst_qprocess (Failed) 304 - tst_qnetworkinterface (Failed) With the following log messages: FAIL! : tst_QProcess::startStopStartStopBuffers(separate-separate) 'process.bytesToWrite() > 0' returned FALSE. () Loc: [/tmp/portage/dev-qt/qtbase-6.5.2-r2/work/qtbase-everywhere-src-6.5.2/tests/auto/corelib/io/qprocess/tst_qprocess.cpp(2461)] FAIL! : tst_QProcess::startStopStartStopBuffers(separate-merged) 'process.bytesToWrite() > 0' returned FALSE. () Loc: [/tmp/portage/dev-qt/qtbase-6.5.2-r2/work/qtbase-everywhere-src-6.5.2/tests/auto/corelib/io/qprocess/tst_qprocess.cpp(2461)] FAIL! : tst_QProcess::startStopStartStopBuffers(merged-separate) 'process.bytesToWrite() > 0' returned FALSE. () Loc: [/tmp/portage/dev-qt/qtbase-6.5.2-r2/work/qtbase-everywhere-src-6.5.2/tests/auto/corelib/io/qprocess/tst_qprocess.cpp(2461)] FAIL! : tst_QProcess::startStopStartStopBuffers(merged-merged) 'process.bytesToWrite() > 0' returned FALSE. () Loc: [/tmp/portage/dev-qt/qtbase-6.5.2-r2/work/qtbase-everywhere-src-6.5.2/tests/auto/corelib/io/qprocess/tst_qprocess.cpp(2461)] FAIL! : tst_QProcess::startStopStartStopBuffers(merged-forwarded) 'process.bytesToWrite() > 0' returned FALSE. () Loc: [/tmp/portage/dev-qt/qtbase-6.5.2-r2/work/qtbase-everywhere-src-6.5.2/tests/auto/corelib/io/qprocess/tst_qprocess.cpp(2461)] FAIL! : tst_QNetworkInterface::localAddress(wg0-xxx.xxx.xxx.xxx) 'pmtu <= outgoingIface->maximumTransmissionUnit()' returned FALSE. () Loc: [/tmp/portage/dev-qt/qtbase-6.5.2-r2/work/qtbase-everywhere-src-6.5.2/tests/auto/network/kernel/qnetworkinterface/tst_qnetworkinterface.cpp(246)] But both are spurious to some extent. For the startStopStartStopBuffers case, a 128KiB write is made to hopefully retain some unwritten data even if the pipe is found writable, and the comment in the test code indicates that Linux is the "worst case" defaulting to 64KiB pipe buffers. This is actually PIPE_DEF_BUFFERS pages, according to include/linux/pipe_fs_i.h; popular arches use 4KiB pages, so 64KiB for them. Linux/LoongArch defaults to 16KiB pages, however, and the test case passes when the write size is quadrupled. And for the localAddress case, it may just be that the WireGuard interface behaves differently than physical ones, and indeed the other interfaces passed the test. So, the library should actually be fully functional on loong, hence the keyword. Signed-off-by: WANG Xuerui gentoo.org> dev-qt/qtbase/qtbase-6.5.2-r2.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-qt/qtbase/qtbase-6.5.2-r2.ebuild b/dev-qt/qtbase/qtbase-6.5.2-r2.ebuild index 2f489c953187..67ce1f180005 100644 --- a/dev-qt/qtbase/qtbase-6.5.2-r2.ebuild +++ b/dev-qt/qtbase/qtbase-6.5.2-r2.ebuild @@ -8,7 +8,7 @@ inherit flag-o-matic qt6-build toolchain-funcs DESCRIPTION="Cross-platform application development framework" if [[ ${QT6_BUILD_TYPE} == release ]]; then - KEYWORDS="amd64 ~arm ~arm64 ~hppa ~x86" + KEYWORDS="amd64 ~arm ~arm64 ~hppa ~loong ~x86" fi declare -A QT6_IUSE=(