From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 96F35158089 for ; Sat, 23 Sep 2023 22:31:44 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C6EB42BC014; Sat, 23 Sep 2023 22:31:43 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A83682BC014 for ; Sat, 23 Sep 2023 22:31:43 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id AE579340817 for ; Sat, 23 Sep 2023 22:31:42 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 07C121242 for ; Sat, 23 Sep 2023 22:31:41 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1695508291.743722ccfa234dd9d4a54f7fbfb14cc2ddf6f0f4.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/dbapi/ X-VCS-Repository: proj/portage X-VCS-Files: lib/portage/dbapi/vartree.py X-VCS-Directories: lib/portage/dbapi/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 743722ccfa234dd9d4a54f7fbfb14cc2ddf6f0f4 X-VCS-Branch: master Date: Sat, 23 Sep 2023 22:31:41 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: c9f977d7-f042-4c82-a6a5-42ca3166fb86 X-Archives-Hash: f285d40ee6bfc5fe5c43a6351cd5f17a commit: 743722ccfa234dd9d4a54f7fbfb14cc2ddf6f0f4 Author: Sam James gentoo org> AuthorDate: Sat Sep 23 22:27:37 2023 +0000 Commit: Sam James gentoo org> CommitDate: Sat Sep 23 22:31:31 2023 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=743722cc vartree: drop 'Grabbing a set' useless noise Prompted by genr8eofl asking about culling it. Fascinatingly, both the message *and* people agreeing it's futile goes back many years: * bf01d6c02087c2b363617ce6ac208d09ea81de25 ('don't display useless messages when using --quiet') * d9fc4acc572c6647a4f27b838d35d27d805d190e (svn migration) * 4ba2baf8456c0eeda0df1bf52a1a3d712d5ac9b7 ('Portage-2.0.41 release. LOTS of bug fixes. Check the ChangeLog.', 2002) This isn't useful for the user at all, so drop it. Signed-off-by: Sam James gentoo.org> lib/portage/dbapi/vartree.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/portage/dbapi/vartree.py b/lib/portage/dbapi/vartree.py index 08ea9234f6..35a401b33c 100644 --- a/lib/portage/dbapi/vartree.py +++ b/lib/portage/dbapi/vartree.py @@ -2660,10 +2660,6 @@ class dblink: ignored_unlink_errnos = self._ignored_unlink_errnos ignored_rmdir_errnos = self._ignored_rmdir_errnos - if not pkgfiles: - showMessage(_("No package files given... Grabbing a set.\n")) - pkgfiles = self.getcontents() - if others_in_slot is None: others_in_slot = [] slot = self.vartree.dbapi._pkg_str(self.mycpv, None).slot @@ -2691,6 +2687,7 @@ class dblink: unmerge_orphans = "unmerge-orphans" in self.settings.features calc_prelink = "prelink-checksums" in self.settings.features + pkgfiles = self.getcontents() if pkgfiles: self.updateprotect() mykeys = list(pkgfiles)