From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0E246158089 for ; Tue, 5 Sep 2023 13:05:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 522712BC026; Tue, 5 Sep 2023 13:05:50 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3487C2BC03F for ; Tue, 5 Sep 2023 13:05:50 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 3DF96335D1C for ; Tue, 5 Sep 2023 13:05:49 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id A20401133 for ; Tue, 5 Sep 2023 13:05:47 +0000 (UTC) From: "Ionen Wolkens" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ionen Wolkens" Message-ID: <1693918871.cf33741bdf6abad9af948cffcbb7e185ce737180.ionen@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/ X-VCS-Repository: repo/gentoo X-VCS-Files: eclass/qt6-build.eclass X-VCS-Directories: eclass/ X-VCS-Committer: ionen X-VCS-Committer-Name: Ionen Wolkens X-VCS-Revision: cf33741bdf6abad9af948cffcbb7e185ce737180 X-VCS-Branch: master Date: Tue, 5 Sep 2023 13:05:47 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 1ab0787e-8ec0-4263-a94d-4caba0a72cfd X-Archives-Hash: 1e55a7aea6792ab8697f923365d64fa6 commit: cf33741bdf6abad9af948cffcbb7e185ce737180 Author: Ionen Wolkens gentoo org> AuthorDate: Sat Sep 2 06:02:07 2023 +0000 Commit: Ionen Wolkens gentoo org> CommitDate: Tue Sep 5 13:01:11 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf33741b qt6-build.eclass: move filter-lto to src_prepare While it feels more right in configure (along with match_cpu_flags), sometime need to check/use compiler flags in src_configure and it is troublesome if not modified until call the eclass' src_configure. Signed-off-by: Ionen Wolkens gentoo.org> eclass/qt6-build.eclass | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/eclass/qt6-build.eclass b/eclass/qt6-build.eclass index 8db83524d5e3..187427dd04da 100644 --- a/eclass/qt6-build.eclass +++ b/eclass/qt6-build.eclass @@ -109,6 +109,17 @@ qt6-build_src_prepare() { _qt6-build_prepare_env _qt6-build_match_cpu_flags + + # LTO cause test failures in several components (e.g. qtcharts, + # multimedia, scxml, wayland, webchannel, ...). + # + # Exact extent/causes unknown, but for some related-sounding bugs: + # https://bugreports.qt.io/browse/QTBUG-112332 + # https://bugreports.qt.io/browse/QTBUG-115731 + # + # Does not manifest itself with clang:16 (did with gcc-13.2.0), but + # still assumed to be generally unsafe either way in current state. + filter-lto } # @FUNCTION: qt6-build_src_configure @@ -136,17 +147,6 @@ qt6-build_src_configure() { -DQT_USE_DEFAULT_CMAKE_OPTIMIZATION_FLAGS=ON ) - # LTO cause test failures in several components (e.g. qtcharts, - # multimedia, scxml, wayland, webchannel, ...). - # - # Exact extent/causes unknown, but for some related-sounding bugs: - # https://bugreports.qt.io/browse/QTBUG-112332 - # https://bugreports.qt.io/browse/QTBUG-115731 - # - # Does not manifest itself with clang:16 (did with gcc-13.2.0), but - # still assumed to be generally unsafe either way in current state. - filter-lto - cmake_src_configure }