From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BCB6315800A for ; Tue, 29 Aug 2023 07:49:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9F9302BC02F; Tue, 29 Aug 2023 07:49:19 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7F5F52BC02F for ; Tue, 29 Aug 2023 07:49:19 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 38432340B1C for ; Tue, 29 Aug 2023 07:49:18 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 3DF3210DA for ; Tue, 29 Aug 2023 07:49:15 +0000 (UTC) From: "Conrad Kostecki" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Conrad Kostecki" Message-ID: <1693295346.cff22ee58e44213ef9c8d5ad4014c8c415ccd9ae.conikost@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-lang/perl/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-lang/perl/files/perl-5.34.0-fallback-getcwd-pwd.patch X-VCS-Directories: dev-lang/perl/files/ X-VCS-Committer: conikost X-VCS-Committer-Name: Conrad Kostecki X-VCS-Revision: cff22ee58e44213ef9c8d5ad4014c8c415ccd9ae X-VCS-Branch: master Date: Tue, 29 Aug 2023 07:49:15 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: d28bd009-4e4c-4bc3-b3e0-75c2cd0f072e X-Archives-Hash: e7adeac918c33210e83759a00eb7c7a6 commit: cff22ee58e44213ef9c8d5ad4014c8c415ccd9ae Author: Michael Mair-Keimberger levelnine at> AuthorDate: Sun Aug 20 15:09:56 2023 +0000 Commit: Conrad Kostecki gentoo org> CommitDate: Tue Aug 29 07:49:06 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cff22ee5 dev-lang/perl: remove unused patch Signed-off-by: Michael Mair-Keimberger levelnine.at> Closes: https://github.com/gentoo/gentoo/pull/32392 Signed-off-by: Conrad Kostecki gentoo.org> .../files/perl-5.34.0-fallback-getcwd-pwd.patch | 263 --------------------- 1 file changed, 263 deletions(-) diff --git a/dev-lang/perl/files/perl-5.34.0-fallback-getcwd-pwd.patch b/dev-lang/perl/files/perl-5.34.0-fallback-getcwd-pwd.patch deleted file mode 100644 index 849a09a39a05..000000000000 --- a/dev-lang/perl/files/perl-5.34.0-fallback-getcwd-pwd.patch +++ /dev/null @@ -1,263 +0,0 @@ -https://github.com/Perl/perl5/pull/18791 -https://github.com/Perl/perl5/issues/18703 -https://bugs.gentoo.org/818172 - -From: Tony Cook -Date: Tue, 4 May 2021 14:55:50 +1000 -Subject: [PATCH 1/4] remove code that assuming finding pwd on the path is - reasonable - -We deliberately clear PATH when invoking pwd, so this search is -useless. ---- - dist/PathTools/Cwd.pm | 14 -------------- - 1 file changed, 14 deletions(-) - -diff --git a/dist/PathTools/Cwd.pm b/dist/PathTools/Cwd.pm -index 6a1d2f17ee57..49c12885b32e 100644 ---- a/dist/PathTools/Cwd.pm -+++ b/dist/PathTools/Cwd.pm -@@ -213,20 +213,6 @@ sub _backtick_pwd { - # we take care not to override an existing definition for cwd(). - - unless ($METHOD_MAP{$^O}{cwd} or defined &cwd) { -- # The pwd command is not available in some chroot(2)'ed environments -- my $sep = $Config::Config{path_sep} || ':'; -- my $os = $^O; # Protect $^O from tainting -- -- -- # Try again to find a pwd, this time searching the whole PATH. -- if (defined $ENV{PATH} and $os ne 'MSWin32') { # no pwd on Windows -- my @candidates = split($sep, $ENV{PATH}); -- while (!$found_pwd_cmd and @candidates) { -- my $candidate = shift @candidates; -- $found_pwd_cmd = 1 if -x "$candidate/pwd"; -- } -- } -- - if( $found_pwd_cmd ) - { - *cwd = \&_backtick_pwd; - -From e5378ea37c6c4910107975d8099c1d552af0c7b3 Mon Sep 17 00:00:00 2001 -From: Tony Cook -Date: Wed, 5 May 2021 10:12:31 +1000 -Subject: [PATCH 2/4] don't fallback to simple pwd - -When _backtick_pwd invokes $pwd_cmd it first clears the PATH, and since -the command has no shell metacharacters, it perl won't invoke the -shell, so it will always fail. - -An alternative here might be to use "/bin/sh -c pwd" but there's no -guarantee that pwd is available as a shell builtin. ---- - dist/PathTools/Cwd.pm | 6 ------ - 1 file changed, 6 deletions(-) - -diff --git a/dist/PathTools/Cwd.pm b/dist/PathTools/Cwd.pm -index 49c12885b32e..fbe683e20b8a 100644 ---- a/dist/PathTools/Cwd.pm -+++ b/dist/PathTools/Cwd.pm -@@ -181,12 +181,6 @@ if ($^O =~ /android/) { - } - - my $found_pwd_cmd = defined($pwd_cmd); --unless ($pwd_cmd) { -- # Isn't this wrong? _backtick_pwd() will fail if someone has -- # pwd in their path but it is not /bin/pwd or /usr/bin/pwd? -- # See [perl #16774]. --jhi -- $pwd_cmd = 'pwd'; --} - - # Lazy-load Carp - sub _carp { require Carp; Carp::carp(@_) } - -From e14ffd3c21efe708a5fb5e25f29d61ccb6ee0a0a Mon Sep 17 00:00:00 2001 -From: Tony Cook -Date: Tue, 4 May 2021 15:04:25 +1000 -Subject: [PATCH 3/4] avoid a prototype warning assigning \&getcwd to *cwd - -This would produce a warning if we fallback to using getcwd() where -getcwd() has a prototype. ---- - dist/PathTools/Cwd.pm | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) - -diff --git a/dist/PathTools/Cwd.pm b/dist/PathTools/Cwd.pm -index fbe683e20b8a..b6dc0b798e8c 100644 ---- a/dist/PathTools/Cwd.pm -+++ b/dist/PathTools/Cwd.pm -@@ -212,7 +212,8 @@ unless ($METHOD_MAP{$^O}{cwd} or defined &cwd) { - *cwd = \&_backtick_pwd; - } - else { -- *cwd = \&getcwd; -+ # getcwd() might have an empty prototype -+ *cwd = sub { getcwd(); }; - } - } - - -From e725e6ced4d2bbb6a5866992509c2ac3e995c228 Mon Sep 17 00:00:00 2001 -From: Tony Cook -Date: Wed, 12 May 2021 12:24:59 +1000 -Subject: [PATCH 4/4] bump PathTools to 3.81 - ---- - dist/PathTools/Cwd.pm | 2 +- - dist/PathTools/lib/File/Spec.pm | 2 +- - dist/PathTools/lib/File/Spec/AmigaOS.pm | 2 +- - dist/PathTools/lib/File/Spec/Cygwin.pm | 2 +- - dist/PathTools/lib/File/Spec/Epoc.pm | 2 +- - dist/PathTools/lib/File/Spec/Functions.pm | 2 +- - dist/PathTools/lib/File/Spec/Mac.pm | 2 +- - dist/PathTools/lib/File/Spec/OS2.pm | 2 +- - dist/PathTools/lib/File/Spec/Unix.pm | 2 +- - dist/PathTools/lib/File/Spec/VMS.pm | 2 +- - dist/PathTools/lib/File/Spec/Win32.pm | 2 +- - 11 files changed, 11 insertions(+), 11 deletions(-) - -diff --git a/dist/PathTools/Cwd.pm b/dist/PathTools/Cwd.pm -index b6dc0b798e8c..4a9c786c1c3c 100644 ---- a/dist/PathTools/Cwd.pm -+++ b/dist/PathTools/Cwd.pm -@@ -3,7 +3,7 @@ use strict; - use Exporter; - - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - my $xs_version = $VERSION; - $VERSION =~ tr/_//d; - -diff --git a/dist/PathTools/lib/File/Spec.pm b/dist/PathTools/lib/File/Spec.pm -index 30d883b61b3e..fe738acf58bd 100644 ---- a/dist/PathTools/lib/File/Spec.pm -+++ b/dist/PathTools/lib/File/Spec.pm -@@ -2,7 +2,7 @@ package File::Spec; - - use strict; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - my %module = ( -diff --git a/dist/PathTools/lib/File/Spec/AmigaOS.pm b/dist/PathTools/lib/File/Spec/AmigaOS.pm -index fd9da81cdf5a..1398379ca57c 100644 ---- a/dist/PathTools/lib/File/Spec/AmigaOS.pm -+++ b/dist/PathTools/lib/File/Spec/AmigaOS.pm -@@ -3,7 +3,7 @@ package File::Spec::AmigaOS; - use strict; - require File::Spec::Unix; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - our @ISA = qw(File::Spec::Unix); -diff --git a/dist/PathTools/lib/File/Spec/Cygwin.pm b/dist/PathTools/lib/File/Spec/Cygwin.pm -index 953c23361a10..55d551ce0663 100644 ---- a/dist/PathTools/lib/File/Spec/Cygwin.pm -+++ b/dist/PathTools/lib/File/Spec/Cygwin.pm -@@ -3,7 +3,7 @@ package File::Spec::Cygwin; - use strict; - require File::Spec::Unix; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - our @ISA = qw(File::Spec::Unix); -diff --git a/dist/PathTools/lib/File/Spec/Epoc.pm b/dist/PathTools/lib/File/Spec/Epoc.pm -index fcb9e894e33c..4cde744231aa 100644 ---- a/dist/PathTools/lib/File/Spec/Epoc.pm -+++ b/dist/PathTools/lib/File/Spec/Epoc.pm -@@ -2,7 +2,7 @@ package File::Spec::Epoc; - - use strict; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - require File::Spec::Unix; -diff --git a/dist/PathTools/lib/File/Spec/Functions.pm b/dist/PathTools/lib/File/Spec/Functions.pm -index e14ad2f74538..4b3d7bbde130 100644 ---- a/dist/PathTools/lib/File/Spec/Functions.pm -+++ b/dist/PathTools/lib/File/Spec/Functions.pm -@@ -3,7 +3,7 @@ package File::Spec::Functions; - use File::Spec; - use strict; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - require Exporter; -diff --git a/dist/PathTools/lib/File/Spec/Mac.pm b/dist/PathTools/lib/File/Spec/Mac.pm -index 8026edcb1261..51d00a01f6f7 100644 ---- a/dist/PathTools/lib/File/Spec/Mac.pm -+++ b/dist/PathTools/lib/File/Spec/Mac.pm -@@ -4,7 +4,7 @@ use strict; - use Cwd (); - require File::Spec::Unix; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - our @ISA = qw(File::Spec::Unix); -diff --git a/dist/PathTools/lib/File/Spec/OS2.pm b/dist/PathTools/lib/File/Spec/OS2.pm -index 3c35ba99b48a..57d67ba01e93 100644 ---- a/dist/PathTools/lib/File/Spec/OS2.pm -+++ b/dist/PathTools/lib/File/Spec/OS2.pm -@@ -4,7 +4,7 @@ use strict; - use Cwd (); - require File::Spec::Unix; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - our @ISA = qw(File::Spec::Unix); -diff --git a/dist/PathTools/lib/File/Spec/Unix.pm b/dist/PathTools/lib/File/Spec/Unix.pm -index c06d18f46819..df98f580c3ea 100644 ---- a/dist/PathTools/lib/File/Spec/Unix.pm -+++ b/dist/PathTools/lib/File/Spec/Unix.pm -@@ -3,7 +3,7 @@ package File::Spec::Unix; - use strict; - use Cwd (); - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - =head1 NAME -diff --git a/dist/PathTools/lib/File/Spec/VMS.pm b/dist/PathTools/lib/File/Spec/VMS.pm -index 9b78c8b4bc6e..bbff3ad7d807 100644 ---- a/dist/PathTools/lib/File/Spec/VMS.pm -+++ b/dist/PathTools/lib/File/Spec/VMS.pm -@@ -4,7 +4,7 @@ use strict; - use Cwd (); - require File::Spec::Unix; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - our @ISA = qw(File::Spec::Unix); -diff --git a/dist/PathTools/lib/File/Spec/Win32.pm b/dist/PathTools/lib/File/Spec/Win32.pm -index 153744202338..b38419cdf1a6 100644 ---- a/dist/PathTools/lib/File/Spec/Win32.pm -+++ b/dist/PathTools/lib/File/Spec/Win32.pm -@@ -5,7 +5,7 @@ use strict; - use Cwd (); - require File::Spec::Unix; - --our $VERSION = '3.80'; -+our $VERSION = '3.81'; - $VERSION =~ tr/_//d; - - our @ISA = qw(File::Spec::Unix); -