public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/sync/
Date: Sat, 19 Aug 2023 14:49:47 +0000 (UTC)	[thread overview]
Message-ID: <1692456574.eb3a3878e36e32ed0f8385b7ff8e978fbbe1aff3.sam@gentoo> (raw)

commit:     eb3a3878e36e32ed0f8385b7ff8e978fbbe1aff3
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sat Aug 19 13:51:45 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Aug 19 14:49:34 2023 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=eb3a3878

sync: handle https_proxy too

Pass down https_proxy into gemato.

If http_proxy isn't set, but https_proxy is, then let's fall back to it to help
users out. gnupg itself doesn't use https_proxy but users may have only https_proxy
set rather than http_proxy and https_proxy.

We've had cases reported where users only have https_proxy and not http_proxy set,
so include this to help them out too.

Bug: https://bugs.gentoo.org/691434
Bug: https://bugs.gentoo.org/835927
Bug: https://bugs.gentoo.org/911629
Signed-off-by: Sam James <sam <AT> gentoo.org>

 lib/portage/sync/syncbase.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/portage/sync/syncbase.py b/lib/portage/sync/syncbase.py
index b7228a38a6..9c25a0299b 100644
--- a/lib/portage/sync/syncbase.py
+++ b/lib/portage/sync/syncbase.py
@@ -333,6 +333,8 @@ class SyncBase:
             # Override global proxy setting with one provided in emerge configuration
             if "http_proxy" in self.spawn_kwargs["env"]:
                 proxy = self.spawn_kwargs["env"]["http_proxy"]
+            elif "https_proxy" in self.spawn_kwargs["env"]:
+                proxy = self.spawn_kwargs["env"]["https_proxy"]
             else:
                 proxy = None
 


             reply	other threads:[~2023-08-19 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19 14:49 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-24 17:45 [gentoo-commits] proj/portage:master commit in: lib/portage/sync/ Zac Medico
2020-07-20 22:05 Zac Medico
2019-07-05  5:39 Michał Górny
2019-06-25 20:07 Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1692456574.eb3a3878e36e32ed0f8385b7ff8e978fbbe1aff3.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox