From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id ADE0315800A for ; Thu, 3 Aug 2023 17:28:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 052E7E0D59; Thu, 3 Aug 2023 17:28:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E0AC2E0D59 for ; Thu, 3 Aug 2023 17:28:58 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0D1C7340D1F for ; Thu, 3 Aug 2023 17:28:58 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 27AF1E8F for ; Thu, 3 Aug 2023 17:28:56 +0000 (UTC) From: "Arthur Zamarin" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Arthur Zamarin" Message-ID: <1691083715.aa668df52b198d1e1baaa3ce9d3836052e50a85f.arthurzam@gentoo> Subject: [gentoo-commits] proj/pkgcore/pkgcheck:master commit in: src/pkgcheck/checks/ X-VCS-Repository: proj/pkgcore/pkgcheck X-VCS-Files: src/pkgcheck/checks/codingstyle.py X-VCS-Directories: src/pkgcheck/checks/ X-VCS-Committer: arthurzam X-VCS-Committer-Name: Arthur Zamarin X-VCS-Revision: aa668df52b198d1e1baaa3ce9d3836052e50a85f X-VCS-Branch: master Date: Thu, 3 Aug 2023 17:28:56 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: e6f0f037-56da-47aa-b906-e98e326a384c X-Archives-Hash: 5d296102b9c84257031d4b5d1dd15acd commit: aa668df52b198d1e1baaa3ce9d3836052e50a85f Author: Ulrich Müller gentoo org> AuthorDate: Wed Aug 2 12:45:53 2023 +0000 Commit: Arthur Zamarin gentoo org> CommitDate: Thu Aug 3 17:28:35 2023 +0000 URL: https://gitweb.gentoo.org/proj/pkgcore/pkgcheck.git/commit/?id=aa668df5 VariableScopeCheck: BROOT is allowed also in pkg_{pre,post}{inst,rm} PMS commit: https://gitweb.gentoo.org/proj/pms.git/commit/?id=1a27729740e17ccd4b7a4527a46011fa62c9efb1 Signed-off-by: Ulrich Müller gentoo.org> Closes: https://github.com/pkgcore/pkgcheck/pull/609 Signed-off-by: Arthur Zamarin gentoo.org> src/pkgcheck/checks/codingstyle.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pkgcheck/checks/codingstyle.py b/src/pkgcheck/checks/codingstyle.py index 2b7dbafe..c99a8eca 100644 --- a/src/pkgcheck/checks/codingstyle.py +++ b/src/pkgcheck/checks/codingstyle.py @@ -986,7 +986,7 @@ class VariableScopeCheck(Check): "EROOT": "pkg_", "SYSROOT": ("src_", "pkg_setup"), "ESYSROOT": ("src_", "pkg_setup"), - "BROOT": ("src_", "pkg_setup"), + "BROOT": ("src_", "pkg_setup", "pkg_preinst", "pkg_prerm", "pkg_post"), "D": ("src_install", "pkg_preinst"), # pkg_postinst is forbidden by QA policy PG 107 "ED": ("src_install", "pkg_preinst"), # pkg_postinst is forbidden by QA policy PG 107 "DESTTREE": "src_install",