* [gentoo-commits] repo/gentoo:master commit in: profiles/base/, profiles/targets/desktop/, profiles/arch/riscv/, ...
@ 2023-07-26 1:58 Ionen Wolkens
0 siblings, 0 replies; only message in thread
From: Ionen Wolkens @ 2023-07-26 1:58 UTC (permalink / raw
To: gentoo-commits
commit: 0e264bc426f18f7f9076f9b4fe724aa445bc23a1
Author: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Wed Jul 26 01:31:57 2023 +0000
Commit: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Wed Jul 26 01:44:20 2023 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e264bc4
profiles: have media-video/mpv use luajit more thoroughly
tl;dr fixes RequiredUseDefaults, and also uses luajit on non-desktop
mpv currently no plans to ever support >=lua5-3, and with lua5-1 being
essentially unmaintained it's preferred to use the actively maintained
luajit when possible.
Because of this, wanted to straight up remove lua5-1 from COMPAT, but
then luajit is not available on as many arches as lua5-1.
So to pick luajit by default (against's profile defaults), there is
two options:
(1). package.use in profile with -lua5-1 luajit
(2). mask lua5-1, force luajit
And fortunately we don't need to worry about LUA_TARGETS, just SINGLE.
Old situation is sub-optimal:
- (1) is used in desktop profile only (should be all)
- arches which don't support luajit have bad REQUIRED_USE defaults
(should be inverted where needed)
(2) has a big advantage, if users set their own default e.g.
*/* LUA_SINGLE_TARGET: -* lua5-4
Then luajit will still be forced and they do not need a package.use
entry to emerge mpv.
Downside is that if a user really want to use old lua5-1, then
they need to mess with /etc/portage/profile. But generally I feel
(2) is still better for the general user experience, and this
commit does that.
wrt old "lua" default, not needed in profile given IUSE=+lua default
is in all mpv ebulds already (-sdl still makes sense).
Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>
profiles/arch/hppa/package.use.force | 8 ++++++++
profiles/arch/hppa/package.use.mask | 8 ++++++++
profiles/arch/loong/package.use.force | 8 ++++++++
profiles/arch/loong/package.use.mask | 8 ++++++++
profiles/arch/powerpc/ppc64/package.use.force | 8 ++++++++
profiles/arch/powerpc/ppc64/package.use.mask | 8 ++++++++
profiles/arch/riscv/package.use.force | 10 +++++++++-
profiles/arch/riscv/package.use.mask | 8 ++++++++
profiles/base/package.use.force | 8 ++++++++
profiles/base/package.use.mask | 8 ++++++++
profiles/targets/desktop/package.use | 9 ++-------
11 files changed, 83 insertions(+), 8 deletions(-)
diff --git a/profiles/arch/hppa/package.use.force b/profiles/arch/hppa/package.use.force
index b0be4f598798..1cf8b24eca95 100644
--- a/profiles/arch/hppa/package.use.force
+++ b/profiles/arch/hppa/package.use.force
@@ -1,6 +1,14 @@
# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv lua_single_target_lua5-1 -lua_single_target_luajit
+
# Sam James <sam@gentoo.org> (2023-04-30)
# Stacks on HPPA grow upwards and GCC doesn't support SSP or SCP there.
sys-devel/gcc -default-stack-clash-protection
diff --git a/profiles/arch/hppa/package.use.mask b/profiles/arch/hppa/package.use.mask
index f2c66c477fb6..e4cb9878db87 100644
--- a/profiles/arch/hppa/package.use.mask
+++ b/profiles/arch/hppa/package.use.mask
@@ -4,6 +4,14 @@
# NOTE: When masking a USE flag due to missing keywords, please file a keyword
# request bug for the hppa arch.
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv -lua_single_target_lua5-1 lua_single_target_luajit
+
# Matt Turner <mattst88@gentoo.org> (2023-05-30)
# sys-apps/dbus-broker is not keyworded
app-accessibility/at-spi2-core dbus-broker
diff --git a/profiles/arch/loong/package.use.force b/profiles/arch/loong/package.use.force
index ccd2246cf5a9..f1a5dcc38a90 100644
--- a/profiles/arch/loong/package.use.force
+++ b/profiles/arch/loong/package.use.force
@@ -1,6 +1,14 @@
# Copyright 2022-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv lua_single_target_lua5-1 -lua_single_target_luajit
+
# WANG Xuerui <xen0n@gentoo.org> (2023-07-19)
# dev-lang/spidermonkey still waiting on upstream lld support
sys-auth/polkit duktape
diff --git a/profiles/arch/loong/package.use.mask b/profiles/arch/loong/package.use.mask
index ca2061b5a0ba..a328d9999e33 100644
--- a/profiles/arch/loong/package.use.mask
+++ b/profiles/arch/loong/package.use.mask
@@ -1,6 +1,14 @@
# Copyright 2022-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv -lua_single_target_lua5-1 lua_single_target_luajit
+
# WANG Xuerui <xen0n@gentoo.org> (2023-07-19)
# Temporary masks; to be lifted after leaving wd40 status.
gnome-base/nautilus previewer
diff --git a/profiles/arch/powerpc/ppc64/package.use.force b/profiles/arch/powerpc/ppc64/package.use.force
index 24fcd31f002d..6f146360a178 100644
--- a/profiles/arch/powerpc/ppc64/package.use.force
+++ b/profiles/arch/powerpc/ppc64/package.use.force
@@ -1,6 +1,14 @@
# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv lua_single_target_lua5-1 -lua_single_target_luajit
+
# Samuli Suominen <ssuominen@gentoo.org> (2012-10-30)
# Only gnome-base/gdm has stable keywording. If x11-misc/lightdm or kde-plasma/kdm gets
# stable keyword, this line can be removed.
diff --git a/profiles/arch/powerpc/ppc64/package.use.mask b/profiles/arch/powerpc/ppc64/package.use.mask
index d21d9c69385f..024cd7c1512a 100644
--- a/profiles/arch/powerpc/ppc64/package.use.mask
+++ b/profiles/arch/powerpc/ppc64/package.use.mask
@@ -1,6 +1,14 @@
# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv -lua_single_target_lua5-1 lua_single_target_luajit
+
# Sam James <sam@gentoo.org> (2023-04-14)
# Needs dev-python/sympy which is not yet keyworded, see bug #892183
dev-python/nbval test
diff --git a/profiles/arch/riscv/package.use.force b/profiles/arch/riscv/package.use.force
index 6a29c97d302d..bbeece97d895 100644
--- a/profiles/arch/riscv/package.use.force
+++ b/profiles/arch/riscv/package.use.force
@@ -1,6 +1,14 @@
-# Copyright 2021-2022 Gentoo Authors
+# Copyright 2021-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv -lua_single_target_luajit lua_single_target_lua5-1
+
# Mike Rivnak <rivnakm1@gmail.com> (2022-11-30)
# luajit is currently not supported on riscv, so use lua instead
app-editors/neovim lua_single_target_lua5-1
diff --git a/profiles/arch/riscv/package.use.mask b/profiles/arch/riscv/package.use.mask
index a695a1db6a74..32f07bab1ea7 100644
--- a/profiles/arch/riscv/package.use.mask
+++ b/profiles/arch/riscv/package.use.mask
@@ -1,6 +1,14 @@
# Copyright 2019-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv lua_single_target_luajit -lua_single_target_lua5-1
+
# Mike Gilbert <floppym@gentoo.org> (2023-05-27)
# sd-boot should work here.
sys-apps/systemd -boot -gnuefi
diff --git a/profiles/base/package.use.force b/profiles/base/package.use.force
index 3396175ed2bd..cdffaf3b2059 100644
--- a/profiles/base/package.use.force
+++ b/profiles/base/package.use.force
@@ -1,6 +1,14 @@
# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv lua_single_target_luajit
+
# Joonas Niilola <juippis@gentoo.org> (2023-07-21)
# -system-librnp is currently broken with upstream package.
>=mail-client/thunderbird-115.0 system-librnp
diff --git a/profiles/base/package.use.mask b/profiles/base/package.use.mask
index d650ded1043b..f9334180fdd1 100644
--- a/profiles/base/package.use.mask
+++ b/profiles/base/package.use.mask
@@ -6,6 +6,14 @@
# This file is only for generic masks. For arch-specific masks (i.e.
# mask everywhere, unmask on arch/*) use arch/base.
+# Ionen Wolkens <ionen@gentoo.org> (2023-07-26)
+# MPV currently[1] has no plans to support >=lua5-3 making luajit
+# the only choice for maintained lua. Apply mask/force to override
+# the profile's defaults, and invert on arches where not keyworded.
+# Done this way also avoids conflicts for users using another default.
+# [1] https://github.com/mpv-player/mpv/wiki/FAQ#why-does-mpv-not-support-lua-53-or-newer
+media-video/mpv lua_single_target_lua5-1
+
# Hans de Graaff <graaff@gentoo.org> (2023-07-21)
# jemalloc has been a source of sometimes hard to track bugs in the
# past. It is now masked with the intention to remove it altogether at a
diff --git a/profiles/targets/desktop/package.use b/profiles/targets/desktop/package.use
index 38ebc3ebc6fb..723ca5f21c49 100644
--- a/profiles/targets/desktop/package.use
+++ b/profiles/targets/desktop/package.use
@@ -1,4 +1,4 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
# Alexey Sokolov <alexey+gentoo@asokolov.org> (2022-12-27)
@@ -57,14 +57,9 @@ kde-frameworks/kfilemetadata taglib
dev-lang/php -exif -truetype
# Ilya Tumaykin <itumaykin+gentoo@gmail.com> (2017-02-02)
-# Enable luajit for OSC and youtube-dl support by default.
# Override default +sdl from desktop profile and disable sdl outputs.
# These outputs are for systems without a proper audio/video support.
-# NOTE: Needs syncing to negate profile defaults if we decide
-# to keep this up.
-media-video/mpv lua -sdl
-media-video/mpv -lua_single_target_lua5-1
-media-video/mpv lua_single_target_luajit
+media-video/mpv -sdl
# Mike Gilbert <floppym@gentoo.org> (2017-01-04)
# Needed by x11-misc/xdg-utils.
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-26 1:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 1:58 [gentoo-commits] repo/gentoo:master commit in: profiles/base/, profiles/targets/desktop/, profiles/arch/riscv/, Ionen Wolkens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox