public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-apps/portage/, sys-apps/portage/files/
Date: Sat, 15 Jul 2023 03:45:39 +0000 (UTC)	[thread overview]
Message-ID: <1689392641.67e33dbaf367adfc465f322d0b6b5793c76207a8.sam@gentoo> (raw)

commit:     67e33dbaf367adfc465f322d0b6b5793c76207a8
Author:     Oskari Pirhonen <xxc3ncoredxx <AT> gmail <DOT> com>
AuthorDate: Sat Jul 15 03:20:05 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Jul 15 03:44:01 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=67e33dba

sys-apps/portage: backport message fix

Backport the "no ebuilds/binpkgs" message fix from the unreleased 3.0.50
to the affected versions.

Bug: https://bugs.gentoo.org/909853
Signed-off-by: Oskari Pirhonen <xxc3ncoredxx <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/31891
Signed-off-by: Sam James <sam <AT> gentoo.org>

 ...epgraph.py-fix-no-ebuilds-binpkgs-message.patch | 43 ++++++++++++++++++++++
 ...0.48.1-r1.ebuild => portage-3.0.48.1-r2.ebuild} |  5 +++
 ...tage-3.0.49.ebuild => portage-3.0.49-r1.ebuild} |  5 +++
 3 files changed, 53 insertions(+)

diff --git a/sys-apps/portage/files/depgraph.py-fix-no-ebuilds-binpkgs-message.patch b/sys-apps/portage/files/depgraph.py-fix-no-ebuilds-binpkgs-message.patch
new file mode 100644
index 000000000000..97cff72cd85c
--- /dev/null
+++ b/sys-apps/portage/files/depgraph.py-fix-no-ebuilds-binpkgs-message.patch
@@ -0,0 +1,43 @@
+From b199d0307b47f9fb06dbe533d7e24926a561c238 Mon Sep 17 00:00:00 2001
+From: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
+Date: Sun, 9 Jul 2023 00:08:27 -0500
+Subject: [PATCH] depgraph.py: fix "no ebuilds/binpkgs" message
+
+The "there are no binary packages to satisfy" was being unconditionally
+output for packages that could not be found. Fix the logic for choosing
+between the "binary packages" and "ebuilds" form of the message.
+
+This is a temporary stopgap as alluded to by me in the bug, but the
+tl;dr is that some entries in the `myopts` dict have "y"/"n" values
+whereas some are True/unset, and this discrepancy should be sorted out.
+
+[sam: Add NEWS and Fixes, although the change in that commit _shouldn't_
+have been wrong, it is because of a quirk for now...]
+
+[oskari: remove NEWS for backport]
+
+Bug: https://bugs.gentoo.org/909853
+Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
+Closes: https://github.com/gentoo/portage/pull/1065
+Fixes: 0b21a5a392bd84c07b94373991f59108fbe98516
+Signed-off-by: Sam James <sam@gentoo.org>
+---
+ lib/_emerge/depgraph.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/_emerge/depgraph.py b/lib/_emerge/depgraph.py
+index a36ab6351..1aeae6257 100644
+--- a/lib/_emerge/depgraph.py
++++ b/lib/_emerge/depgraph.py
+@@ -6456,7 +6456,7 @@ class depgraph:
+                     cp_exists = True
+                     break
+ 
+-            if self._frozen_config.myopts.get("--usepkgonly", "y"):
++            if self._frozen_config.myopts.get("--usepkgonly", False):
+                 writemsg(
+                     f"\nemerge: there are no binary packages to satisfy {green(xinfo)}.\n",
+                     noiselevel=-1,
+-- 
+2.41.0
+

diff --git a/sys-apps/portage/portage-3.0.48.1-r1.ebuild b/sys-apps/portage/portage-3.0.48.1-r2.ebuild
similarity index 98%
rename from sys-apps/portage/portage-3.0.48.1-r1.ebuild
rename to sys-apps/portage/portage-3.0.48.1-r2.ebuild
index 9e5f7353bb48..d86dba628ab6 100644
--- a/sys-apps/portage/portage-3.0.48.1-r1.ebuild
+++ b/sys-apps/portage/portage-3.0.48.1-r2.ebuild
@@ -93,6 +93,11 @@ PDEPEND="
 	)
 "
 
+# message patch used in 3.0.48.1 and 3.0.49 (bug 909853)
+PATCHES=(
+	"${FILESDIR}/depgraph.py-fix-no-ebuilds-binpkgs-message.patch"
+)
+
 distutils_enable_tests pytest
 
 pkg_pretend() {

diff --git a/sys-apps/portage/portage-3.0.49.ebuild b/sys-apps/portage/portage-3.0.49-r1.ebuild
similarity index 98%
rename from sys-apps/portage/portage-3.0.49.ebuild
rename to sys-apps/portage/portage-3.0.49-r1.ebuild
index f4767cd601e3..5375872b2127 100644
--- a/sys-apps/portage/portage-3.0.49.ebuild
+++ b/sys-apps/portage/portage-3.0.49-r1.ebuild
@@ -93,6 +93,11 @@ PDEPEND="
 	)
 "
 
+# message patch used in 3.0.48.1 and 3.0.49 (bug 909853)
+PATCHES=(
+	"${FILESDIR}/depgraph.py-fix-no-ebuilds-binpkgs-message.patch"
+)
+
 distutils_enable_tests pytest
 
 pkg_pretend() {


             reply	other threads:[~2023-07-15  3:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15  3:45 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-05-17 13:05 [gentoo-commits] repo/gentoo:master commit in: sys-apps/portage/, sys-apps/portage/files/ Sam James
2024-05-10 18:26 Sam James
2023-12-03  8:02 Sam James
2023-10-26 15:53 Mike Gilbert
2023-07-30 13:10 Sam James
2023-02-28  3:14 Sam James
2023-01-13  3:50 Sam James
2022-11-30  7:07 Sam James
2022-11-20 23:37 Sam James
2022-11-20  2:46 Sam James
2022-10-26  0:23 Mike Gilbert
2022-10-20 15:49 Mike Gilbert
2022-04-24 16:45 WANG Xuerui
2022-04-15  8:37 Sam James
2018-01-02  2:49 Mike Gilbert
2016-09-19 14:00 Mike Gilbert
2016-05-16 16:20 Brian Dolbec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1689392641.67e33dbaf367adfc465f322d0b6b5793c76207a8.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox