From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/
Date: Thu, 29 Jun 2023 08:22:57 +0000 (UTC) [thread overview]
Message-ID: <1688026973.59973d0f5829ebbae615a001a97abb652431a61b.sam@gentoo> (raw)
commit: 59973d0f5829ebbae615a001a97abb652431a61b
Author: Sheng Yu <syu.os <AT> protonmail <DOT> com>
AuthorDate: Sat Jun 24 20:28:20 2023 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Jun 29 08:22:53 2023 +0000
URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=59973d0f
gpkg: fix incorrect gpkg timestamp
[sam: Quoting dwfreed from the bug:
"utcnow() produces a naive datetime object, and most methods of datetime objects
treat naive datetime objects as local time."]
Bug: https://bugs.gentoo.org/909067
Signed-off-by: Sheng Yu <syu.os <AT> protonmail.com>
Closes: https://github.com/gentoo/portage/pull/1060
Signed-off-by: Sam James <sam <AT> gentoo.org>
lib/portage/gpkg.py | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/portage/gpkg.py b/lib/portage/gpkg.py
index 7451c68c2..6ed2a6d00 100644
--- a/lib/portage/gpkg.py
+++ b/lib/portage/gpkg.py
@@ -1012,7 +1012,7 @@ class gpkg:
gpkg_version_file = tarfile.TarInfo(
os.path.join(self.basename, self.gpkg_version)
)
- gpkg_version_file.mtime = datetime.utcnow().timestamp()
+ gpkg_version_file.mtime = datetime.now().timestamp()
container.addfile(gpkg_version_file)
checksum_info = checksum_helper(self.settings)
checksum_info.finish()
@@ -1032,7 +1032,7 @@ class gpkg:
checksum_info = checksum_helper(self.settings)
image_tarinfo = self._create_tarinfo("image")
- image_tarinfo.mtime = datetime.utcnow().timestamp()
+ image_tarinfo.mtime = datetime.now().timestamp()
with tar_stream_writer(
image_tarinfo, container, image_tar_format, compression_cmd, checksum_info
) as image_writer:
@@ -1114,7 +1114,7 @@ class gpkg:
gpkg_version_file = tarfile.TarInfo(
os.path.join(new_basename, self.gpkg_version)
)
- gpkg_version_file.mtime = datetime.utcnow().timestamp()
+ gpkg_version_file.mtime = datetime.now().timestamp()
container.addfile(gpkg_version_file)
checksum_info = checksum_helper(self.settings)
checksum_info.finish()
@@ -1182,7 +1182,7 @@ class gpkg:
gpkg_version_file = tarfile.TarInfo(
os.path.join(self.prefix, self.gpkg_version)
)
- gpkg_version_file.mtime = datetime.utcnow().timestamp()
+ gpkg_version_file.mtime = datetime.now().timestamp()
container.addfile(gpkg_version_file)
checksum_info = checksum_helper(self.settings)
checksum_info.finish()
@@ -1253,7 +1253,7 @@ class gpkg:
if metadata is None:
metadata = {}
metadata_tarinfo = self._create_tarinfo("metadata")
- metadata_tarinfo.mtime = datetime.utcnow().timestamp()
+ metadata_tarinfo.mtime = datetime.now().timestamp()
if self.create_signature:
checksum_info = checksum_helper(
@@ -1274,7 +1274,7 @@ class gpkg:
) as metadata_tar:
for m in metadata:
m_info = tarfile.TarInfo(os.path.join("metadata", m))
- m_info.mtime = datetime.utcnow().timestamp()
+ m_info.mtime = datetime.now().timestamp()
if isinstance(metadata[m], bytes):
m_data = io.BytesIO(metadata[m])
@@ -1329,7 +1329,7 @@ class gpkg:
gpkg_version_file = tarfile.TarInfo(
os.path.join(self.basename, self.gpkg_version)
)
- gpkg_version_file.mtime = datetime.utcnow().timestamp()
+ gpkg_version_file.mtime = datetime.now().timestamp()
container.addfile(gpkg_version_file)
checksum_info = checksum_helper(self.settings)
checksum_info.finish()
@@ -1350,7 +1350,7 @@ class gpkg:
paths = list(contents)
paths.sort()
image_tarinfo = self._create_tarinfo("image")
- image_tarinfo.mtime = datetime.utcnow().timestamp()
+ image_tarinfo.mtime = datetime.now().timestamp()
with tar_stream_writer(
image_tarinfo, container, image_tar_format, compression_cmd, checksum_info
) as image_writer:
@@ -1518,7 +1518,7 @@ class gpkg:
manifest_tarinfo = tarfile.TarInfo(os.path.join(basename, "Manifest"))
manifest_tarinfo.size = manifest.tell()
- manifest_tarinfo.mtime = datetime.utcnow().timestamp()
+ manifest_tarinfo.mtime = datetime.now().timestamp()
manifest.seek(0)
container.addfile(manifest_tarinfo, manifest)
manifest.close()
@@ -1562,7 +1562,7 @@ class gpkg:
signature = io.BytesIO(checksum_info.gpg_output)
signature_tarinfo = tarfile.TarInfo(f"{tarinfo.name}.sig")
signature_tarinfo.size = len(signature.getvalue())
- signature_tarinfo.mtime = datetime.utcnow().timestamp()
+ signature_tarinfo.mtime = datetime.now().timestamp()
container.addfile(signature_tarinfo, signature)
if manifest:
next reply other threads:[~2023-06-29 8:23 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 8:22 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-21 21:14 [gentoo-commits] proj/portage:master commit in: lib/portage/ Sam James
2025-01-11 16:01 Mike Gilbert
2025-01-11 16:01 Mike Gilbert
2025-01-01 0:33 Zac Medico
2024-11-02 22:12 Zac Medico
2024-11-02 15:48 Zac Medico
2024-11-02 15:48 Zac Medico
2024-09-09 18:08 Ulrich Müller
2024-09-09 18:08 Ulrich Müller
2024-08-14 15:22 Zac Medico
2024-06-09 17:54 Zac Medico
2024-06-02 18:28 Zac Medico
2024-04-26 22:06 Sam James
2024-04-26 22:06 Sam James
2024-02-28 16:01 Sam James
2024-02-28 15:52 Sam James
2024-02-28 15:49 Sam James
2024-02-25 8:25 Sam James
2024-02-24 20:10 Zac Medico
2024-02-21 2:08 Sam James
2024-02-21 2:08 Sam James
2024-02-12 7:58 Zac Medico
2024-02-11 19:57 Zac Medico
2024-02-10 6:09 Zac Medico
2024-02-10 6:06 Zac Medico
2024-02-09 8:51 Sam James
2024-02-09 7:08 Sam James
2024-02-07 2:35 Zac Medico
2024-02-07 2:35 Zac Medico
2024-02-05 1:03 Zac Medico
2024-02-05 1:03 Zac Medico
2024-01-29 17:49 Zac Medico
2024-01-29 16:09 Zac Medico
2023-12-26 23:15 Zac Medico
2023-11-02 14:58 Zac Medico
2023-10-24 21:26 Zac Medico
2023-10-24 1:48 Zac Medico
2023-10-03 15:07 Zac Medico
2023-10-02 2:10 Zac Medico
2023-09-26 5:53 Zac Medico
2023-09-08 20:36 Sam James
2023-09-08 19:49 Sam James
2023-08-24 18:23 Mike Gilbert
2023-08-02 6:31 Sam James
2023-07-29 3:57 Sam James
2023-03-21 2:30 Sam James
2023-03-21 2:30 Sam James
2023-03-21 2:30 Sam James
2023-03-21 2:30 Sam James
2023-03-21 2:30 Sam James
2023-03-21 2:30 Sam James
2023-02-27 6:15 Sam James
2023-02-17 1:23 Sam James
2023-01-02 5:25 Sam James
2022-11-02 22:58 Sam James
2022-11-02 22:58 Sam James
2022-09-29 21:37 Sam James
2022-09-29 20:45 Sam James
2022-09-28 23:56 Sam James
2022-09-26 17:52 Zac Medico
2022-09-20 19:45 Sam James
2022-09-20 3:39 Sam James
2022-09-18 18:30 Mike Gilbert
2022-08-01 22:39 Sam James
2022-08-01 17:34 Mike Gilbert
2022-07-19 21:39 Sam James
2022-07-18 18:47 Sam James
2022-07-11 23:02 Sam James
2022-07-10 15:07 Mike Gilbert
2022-07-05 22:56 Sam James
2022-06-05 20:25 Zac Medico
2022-04-11 12:11 Mike Gilbert
2022-04-11 12:11 Mike Gilbert
2022-04-09 4:32 Sam James
2022-04-04 19:04 Sam James
2022-04-04 19:04 Sam James
2022-04-04 19:04 Sam James
2022-04-04 19:04 Sam James
2022-04-04 19:04 Sam James
2022-04-04 19:04 Sam James
2022-04-04 19:04 Sam James
2022-04-04 19:04 Sam James
2022-04-01 20:30 Matt Turner
2022-03-30 23:11 Sam James
2022-03-28 1:10 Sam James
2022-03-27 23:07 Sam James
2022-03-27 23:07 Sam James
2022-03-27 23:07 Sam James
2022-03-27 23:07 Sam James
2022-03-27 23:07 Sam James
2022-03-15 2:52 Matt Turner
2022-02-09 11:13 Sam James
2021-09-20 20:06 Zac Medico
2021-09-20 19:55 Mike Gilbert
2021-09-07 7:04 Michał Górny
2021-09-04 11:53 Michał Górny
2021-05-24 6:08 Zac Medico
2021-05-24 4:55 Zac Medico
2021-03-28 3:33 Zac Medico
2021-03-11 12:32 Zac Medico
2021-03-07 14:03 Zac Medico
2021-03-06 9:18 Zac Medico
2021-03-06 9:05 Zac Medico
2021-03-06 9:05 Zac Medico
2021-03-06 8:20 Zac Medico
2021-03-06 6:16 Zac Medico
2021-02-08 4:55 Zac Medico
2020-09-11 19:02 Zac Medico
2020-08-04 1:39 Zac Medico
2020-08-03 23:28 Zac Medico
2020-08-03 23:28 Zac Medico
2020-08-03 19:30 Zac Medico
2020-08-03 19:30 Zac Medico
2020-08-03 19:30 Zac Medico
2020-08-03 19:30 Zac Medico
2020-06-27 19:46 Zac Medico
2020-06-09 0:58 Zac Medico
2020-05-17 9:37 Michał Górny
2020-05-07 20:35 Zac Medico
2020-04-20 21:16 Mike Gilbert
2020-03-28 18:57 Michał Górny
2020-03-25 19:18 Zac Medico
2020-03-25 7:57 Zac Medico
2020-03-25 7:57 Zac Medico
2020-02-04 6:43 Zac Medico
2020-02-02 9:00 Zac Medico
2019-12-15 23:04 Zac Medico
2019-11-12 22:25 Zac Medico
2019-09-17 2:59 Zac Medico
2019-09-07 6:40 Zac Medico
2019-08-18 22:15 Zac Medico
2019-08-04 18:03 Zac Medico
2019-08-02 20:03 Mike Gilbert
2019-08-01 19:02 Mike Gilbert
2019-05-28 1:49 Zac Medico
2019-04-27 19:20 Zac Medico
2019-02-20 0:58 Zac Medico
2019-02-20 0:58 Zac Medico
2019-02-20 0:58 Zac Medico
2019-02-18 1:01 Zac Medico
2019-02-11 19:46 Zac Medico
2019-01-04 3:49 Zac Medico
2018-12-31 5:27 Zac Medico
2018-12-04 1:35 Zac Medico
2018-11-25 0:03 Zac Medico
2018-11-24 21:34 Zac Medico
2018-08-07 18:36 Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1688026973.59973d0f5829ebbae615a001a97abb652431a61b.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox