From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7344C15810F for ; Sat, 10 Jun 2023 07:23:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 817FAE0934; Sat, 10 Jun 2023 07:23:18 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6951EE0934 for ; Sat, 10 Jun 2023 07:23:18 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 8E498341147 for ; Sat, 10 Jun 2023 07:23:17 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id EE8DEA53 for ; Sat, 10 Jun 2023 07:23:15 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1686381349.3f62d58dbb7fcb4ddaf14f7216110eebe9bd0b3e.sam@gentoo> Subject: [gentoo-commits] proj/gentoo-functions:master commit in: / X-VCS-Repository: proj/gentoo-functions X-VCS-Files: functions.sh.in X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 3f62d58dbb7fcb4ddaf14f7216110eebe9bd0b3e X-VCS-Branch: master Date: Sat, 10 Jun 2023 07:23:15 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: b111f182-8af7-4f84-bf6b-5017494123d0 X-Archives-Hash: b9f988a37656f7a213f693efea7f64d5 commit: 3f62d58dbb7fcb4ddaf14f7216110eebe9bd0b3e Author: Kerin Millar plushkava net> AuthorDate: Sat Jun 10 07:03:07 2023 +0000 Commit: Sam James gentoo org> CommitDate: Sat Jun 10 07:15:49 2023 +0000 URL: https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=3f62d58d Ensure that ebegin() appends a newline to the final message The ebegin() function was recently modified to strip the trailing , if any, from the given message. Later, it was modified to strip all trailing characters. The purpose of doing so is to ensure that there is no accidental line breaking betwixt the message and the ASCII ellipsis that is appended. However, the function should then have been appending a single to the composed message before handing it off to _eprint(). Make it so. Signed-off-by: Kerin Millar plushkava.net> Fixes: 1947f0ed81f3b95a7e10a8a5a707776948f8a487 functions.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/functions.sh.in b/functions.sh.in index 76f1ad4..0c3e7ba 100644 --- a/functions.sh.in +++ b/functions.sh.in @@ -243,7 +243,7 @@ ebegin() while _ends_with_newline "${msg}"; do msg=${msg%"${genfun_newline}"} done - _eprint "${GOOD}" "${msg} ..." + _eprint "${GOOD}" "${msg} ...${genfun_newline}" fi }