From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BF55B15ACFB for ; Fri, 21 Apr 2023 19:11:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C16ABE09CD; Fri, 21 Apr 2023 19:11:14 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9D788E09CD for ; Fri, 21 Apr 2023 19:11:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 8B14033E830 for ; Fri, 21 Apr 2023 19:11:13 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id F40CD141 for ; Fri, 21 Apr 2023 19:11:10 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1682104145.e322a78cbfd6d51aefe26425dff1cb99c3d307bc.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: libq/ X-VCS-Repository: proj/portage-utils X-VCS-Files: libq/tree.c X-VCS-Directories: libq/ X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: e322a78cbfd6d51aefe26425dff1cb99c3d307bc X-VCS-Branch: master Date: Fri, 21 Apr 2023 19:11:10 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 0d04ad05-fb34-429b-ba49-ef753c94df46 X-Archives-Hash: 99ace1cffce8e0b3cde6341b58805de2 commit: e322a78cbfd6d51aefe26425dff1cb99c3d307bc Author: Fabian Groffen gentoo org> AuthorDate: Fri Apr 21 19:09:05 2023 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Fri Apr 21 19:09:05 2023 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=e322a78c libq/tree: add commetns on file checks (research for bug #898194) Signed-off-by: Fabian Groffen gentoo.org> libq/tree.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/libq/tree.c b/libq/tree.c index f308c8d..1922b7d 100644 --- a/libq/tree.c +++ b/libq/tree.c @@ -1109,8 +1109,17 @@ tree_pkg_read(tree_pkg_ctx *pkg_ctx) if (ctx->cachetype == CACHE_METADATA_MD5) { ret = tree_read_file_md5(pkg_ctx); + /* md5-cache, is sort of documented in egencache man-page + * key-points are that an md5 is provided for the ebuild itself, + * and if it includes eclasses, the md5s for each eclass. These + * are available as _md5_ and _eclasses_ keys. The latter uses + * tab-separation of form \t\t... */ } else if (ctx->cachetype == CACHE_METADATA_PMS) { ret = tree_read_file_pms(pkg_ctx); + /* PMS implies to do an mtime and existence check (the cache may + * contain extra stuff) but since this form of metadata in fact + * is extinct, because these checks are insufficient and + * impossible on e.g. a git-based tree. */ } else if (ctx->cachetype == CACHE_EBUILD) { ret = tree_read_file_ebuild(pkg_ctx); } else if (ctx->cachetype == CACHE_BINPKGS) {