* [gentoo-commits] proj/kde:master commit in: kde-apps/kio-extras/, kde-apps/kio-extras/files/
@ 2017-01-15 20:10 Andreas Sturmlechner
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Sturmlechner @ 2017-01-15 20:10 UTC (permalink / raw
To: gentoo-commits
commit: 9c14167df269d12147b428deb815efc3dc33caed
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Sat Jan 7 01:04:46 2017 +0000
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Sun Jan 15 20:07:55 2017 +0000
URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=9c14167d
kde-apps/kio-extras: Add USE=activities,man, fix DEPENDs
Package-Manager: portage-2.3.0
| 52 ++++++++++++++++++++++
| 48 ++++++++++++++++++++
| 21 ++++++---
| 17 ++++---
| 2 +
5 files changed, 128 insertions(+), 12 deletions(-)
--git a/kde-apps/kio-extras/files/kio-extras-16.12.1-activities-optional.patch b/kde-apps/kio-extras/files/kio-extras-16.12.1-activities-optional.patch
new file mode 100644
index 0000000..efa79a9
--- /dev/null
+++ b/kde-apps/kio-extras/files/kio-extras-16.12.1-activities-optional.patch
@@ -0,0 +1,52 @@
+From a84100dce8a32de89c6a854c965c0c54f1126563 Mon Sep 17 00:00:00 2001
+From: Andreas Sturmlechner <andreas.sturmlechner@gmail.com>
+Date: Mon, 2 Jan 2017 02:16:40 +0100
+Subject: [PATCH 1/2] Make activities kioslave optional
+
+Not everyone builds this for a Plasma desktop, Qt5Sql is already only
+searched for in that subdirectory, so this gives some nice modularity.
+
+REVIEW: 129783
+---
+ CMakeLists.txt | 11 +++++++++--
+ 1 file changed, 9 insertions(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index edc2639..5ac418b 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -39,7 +39,6 @@ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
+ Solid
+ Bookmarks
+ GuiAddons
+- Activities
+ )
+ # As this is the check used for linkage, only require it in the same location...
+ if (UNIX)
+@@ -56,6 +55,12 @@ include(ECMOptionalAddSubdirectory)
+
+ add_definitions(-DQT_NO_URL_CAST_FROM_STRING)
+
++find_package(KF5Activities QUIET)
++set_package_properties(KF5Activities PROPERTIES
++ PURPOSE "Provides the activities:/ kioslave and fileitem plugin."
++ TYPE OPTIONAL
++)
++
+ find_package(SLP)
+ set_package_properties(SLP PROPERTIES DESCRIPTION "SLP (Service Location Protocol) implementation"
+ URL "http://www.openslp.org/"
+@@ -126,7 +131,9 @@ endif()
+ add_subdirectory( doc )
+
+ add_subdirectory( about )
+-add_subdirectory( activities )
++if(KF5Activities_FOUND)
++ add_subdirectory( activities )
++endif()
+ add_subdirectory( bookmarks )
+ add_subdirectory( filter )
+ if(Phonon4Qt5_FOUND)
+--
+2.10.2
+
--git a/kde-apps/kio-extras/files/kio-extras-16.12.1-man-optional.patch b/kde-apps/kio-extras/files/kio-extras-16.12.1-man-optional.patch
new file mode 100644
index 0000000..9c6452b
--- /dev/null
+++ b/kde-apps/kio-extras/files/kio-extras-16.12.1-man-optional.patch
@@ -0,0 +1,48 @@
+From c9f618e75f4d84a8c48cb321a477c68c6dbf9f08 Mon Sep 17 00:00:00 2001
+From: Andreas Sturmlechner <andreas.sturmlechner@gmail.com>
+Date: Mon, 2 Jan 2017 02:35:08 +0100
+Subject: [PATCH 2/2] Make KF5KHtml dependency optional, only used by man
+
+REVIEW: 129783
+---
+ CMakeLists.txt | 10 ++++++++--
+ 1 file changed, 8 insertions(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 5ac418b..7de37ea 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -34,7 +34,6 @@ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
+ IconThemes
+ I18n
+ KIO
+- KHtml
+ KDELibs4Support
+ Solid
+ Bookmarks
+@@ -124,6 +123,11 @@ if(UNIX)
+ if(NOT OFFT_IS_64BIT)
+ message(FATAL_ERROR "Large file support is not enabled.")
+ endif()
++
++ find_package(KF5KHtml QUIET)
++ set_package_properties(KF5KHtml PROPERTIES TYPE OPTIONAL
++ PURPOSE "Needed to build the man kioslave"
++ )
+ else()
+ # FIXME: on windows we ignore support until trash gets integrated
+ endif()
+@@ -158,7 +162,9 @@ if (MTP_FOUND)
+ endif()
+
+ if(NOT WIN32)
+- add_subdirectory( man )
++ if(KF5KHtml_FOUND)
++ add_subdirectory( man )
++ endif()
+ check_include_files(rpc/rpc.h HAVE_RPC_RPC_H)
+ add_feature_info("NFS kioslave" HAVE_RPC_RPC_H "The RPC library is needed to build the NFS kioslave")
+ if(HAVE_RPC_RPC_H)
+--
+2.10.2
+
--git a/kde-apps/kio-extras/kio-extras-16.12.49.9999.ebuild b/kde-apps/kio-extras/kio-extras-16.12.49.9999.ebuild
index c9136a0..9bd4ad6 100644
--- a/kde-apps/kio-extras/kio-extras-16.12.49.9999.ebuild
+++ b/kde-apps/kio-extras/kio-extras-16.12.49.9999.ebuild
@@ -13,10 +13,9 @@ inherit kde5
DESCRIPTION="KIO plugins present a filesystem-like view of arbitrary data"
HOMEPAGE="https://projects.kde.org/projects/kde/workspace/kio-extras"
KEYWORDS=""
-IUSE="exif htmlthumbs mtp openexr phonon samba +sftp slp"
+IUSE="activities exif htmlthumbs +man mtp openexr phonon samba +sftp slp"
COMMON_DEPEND="
- $(add_frameworks_dep kactivities)
$(add_frameworks_dep karchive 'bzip2,lzma')
$(add_frameworks_dep kbookmarks)
$(add_frameworks_dep kcodecs)
@@ -27,7 +26,6 @@ COMMON_DEPEND="
$(add_frameworks_dep kdelibs4support)
$(add_frameworks_dep kdnssd)
$(add_frameworks_dep kguiaddons)
- $(add_frameworks_dep khtml)
$(add_frameworks_dep ki18n)
$(add_frameworks_dep kiconthemes)
$(add_frameworks_dep kio)
@@ -39,18 +37,22 @@ COMMON_DEPEND="
$(add_qt_dep qtdbus)
$(add_qt_dep qtgui)
$(add_qt_dep qtnetwork)
- $(add_qt_dep qtsql)
$(add_qt_dep qtsvg)
$(add_qt_dep qtwidgets)
$(add_qt_dep qtxml)
virtual/jpeg:0
+ activities? (
+ $(add_frameworks_dep kactivities)
+ $(add_qt_dep qtsql)
+ )
exif? ( media-gfx/exiv2:= )
htmlthumbs? ( $(add_qt_dep qtwebengine) )
+ man? ( $(add_frameworks_dep khtml) )
mtp? ( media-libs/libmtp:= )
openexr? ( media-libs/openexr )
phonon? ( media-libs/phonon[qt5] )
- samba? ( || ( <net-fs/samba-4.0.0_alpha1[smbclient] >=net-fs/samba-4.0.0_alpha1[client] ) )
- sftp? ( >=net-libs/libssh-0.6.0:=[sftp] )
+ samba? ( net-fs/samba[client] )
+ sftp? ( net-libs/libssh:=[sftp] )
slp? ( net-libs/openslp )
"
RDEPEND="${COMMON_DEPEND}
@@ -63,10 +65,17 @@ DEPEND="${COMMON_DEPEND}
# requires running kde environment
RESTRICT+=" test"
+PATCHES=(
+ "${FILESDIR}/${PN}"-16.12.1-activities-optional.patch
+ "${FILESDIR}/${PN}"-16.12.1-man-optional.patch
+)
+
src_configure() {
local mycmakeargs=(
+ $(cmake-utils_use_find_package activities KF5Activities)
$(cmake-utils_use_find_package exif Exiv2)
$(cmake-utils_use_find_package htmlthumbs Qt5WebEngineWidgets)
+ $(cmake-utils_use_find_package man KF5KHtml)
$(cmake-utils_use_find_package mtp Mtp)
$(cmake-utils_use_find_package openexr OpenEXR)
$(cmake-utils_use_find_package phonon Phonon4Qt5)
--git a/kde-apps/kio-extras/kio-extras-9999.ebuild b/kde-apps/kio-extras/kio-extras-9999.ebuild
index c9136a0..b756157 100644
--- a/kde-apps/kio-extras/kio-extras-9999.ebuild
+++ b/kde-apps/kio-extras/kio-extras-9999.ebuild
@@ -13,10 +13,9 @@ inherit kde5
DESCRIPTION="KIO plugins present a filesystem-like view of arbitrary data"
HOMEPAGE="https://projects.kde.org/projects/kde/workspace/kio-extras"
KEYWORDS=""
-IUSE="exif htmlthumbs mtp openexr phonon samba +sftp slp"
+IUSE="activities exif htmlthumbs +man mtp openexr phonon samba +sftp slp"
COMMON_DEPEND="
- $(add_frameworks_dep kactivities)
$(add_frameworks_dep karchive 'bzip2,lzma')
$(add_frameworks_dep kbookmarks)
$(add_frameworks_dep kcodecs)
@@ -27,7 +26,6 @@ COMMON_DEPEND="
$(add_frameworks_dep kdelibs4support)
$(add_frameworks_dep kdnssd)
$(add_frameworks_dep kguiaddons)
- $(add_frameworks_dep khtml)
$(add_frameworks_dep ki18n)
$(add_frameworks_dep kiconthemes)
$(add_frameworks_dep kio)
@@ -39,18 +37,22 @@ COMMON_DEPEND="
$(add_qt_dep qtdbus)
$(add_qt_dep qtgui)
$(add_qt_dep qtnetwork)
- $(add_qt_dep qtsql)
$(add_qt_dep qtsvg)
$(add_qt_dep qtwidgets)
$(add_qt_dep qtxml)
virtual/jpeg:0
+ activities? (
+ $(add_frameworks_dep kactivities)
+ $(add_qt_dep qtsql)
+ )
exif? ( media-gfx/exiv2:= )
htmlthumbs? ( $(add_qt_dep qtwebengine) )
+ man? ( $(add_frameworks_dep khtml) )
mtp? ( media-libs/libmtp:= )
openexr? ( media-libs/openexr )
phonon? ( media-libs/phonon[qt5] )
- samba? ( || ( <net-fs/samba-4.0.0_alpha1[smbclient] >=net-fs/samba-4.0.0_alpha1[client] ) )
- sftp? ( >=net-libs/libssh-0.6.0:=[sftp] )
+ samba? ( net-fs/samba[client] )
+ sftp? ( net-libs/libssh:=[sftp] )
slp? ( net-libs/openslp )
"
RDEPEND="${COMMON_DEPEND}
@@ -58,6 +60,7 @@ RDEPEND="${COMMON_DEPEND}
"
DEPEND="${COMMON_DEPEND}
x11-misc/shared-mime-info
+ man? ( dev-util/gperf )
"
# requires running kde environment
@@ -65,8 +68,10 @@ RESTRICT+=" test"
src_configure() {
local mycmakeargs=(
+ $(cmake-utils_use_find_package activities KF5Activities)
$(cmake-utils_use_find_package exif Exiv2)
$(cmake-utils_use_find_package htmlthumbs Qt5WebEngineWidgets)
+ $(cmake-utils_use_find_package man Gperf)
$(cmake-utils_use_find_package mtp Mtp)
$(cmake-utils_use_find_package openexr OpenEXR)
$(cmake-utils_use_find_package phonon Phonon4Qt5)
--git a/kde-apps/kio-extras/metadata.xml b/kde-apps/kio-extras/metadata.xml
index 75cdaad..c32c832 100644
--- a/kde-apps/kio-extras/metadata.xml
+++ b/kde-apps/kio-extras/metadata.xml
@@ -6,7 +6,9 @@
<name>Gentoo KDE Project</name>
</maintainer>
<use>
+ <flag name="activities">Enable activities kioslave and fileitem plugin</flag>
<flag name="htmlthumbs">Enable HTML thumbnail previews via <pkg>dev-qt/qtwebengine</pkg></flag>
+ <flag name="man">Enable manpages kioslave</flag>
<flag name="phonon">Enable file audio preview plugin using <pkg>media-libs/phonon</pkg></flag>
<flag name="sftp">Enable SFTP protocol support using <pkg>net-libs/libssh</pkg></flag>
</use>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [gentoo-commits] proj/kde:master commit in: kde-apps/kio-extras/, kde-apps/kio-extras/files/
@ 2023-04-20 21:15 Andreas Sturmlechner
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Sturmlechner @ 2023-04-20 21:15 UTC (permalink / raw
To: gentoo-commits
commit: 8e90d659f60262832fd42bf96060b48867853eb1
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Thu Apr 20 21:14:48 2023 +0000
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Thu Apr 20 21:15:16 2023 +0000
URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=8e90d659
kde-apps/kio-extras: Fix build w/o Qt5Test
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
| 42 ++++++++++++++++++++++
| 3 ++
| 3 ++
3 files changed, 48 insertions(+)
--git a/kde-apps/kio-extras/files/kio-extras-23.04.0-tests-optional.patch b/kde-apps/kio-extras/files/kio-extras-23.04.0-tests-optional.patch
new file mode 100644
index 0000000000..7c4b740128
--- /dev/null
+++ b/kde-apps/kio-extras/files/kio-extras-23.04.0-tests-optional.patch
@@ -0,0 +1,42 @@
+From 02c9f3cb6d095c50930c223eaeb86c45fdcc42da Mon Sep 17 00:00:00 2001
+From: Andreas Sturmlechner <asturm@gentoo.org>
+Date: Thu, 20 Apr 2023 23:11:02 +0200
+Subject: [PATCH] Follow precedence that tests are built conditionally
+
+Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
+---
+ activities/CMakeLists.txt | 4 +++-
+ smb/CMakeLists.txt | 4 +++-
+ 2 files changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/activities/CMakeLists.txt b/activities/CMakeLists.txt
+index 57756ad65..81749cacf 100644
+--- a/activities/CMakeLists.txt
++++ b/activities/CMakeLists.txt
+@@ -56,7 +56,9 @@ target_link_libraries(
+ Qt::Network
+ )
+
+-add_subdirectory(autotests)
++if (BUILD_TESTING)
++ add_subdirectory(autotests)
++endif()
+
+ # install target (typical /usr/lib64/qtX/plugins/kf5/kio)
+ install(
+diff --git a/smb/CMakeLists.txt b/smb/CMakeLists.txt
+index 66ed5b4ad..1ecf0e66d 100644
+--- a/smb/CMakeLists.txt
++++ b/smb/CMakeLists.txt
+@@ -117,5 +117,7 @@ if(WITH_SHAREDMIMEINFO)
+ update_xdg_mimetypes(${KDE_INSTALL_MIMEDIR})
+ endif()
+
+-add_subdirectory(autotests)
++if (BUILD_TESTING)
++ add_subdirectory(autotests)
++endif()
+ add_subdirectory(kded)
+--
+2.40.0
+
--git a/kde-apps/kio-extras/kio-extras-23.04.0.ebuild b/kde-apps/kio-extras/kio-extras-23.04.0.ebuild
index 129dfcade4..53dc2f72af 100644
--- a/kde-apps/kio-extras/kio-extras-23.04.0.ebuild
+++ b/kde-apps/kio-extras/kio-extras-23.04.0.ebuild
@@ -75,6 +75,9 @@ RDEPEND="${DEPEND}
"
BDEPEND="man? ( dev-util/gperf )"
+# https://invent.kde.org/network/kio-extras/-/merge_requests/236
+PATCHES=( "${FILESDIR}/${P}-tests-optional.patch" )
+
src_configure() {
local mycmakeargs=(
$(cmake_use_find_package activities KF5Activities)
--git a/kde-apps/kio-extras/kio-extras-23.04.49.9999.ebuild b/kde-apps/kio-extras/kio-extras-23.04.49.9999.ebuild
index 93591179d0..eda5f6e33d 100644
--- a/kde-apps/kio-extras/kio-extras-23.04.49.9999.ebuild
+++ b/kde-apps/kio-extras/kio-extras-23.04.49.9999.ebuild
@@ -75,6 +75,9 @@ RDEPEND="${DEPEND}
"
BDEPEND="man? ( dev-util/gperf )"
+# https://invent.kde.org/network/kio-extras/-/merge_requests/236
+PATCHES=( "${FILESDIR}/${PN}-23.04.0-tests-optional.patch" )
+
src_configure() {
local mycmakeargs=(
$(cmake_use_find_package activities KF5Activities)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-20 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-20 21:15 [gentoo-commits] proj/kde:master commit in: kde-apps/kio-extras/, kde-apps/kio-extras/files/ Andreas Sturmlechner
-- strict thread matches above, loose matches on Subject: below --
2017-01-15 20:10 Andreas Sturmlechner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox