public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gcc-patches:master commit in: 13.1.0/gentoo/
Date: Mon, 13 Mar 2023 22:28:54 +0000 (UTC)	[thread overview]
Message-ID: <1678744251.b37b9b3a61f788973ae156a1fcddd0d108879a7b.sam@gentoo> (raw)

commit:     b37b9b3a61f788973ae156a1fcddd0d108879a7b
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Mar 13 21:49:45 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Mar 13 21:50:51 2023 +0000
URL:        https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=b37b9b3a

13.1.0: don't set _FORTIFY_SOURCE if -fsanitize=address (ASAN) is enabled

This can cause either false positives in warnings from the compiler or false
negatives where the sanitizer misses something.

Bug: https://github.com/google/sanitizers/issues/247
Signed-off-by: Sam James <sam <AT> gentoo.org>

 13.1.0/gentoo/01_all_default-fortify-source.patch | 4 ++--
 13.1.0/gentoo/README.history                      | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/13.1.0/gentoo/01_all_default-fortify-source.patch b/13.1.0/gentoo/01_all_default-fortify-source.patch
index 79d6639..4cdf5f6 100644
--- a/13.1.0/gentoo/01_all_default-fortify-source.patch
+++ b/13.1.0/gentoo/01_all_default-fortify-source.patch
@@ -16,8 +16,8 @@ initially Gentoo used too complicated macro.
 +    #define GENTOO_FORTIFY_SOURCE_LEVEL 2
 +  #endif
 +
-+  /* Fortify Source enabled by default for optimization levels > 0 */
-+  if (optimize)
++  /* F_S enabled by default for optimization levels > 0, except for ASAN: https://github.com/google/sanitizers/issues/247 */
++  if (optimize && ! (flag_sanitize & SANITIZE_ADDRESS))
 +    builtin_define_with_int_value ("_FORTIFY_SOURCE", GENTOO_FORTIFY_SOURCE_LEVEL);
 +#endif
 +

diff --git a/13.1.0/gentoo/README.history b/13.1.0/gentoo/README.history
index f0ee005..efcdcf7 100644
--- a/13.1.0/gentoo/README.history
+++ b/13.1.0/gentoo/README.history
@@ -1,3 +1,6 @@
+9	13 Mar 2023
+	U 01_all_default-fortify-source.patch
+
 8	12 Feb 2023
 	- 76_all_all_PR107461_cxx_equivalence_non_dependent_calls.patch
 


             reply	other threads:[~2023-03-13 22:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 22:28 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-04-23  2:41 [gentoo-commits] proj/gcc-patches:master commit in: 13.1.0/gentoo/ Sam James
2023-04-23  2:41 Sam James
2023-02-12 23:18 Sam James
2023-02-06 18:36 Sam James
2023-02-06 17:40 Sam James
2023-01-30  4:21 Sam James
2022-12-17  4:54 Sam James
2022-11-29 13:21 David Seifert
2022-11-28 22:38 Andreas K. Hüttel
2022-11-02 17:07 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1678744251.b37b9b3a61f788973ae156a1fcddd0d108879a7b.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox