From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7E86E15800F for ; Mon, 13 Feb 2023 21:37:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BDC1FE07EA; Mon, 13 Feb 2023 21:37:28 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A58D0E07EE for ; Mon, 13 Feb 2023 21:37:28 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D7B4C340B9C for ; Mon, 13 Feb 2023 21:37:27 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id CA5778B4 for ; Mon, 13 Feb 2023 21:37:24 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1676324177.d21e27f228a99a0f4c2ed2d534fa5cc8040212f6.sam@gentoo> Subject: [gentoo-commits] proj/gentoo-functions:master commit in: / X-VCS-Repository: proj/gentoo-functions X-VCS-Files: functions.sh X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: d21e27f228a99a0f4c2ed2d534fa5cc8040212f6 X-VCS-Branch: master Date: Mon, 13 Feb 2023 21:37:24 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: c28d6a98-289d-461c-8915-0beebc13058d X-Archives-Hash: c248e838a26e461d04efd1189246ec92 commit: d21e27f228a99a0f4c2ed2d534fa5cc8040212f6 Author: Kerin Millar plushkava net> AuthorDate: Mon Feb 13 05:55:59 2023 +0000 Commit: Sam James gentoo org> CommitDate: Mon Feb 13 21:36:17 2023 +0000 URL: https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=d21e27f2 Return the correct exit status from _eend() where EINFO_QUIET is enabled For EINFO_QUIET to be in effect is not a valid pretext for returning 0. This bug is as old as the repository itself. Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> functions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/functions.sh b/functions.sh index 26a4d7a..51c6dbd 100644 --- a/functions.sh +++ b/functions.sh @@ -263,7 +263,7 @@ _eend() fi msg="${BRACKET}[ ${BAD}!!${BRACKET} ]${NORMAL}" elif yesno "${EINFO_QUIET}"; then - return 0 + return "${retval}" else msg="${BRACKET}[ ${GOOD}ok${BRACKET} ]${NORMAL}" fi