[gentoo-commits] repo/gentoo:master commit in: games-emulation/pcsx2/

["Ionen Wolkens" <ionen@gentoo.org>]

commit:     0ee6e8f7f063044c104a431bfdc7b9cdc3f577e2
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Mon Jan  2 10:28:21 2023 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Mon Jan  2 11:05:23 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ee6e8f7

games-emulation/pcsx2: add comment about upstream

May be useful to know for anyone working on this.

Upstream doesn't seem to want to hear of non-appimage issues.
They also dislike that we do workarounds for these issues and
wants it pristine (no patch/sed, even tiny changes like changing
the path to find resources in /usr/share given been seemingly
refusing to add a cmake option to change it) and using bundled libs.

Hopefully may change if it gets a dedicated linux contributor, as
there's currently none and it's at most just drive-by PRs which
don't get maintained and eventually break.

Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 games-emulation/pcsx2/pcsx2-9999.ebuild | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/games-emulation/pcsx2/pcsx2-9999.ebuild b/games-emulation/pcsx2/pcsx2-9999.ebuild
index b9d68d63b68b..e2f804a6b008 100644
--- a/games-emulation/pcsx2/pcsx2-9999.ebuild
+++ b/games-emulation/pcsx2/pcsx2-9999.ebuild
@@ -161,13 +161,17 @@ src_configure() {
 		-DDISABLE_BUILD_DATE=yes
 		-DDISABLE_SETCAP=yes
 		-DENABLE_TESTS=$(usex test)
-		-DUSE_SYSTEM_LIBS=yes
 		-DUSE_VTUNE=no
 		-DUSE_VULKAN=$(usex vulkan)
 		-DWAYLAND_API=$(usex wayland)
 		-DX11_API=yes # fails if X libs are missing even if disabled
 		-DXDG_STD=yes
 
+		# note that the current upstream is somewhat hostile to using system
+		# libs, system installs, or any modifications and may disregard any
+		# bugs that is not reproducible with the appimage using bundled libs
+		-DUSE_SYSTEM_LIBS=yes
+
 		# sse4.1 is the bare minimum required, -m is required at build time
 		# (see PCSX2Base.h) and it dies if no support at runtime (AppInit.cpp)
 		# https://github.com/PCSX2/pcsx2/pull/4329
@@ -189,7 +193,6 @@ src_test() {
 }
 
 src_install() {
-	# package mode was removed turning cmake_src_install into a noop
 	newbin "${BUILD_DIR}"/pcsx2-qt/pcsx2-qt ${PN}
 
 	insinto /usr/share/${PN}