public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ionen Wolkens" <ionen@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-eselect/eselect-wine/
Date: Thu, 29 Dec 2022 20:29:34 +0000 (UTC)	[thread overview]
Message-ID: <1672345733.ac00dfecda10fa71c1181703173c0a8e9eda3a86.ionen@gentoo> (raw)

commit:     ac00dfecda10fa71c1181703173c0a8e9eda3a86
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Mon Dec 19 07:49:06 2022 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Thu Dec 29 20:28:53 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac00dfec

app-eselect/eselect-wine: cleanup collision messages

The new app-alternatives/* cause similar issues and eselect-wine isn't
unusual enough to need this special handling, portage-3.0.41 is also
now stable and gives nicer messages.

Majority of people will have migrated by now too.

Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 app-eselect/eselect-wine/eselect-wine-2.0.2.ebuild | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/app-eselect/eselect-wine/eselect-wine-2.0.2.ebuild b/app-eselect/eselect-wine/eselect-wine-2.0.2.ebuild
index 87e5f10d2eaf..953f7e1c910d 100644
--- a/app-eselect/eselect-wine/eselect-wine-2.0.2.ebuild
+++ b/app-eselect/eselect-wine/eselect-wine-2.0.2.ebuild
@@ -17,20 +17,6 @@ RDEPEND="
 	app-admin/eselect
 	xdg? ( x11-misc/xdg-utils )"
 
-pkg_pretend() {
-	# /usr/bin/wine and /usr/include/wine are removed by pkg_preinst's unset,
-	# but portage currently checks collisions and errors out /before/ preinst
-	if has_version '<app-eselect/eselect-wine-2' &&
-		has collision-protect ${FEATURES}
-	then
-		eerror
-		eerror "!Warning! will likely need to either disable FEATURES=collision-protect or"
-		eerror "delete ${EROOT}/usr/bin/wine and ${EROOT}/usr/include/wine to merge ${P}"
-		eerror "(these files should be orphaned, so default FEATURES=protect-owned is fine)"
-		eerror
-	fi
-}
-
 src_install() {
 	insinto /usr/share/eselect/modules
 	doins wine.eselect
@@ -83,10 +69,8 @@ pkg_postinst() {
 	if [[ ! ${REPLACING_VERSIONS##* } ]] ||
 		ver_test ${REPLACING_VERSIONS##* } -lt 2; then
 		elog
-		if [[ ${REPLACING_VERSIONS} ]]; then
+		[[ ${REPLACING_VERSIONS} ]] &&
 			elog "${PN} changed a bit, suggest reviewing 'eselect wine help' (and list)."
-			elog "Note: if seen bin/wine or include/wine merge collisions, they are harmless."
-		fi
 		elog "Please run '. ${EROOT}/etc/profile' to update PATH in current shells."
 	fi
 }


             reply	other threads:[~2022-12-29 20:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 20:29 Ionen Wolkens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-14  8:00 [gentoo-commits] repo/gentoo:master commit in: app-eselect/eselect-wine/ Ionen Wolkens
2024-07-25 21:49 Ionen Wolkens
2023-08-23 15:41 Ionen Wolkens
2023-08-23 15:41 Ionen Wolkens
2023-08-06  4:32 Ionen Wolkens
2023-07-30 19:29 Ionen Wolkens
2023-07-30 16:18 Ionen Wolkens
2023-03-03  5:26 Ionen Wolkens
2022-12-05 20:46 Ionen Wolkens
2022-12-03 22:40 Ionen Wolkens
2022-12-03 14:08 Ionen Wolkens
2022-12-03 13:52 Ionen Wolkens
2022-12-03  1:03 Ionen Wolkens
2022-12-02  3:18 Ionen Wolkens
2022-12-02  3:18 Ionen Wolkens
2022-11-29  0:27 Ionen Wolkens
2022-11-23 20:39 Ionen Wolkens
2022-11-23 20:39 Ionen Wolkens
2022-11-20 17:12 Ionen Wolkens
2022-11-17  7:53 Ionen Wolkens
2022-11-16 17:01 Ionen Wolkens
2022-11-16 15:02 Ionen Wolkens
2022-10-12 13:47 Ionen Wolkens
2022-10-12 13:47 Ionen Wolkens
2022-10-12 13:47 Ionen Wolkens
2022-08-11 18:41 Nick Sarnie
2022-07-24  8:26 Joonas Niilola
2021-02-07  1:43 Sam James
2017-09-29  3:07 NP Hardass
2017-09-28 22:32 NP Hardass
2017-09-15  6:10 NP Hardass
2017-09-15  6:01 NP Hardass
2017-09-13 23:54 NP Hardass
2017-08-07 14:10 NP Hardass
2017-04-12  1:37 NP Hardass
2017-04-11  6:03 NP Hardass
2017-04-10 17:22 NP Hardass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1672345733.ac00dfecda10fa71c1181703173c0a8e9eda3a86.ionen@gentoo \
    --to=ionen@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox