public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Marc Schiffbauer" <mschiff@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-backup/bareos/files/
Date: Sat, 10 Dec 2022 18:31:53 +0000 (UTC)	[thread overview]
Message-ID: <1670697095.36e288262d4a9993fe3528ca913f174cdd4de0f3.mschiff@gentoo> (raw)

commit:     36e288262d4a9993fe3528ca913f174cdd4de0f3
Author:     Marc Schiffbauer <mschiff <AT> gentoo <DOT> org>
AuthorDate: Sat Dec 10 18:30:19 2022 +0000
Commit:     Marc Schiffbauer <mschiff <AT> gentoo <DOT> org>
CommitDate: Sat Dec 10 18:31:35 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36e28826

app-backup/bareos: improve openrc init scripts

Signed-off-by: Marc Schiffbauer <mschiff <AT> gentoo.org>

 app-backup/bareos/files/bareos-dir.initd | 4 ++++
 app-backup/bareos/files/bareos-sd.initd  | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/app-backup/bareos/files/bareos-dir.initd b/app-backup/bareos/files/bareos-dir.initd
index 0bb566582f4c..a2986d133cc3 100644
--- a/app-backup/bareos/files/bareos-dir.initd
+++ b/app-backup/bareos/files/bareos-dir.initd
@@ -8,6 +8,10 @@ depend() {
 
 start_pre() {
 	checkpath --directory --owner root:bareos --mode 01775 /run/bareos
+	if [[ -e /run/bareos/bareos-dir.9101.pid && $(stat -c %U /run/bareos/bareos-dir.9101.pid) != "root" ]]; then
+		eerror "SECURITY ALERT: bareos owned pidfile found! (see #631598)"
+		exit 1
+	fi
 }
 
 start_post() {

diff --git a/app-backup/bareos/files/bareos-sd.initd b/app-backup/bareos/files/bareos-sd.initd
index 222dc95f47d5..a4a45343d137 100644
--- a/app-backup/bareos/files/bareos-sd.initd
+++ b/app-backup/bareos/files/bareos-sd.initd
@@ -8,6 +8,10 @@ depend() {
 
 start_pre() {
 	checkpath --directory --owner root:bareos --mode 01775 /run/bareos
+	if [[ -e /run/bareos/bareos-sd.9103.pid && $(stat -c %U /run/bareos/bareos-sd.9103.pid) != "root" ]]; then
+		eerror "SECURITY ALERT: bareos owned pidfile found! (see #631598)"
+		exit 1
+	fi
 }
 
 start_post() {


             reply	other threads:[~2022-12-10 18:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-10 18:31 Marc Schiffbauer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-17 14:35 [gentoo-commits] repo/gentoo:master commit in: app-backup/bareos/files/ David Seifert
2023-06-18 11:13 Marc Schiffbauer
2022-12-16 13:28 Marc Schiffbauer
2022-11-25 17:49 Conrad Kostecki
2021-09-08 23:42 Marc Schiffbauer
2021-08-20 12:36 Marc Schiffbauer
2020-08-03 21:07 Marc Schiffbauer
2020-05-14  4:06 Marc Schiffbauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1670697095.36e288262d4a9993fe3528ca913f174cdd4de0f3.mschiff@gentoo \
    --to=mschiff@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox