public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/gmp/
Date: Tue,  6 Dec 2022 10:53:14 +0000 (UTC)	[thread overview]
Message-ID: <1670323970.2e58af672b41a624f84eb7fada145ab2f6c2b1b6.sam@gentoo> (raw)

commit:     2e58af672b41a624f84eb7fada145ab2f6c2b1b6
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Dec  6 10:48:07 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Dec  6 10:52:50 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e58af67

dev-libs/gmp: further econf fixes

* Use gnuconfig.eclass to update configfsf.{guess,sub} before the wrapped
  versions call them.
* Export CBUILD too just in case for the deduced host from upstream's wrapped
  config.guess (not the same as gnuconfig's at all, see bugs for details).
* Save/restore upstream's config.{guess,sub} to make sure that for the second
  multilib build we still have it available to run. In practice, this may not
  have mattered too much, as the exported ac_cv_host should've persisted, but
  it's still worth being (clearly) correct as is the case now.
* Move cpudetection warning into pkg_pretend so it's easier to spot and
  we also don't then repeat it for each ABI.

Bug: https://bugs.gentoo.org/235697
Bug: https://bugs.gentoo.org/545442
Bug: https://bugs.gentoo.org/883201
See: 78b4d4ebbcee12f5ef4c1dfa89f80c98a582db9d
See: 3fe1b5370c0cc1537d1249e8ec9d2fbcd8619499
See: bf286a7973d8b95dbef90f17cc8e2d66c19a47c8
See: 121152c38caefd8e94fb8c90cb51102693b6d6a8
Signed-off-by: Sam James <sam <AT> gentoo.org>

 .../{gmp-6.2.1-r4.ebuild => gmp-6.2.1-r5.ebuild}   | 32 ++++++++++++++++++----
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/dev-libs/gmp/gmp-6.2.1-r4.ebuild b/dev-libs/gmp/gmp-6.2.1-r5.ebuild
similarity index 84%
rename from dev-libs/gmp/gmp-6.2.1-r4.ebuild
rename to dev-libs/gmp/gmp-6.2.1-r5.ebuild
index 0a58fc8ba3b4..2e867d0047e9 100644
--- a/dev-libs/gmp/gmp-6.2.1-r4.ebuild
+++ b/dev-libs/gmp/gmp-6.2.1-r5.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit libtool multilib-minimal toolchain-funcs
+inherit gnuconfig libtool multilib-minimal toolchain-funcs
 
 MY_PV=${PV/_p*}
 MY_PV=${MY_PV/_/-}
@@ -47,6 +47,14 @@ PATCHES=(
 	"${FILESDIR}"/${P}-CVE-2021-43618.patch
 )
 
+pkg_pretend() {
+	if use cpudetection && ! use amd64 && ! use x86 ; then
+		elog "Using generic C implementation on non-amd64/x86 with USE=cpudetection"
+		elog "--enable-fat is a no-op on alternative arches."
+		elog "To obtain an optimized build, set USE=-cpudetection, but binpkgs should not then be made."
+	fi
+}
+
 src_prepare() {
 	default
 
@@ -68,6 +76,19 @@ src_prepare() {
 
 	# Patches to original configure might have lost the +x bit.
 	chmod a+rx configure{,.wrapped} || die
+
+	# Save the upstream files named config.{guess,sub} which are
+	# wrappers around the gnuconfig versions.
+	mkdir "${T}"/gmp-gnuconfig || die
+	mv config.guess "${T}"/gmp-gnuconfig/config.guess || die
+	mv config.sub "${T}"/gmp-gnuconfig/config.sub || die
+	# Grab fresh copies from gnuconfig.
+	touch config.guess config.sub || die
+	gnuconfig_update
+	# Rename the fresh copies to the filenames the wrappers from GMP
+	# expect.
+	mv config.guess configfsf.guess || die
+	mv config.sub configfsf.sub || die
 }
 
 multilib_src_configure() {
@@ -115,11 +136,9 @@ multilib_src_configure() {
 		$(use pic && echo --with-pic)
 	)
 
-	if use cpudetection && ! use amd64 && ! use x86 ; then
-		elog "Using generic C implementation on non-amd64/x86 with USE=cpudetection"
-		elog "--enable-fat is a no-op on alternative arches."
-		elog "To obtain an optimized build, set USE=-cpudetection, but binpkgs should not then be made."
-	fi
+	# Move the wrappers from GMP back into place (may have been destroyed by previous econf run)
+	cp "${T}"/gmp-gnuconfig/config.guess "${S}"/config.guess || die
+	cp "${T}"/gmp-gnuconfig/config.sub "${S}"/config.sub || die
 
 	# See bug #883201 again.
 	if ! use cpudetection && ! tc-is-cross-compiler ; then
@@ -131,6 +150,7 @@ multilib_src_configure() {
 
 		einfo "GMP guessed processor type: ${gmp_host}"
 		ewarn "This build will only work on this machine. Enable USE=cpudetection for binary packages!"
+		export ac_cv_build="${gmp_host}"
 		export ac_cv_host="${gmp_host}"
 	fi
 


             reply	other threads:[~2022-12-06 10:53 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 10:53 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-12-06 13:10 [gentoo-commits] repo/gentoo:master commit in: dev-libs/gmp/ Sam James
2024-12-06 13:06 Sam James
2024-11-18 14:28 Sam James
2023-12-15  3:25 Sam James
2023-09-24 15:44 Arthur Zamarin
2023-09-08 23:30 Andreas K. Hüttel
2023-09-07 23:27 Sam James
2023-09-07 23:03 Sam James
2023-09-07 23:03 Sam James
2023-09-07 20:53 Sam James
2023-09-07 20:53 Sam James
2023-09-07 20:53 Sam James
2023-09-07 20:53 Sam James
2023-07-30 17:01 Sam James
2023-07-30 13:49 Sam James
2023-05-08  7:36 Sam James
2023-05-07 23:54 Sam James
2023-01-28 19:07 Arthur Zamarin
2023-01-27 10:11 Jakov Smolić
2023-01-27  6:31 Sam James
2023-01-27  6:31 Sam James
2023-01-27  6:27 Sam James
2023-01-27  6:27 Sam James
2023-01-27  6:23 Sam James
2022-12-16  7:18 Sam James
2022-11-30  8:31 Sam James
2022-11-30  7:48 Sam James
2022-11-30  7:48 Sam James
2022-01-02  9:13 David Seifert
2021-12-22  0:42 Sam James
2021-12-17 12:00 Sam James
2021-12-17 12:00 Sam James
2021-12-17  9:20 Jakov Smolić
2021-12-17  9:20 Jakov Smolić
2021-12-17  7:55 Arthur Zamarin
2021-12-17  7:33 Arthur Zamarin
2021-12-17  7:33 Arthur Zamarin
2021-10-29  8:49 Sam James
2021-04-24 12:37 Sergei Trofimovich
2021-04-11 18:41 Sergei Trofimovich
2021-04-04 21:21 Sergei Trofimovich
2021-04-02 14:14 Sam James
2021-04-02 14:14 Sam James
2021-04-02 14:10 Sam James
2021-04-02 14:09 Sam James
2021-04-02 14:08 Sam James
2021-04-02 14:07 Sam James
2020-12-25 12:17 Sergei Trofimovich
2020-12-23 13:57 Sergei Trofimovich
2020-12-22  6:29 Sam James
2020-12-21 18:01 Sam James
2020-12-21  9:41 Sergei Trofimovich
2020-12-20 20:03 Sam James
2020-12-20 16:30 Thomas Deutschmann
2020-12-20 12:56 Sergei Trofimovich
2020-12-20  6:33 Sam James
2020-12-18 14:25 Sam James
2020-11-15 10:24 Sergei Trofimovich
2020-06-10 18:22 Sergei Trofimovich
2020-05-02 17:51 Sergei Trofimovich
2020-04-05 20:06 Mart Raudsepp
2020-04-01 11:17 Jeroen Roovers
2020-03-29 20:16 Sergei Trofimovich
2020-03-29 10:13 Sergei Trofimovich
2020-03-29 10:13 Sergei Trofimovich
2020-03-26 21:47 Sergei Trofimovich
2020-03-23 23:58 Sergei Trofimovich
2020-03-23 18:23 Sergei Trofimovich
2020-03-22 14:35 Agostino Sarubbo
2020-03-22 14:30 Agostino Sarubbo
2020-03-22 11:08 Agostino Sarubbo
2020-03-22 11:07 Agostino Sarubbo
2020-03-22 10:56 Agostino Sarubbo
2020-03-22 10:55 Agostino Sarubbo
2020-03-22 10:54 Agostino Sarubbo
2020-03-22 10:53 Agostino Sarubbo
2020-01-31  7:57 Sergei Trofimovich
2020-01-30 11:23 Sergei Trofimovich
2020-01-19 12:24 Sergei Trofimovich
2019-09-21 18:09 Matt Turner
2019-09-20  6:39 Sergei Trofimovich
2019-09-16  6:52 Agostino Sarubbo
2019-09-13 18:31 Mikle Kolyada
2019-09-13  7:45 Agostino Sarubbo
2019-09-10  7:10 Agostino Sarubbo
2019-09-10  7:00 Sergei Trofimovich
2019-09-10  6:56 Sergei Trofimovich
2019-09-10  6:51 Sergei Trofimovich
2019-09-09 20:56 Aaron Bauman
2019-09-09 17:23 Agostino Sarubbo
2019-05-04 14:53 Andreas K. Hüttel
2019-02-05 22:19 Sergei Trofimovich
2019-02-05 21:37 Sergei Trofimovich
2018-06-10 16:29 Sergei Trofimovich
2018-04-15 17:52 Sergei Trofimovich
2018-01-13 23:22 Mike Frysinger
2017-11-27  7:27 Sergei Trofimovich
2017-11-27  0:20 Thomas Deutschmann
2017-11-26 19:06 Sergei Trofimovich
2017-11-26  1:30 Matt Turner
2017-11-25 20:02 Matt Turner
2017-11-25 12:10 Sergei Trofimovich
2017-05-06 22:20 David Seifert
2017-01-29 16:08 Fabian Groffen
2016-12-20 17:21 Fabian Groffen
2016-12-20 14:18 Fabian Groffen
2016-12-19 18:28 Mike Frysinger
2016-12-08 16:47 Mike Frysinger
2016-11-14 14:50 Mike Frysinger
2016-07-03 19:21 Jeroen Roovers
2016-07-03 11:03 Jeroen Roovers
2016-06-30 14:47 Tobias Klausmann
2016-06-26 18:46 Markus Meier
2016-06-21  2:17 Mike Frysinger
2016-06-21  2:17 Mike Frysinger
2015-11-08 17:38 Mike Frysinger
2015-11-05 17:20 Mike Frysinger
2015-10-29  0:49 Mike Frysinger
2015-10-24 16:18 Mike Frysinger
2015-10-24 16:14 Mike Frysinger
2015-10-24 16:08 Mike Frysinger
2015-10-10 15:34 Mikle Kolyada
2015-10-04 10:14 Agostino Sarubbo
2015-10-04  9:42 Agostino Sarubbo
2015-10-03 18:24 Anthony G. Basile
2015-10-03 18:18 Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1670323970.2e58af672b41a624f84eb7fada145ab2f6c2b1b6.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox