[gentoo-commits] repo/gentoo:master commit in: app-editors/jupp/

["Sam James" <sam@gentoo.org>]

commit:     6a02df6f8f73f9d69ec9524f33adf761717118d4
Author:     Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Sun Dec  4 10:42:25 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Dec  6 09:11:28 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a02df6f

app-editors/jupp: Apply patsub_replacement defences

Per bug #881383, string replacing forms of parameter expansion must take care
to quote - or appropriately escape - any nested parameter expansions, assuming
that their values are intended to be taken literally (as is almost invariably
the case). This has long been the case, but the introduction of the new
patsub_replacement option in bash >=5.2 has brought the issue to the fore.

In the case of the app-editors/jupp package, the improper quoting is not yet
causing any issues. Still, it is better to write the code properly to begin
with, especially considering the demonstrative value of robust code.

Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Bug: https://bugs.gentoo.org/881383
Signed-off-by: Sam James <sam <AT> gentoo.org>

 app-editors/jupp/jupp-3.1_p41.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app-editors/jupp/jupp-3.1_p41.ebuild b/app-editors/jupp/jupp-3.1_p41.ebuild
index cfdbb37a9585..3e6e016b519c 100644
--- a/app-editors/jupp/jupp-3.1_p41.ebuild
+++ b/app-editors/jupp/jupp-3.1_p41.ebuild
@@ -5,7 +5,7 @@ EAPI=8
 
 DESCRIPTION="Portable version of Joe's Own Editor"
 HOMEPAGE="http://www.mirbsd.org/jupp.htm"
-SRC_URI="http://www.mirbsd.org/MirOS/dist/${PN}/joe-${PV/_p/${PN}}.tgz"
+SRC_URI="http://www.mirbsd.org/MirOS/dist/${PN}/joe-${PV/_p/"${PN}"}.tgz"
 S="${WORKDIR}/${PN}"
 
 LICENSE="GPL-1"