From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8E64D158020 for ; Wed, 30 Nov 2022 23:30:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B97F0E077A; Wed, 30 Nov 2022 23:30:16 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 96571E077A for ; Wed, 30 Nov 2022 23:30:16 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 7FCBB340B9C for ; Wed, 30 Nov 2022 23:30:15 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id BA97454C for ; Wed, 30 Nov 2022 23:30:13 +0000 (UTC) From: "Michael Orlitzky" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michael Orlitzky" Message-ID: <1669850827.51148f5256d4c1d10138f967a884a6f7aa58fdca.mjo@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-analyzer/nagios-plugins/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild X-VCS-Directories: net-analyzer/nagios-plugins/ X-VCS-Committer: mjo X-VCS-Committer-Name: Michael Orlitzky X-VCS-Revision: 51148f5256d4c1d10138f967a884a6f7aa58fdca X-VCS-Branch: master Date: Wed, 30 Nov 2022 23:30:13 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: fc72356d-d07d-4ca6-8506-825203ab7638 X-Archives-Hash: 62c87b21a783ef4d2d920e84daa9ae18 commit: 51148f5256d4c1d10138f967a884a6f7aa58fdca Author: Michael Orlitzky gentoo org> AuthorDate: Wed Nov 30 23:20:19 2022 +0000 Commit: Michael Orlitzky gentoo org> CommitDate: Wed Nov 30 23:27:07 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51148f52 net-analyzer/nagios-plugins: use ping/ping6 from $PATH in v2.4.2. We pass explicit ping/ping6 commands to the nagios-plugins ./configure script to prevent it from running those commands during the build. However, instead of grabbing their paths from $PATH, we have (until now) hard-coded them to /bin/ping and /bin/ping6. This has now bitten us with net-misc/iputils-20221126. This commit uses $(command -v ...) to get the right absolute paths. Thanks to Daniel Pouzzner for reporting the problem and suggesting the fix. Closes: https://bugs.gentoo.org/883765 Signed-off-by: Michael Orlitzky gentoo.org> net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild b/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild index 7b20af18afa6..8fe32f3ad69a 100644 --- a/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild +++ b/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild @@ -83,11 +83,12 @@ src_configure() { fi # The autodetection for these two commands can hang if localhost is - # down or ICMP traffic is filtered. Bug #468296. - myconf+=( --with-ping-command="/bin/ping -n -U -w %d -c %d %s" ) + # down or ICMP traffic is filtered (bug #468296). But also the path + # likes to move around on us (bug #883765). + myconf+=( --with-ping-command="$(command -v ping) -n -U -w %d -c %d %s" ) if use ipv6; then - myconf+=( --with-ping6-command="/bin/ping6 -n -U -w %d -c %d %s" ) + myconf+=( --with-ping6-command="$(command -v ping6) -n -U -w %d -c %d %s" ) fi econf \