From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1458803-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A5B52158020 for <garchives@archives.gentoo.org>; Sun, 20 Nov 2022 23:37:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E6586E07AE; Sun, 20 Nov 2022 23:37:22 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CCF7AE07AE for <gentoo-commits@lists.gentoo.org>; Sun, 20 Nov 2022 23:37:22 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 8EB5E341137 for <gentoo-commits@lists.gentoo.org>; Sun, 20 Nov 2022 23:37:21 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id F3D81624 for <gentoo-commits@lists.gentoo.org>; Sun, 20 Nov 2022 23:37:19 +0000 (UTC) From: "Sam James" <sam@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org> Message-ID: <1668987432.1d184f1a99a9bbf53b1fc0f288300ed1979099f2.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: sys-apps/portage/, sys-apps/portage/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: sys-apps/portage/files/portage-3.0.39-implicit-func-decls-no-fatal.patch sys-apps/portage/portage-3.0.39-r1.ebuild sys-apps/portage/portage-3.0.39.ebuild X-VCS-Directories: sys-apps/portage/files/ sys-apps/portage/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 1d184f1a99a9bbf53b1fc0f288300ed1979099f2 X-VCS-Branch: master Date: Sun, 20 Nov 2022 23:37:19 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 7b05b601-3ee2-4fca-97af-fafc175512a0 X-Archives-Hash: 7e42ac11a2b114c14fe854132c39d4b1 commit: 1d184f1a99a9bbf53b1fc0f288300ed1979099f2 Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Sun Nov 20 23:36:46 2022 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sun Nov 20 23:37:12 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d184f1a sys-apps/portage: make Portage less noisy on implicit func. decls for now We will undo this again soon, but we need fewer high profiles to be broken first, as it impacts wider testing & bug finding. Bug: https://bugs.gentoo.org/870412 Signed-off-by: Sam James <sam <AT> gentoo.org> ...rtage-3.0.39-implicit-func-decls-no-fatal.patch | 34 ++++++++++++++++++++++ ...tage-3.0.39.ebuild => portage-3.0.39-r1.ebuild} | 1 + 2 files changed, 35 insertions(+) diff --git a/sys-apps/portage/files/portage-3.0.39-implicit-func-decls-no-fatal.patch b/sys-apps/portage/files/portage-3.0.39-implicit-func-decls-no-fatal.patch new file mode 100644 index 000000000000..4a4e68f2690a --- /dev/null +++ b/sys-apps/portage/files/portage-3.0.39-implicit-func-decls-no-fatal.patch @@ -0,0 +1,34 @@ +https://github.com/gentoo/portage/commit/0fdbbbdb5a80e331adf701f2b2c1f096695447c4 + +From 0fdbbbdb5a80e331adf701f2b2c1f096695447c4 Mon Sep 17 00:00:00 2001 +From: Sam James <sam@gentoo.org> +Date: Sun, 20 Nov 2022 23:32:08 +0000 +Subject: [PATCH] install-qa-check.d/90gcc-warnings: don't make implicit func + decls fatal for now + +We need to do this at some point (as Clang 16 and GCC 14 are doing it, and +they indicate runtime problems anyway), but there's too much breakage for now. + +We did find some extra bugs though. The main issue is too much high-profile +stuff breaks rather than the total number of bugs, wrt Portage behaviour +changing being suitable or not. + +Bug: https://bugs.gentoo.org/870412 +Signed-off-by: Sam James <sam@gentoo.org> +--- a/bin/install-qa-check.d/90gcc-warnings ++++ b/bin/install-qa-check.d/90gcc-warnings +@@ -153,9 +153,10 @@ gcc_warn_check() { + # always_overflow=yes + #fi + +- if [[ ${f} == *'[-Wimplicit-function-declaration]'* ]] ; then +- implicit_func_decl=yes +- fi ++ # Disabled for now because too many failures. bug #870412. ++ #if [[ ${f} == *'[-Wimplicit-function-declaration]'* ]] ; then ++ # implicit_func_decl=yes ++ #fi + + if [[ ${always_overflow} = yes || ${implicit_func_decl} = yes ]] ; then + eerror + diff --git a/sys-apps/portage/portage-3.0.39.ebuild b/sys-apps/portage/portage-3.0.39-r1.ebuild similarity index 99% rename from sys-apps/portage/portage-3.0.39.ebuild rename to sys-apps/portage/portage-3.0.39-r1.ebuild index 48ca5c0728ae..040a60847373 100644 --- a/sys-apps/portage/portage-3.0.39.ebuild +++ b/sys-apps/portage/portage-3.0.39-r1.ebuild @@ -85,6 +85,7 @@ pkg_pretend() { python_prepare_all() { local PATCHES=( + "${FILESDIR}"/${P}-implicit-func-decls-no-fatal.patch ) distutils-r1_python_prepare_all