[gentoo-commits] repo/gentoo:master commit in: sys-apps/portage/, sys-apps/portage/files/

["Sam James" <sam@gentoo.org>]

commit:     1d184f1a99a9bbf53b1fc0f288300ed1979099f2
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Nov 20 23:36:46 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Nov 20 23:37:12 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d184f1a

sys-apps/portage: make Portage less noisy on implicit func. decls for now

We will undo this again soon, but we need fewer high profiles to be
broken first, as it impacts wider testing & bug finding.

Bug: https://bugs.gentoo.org/870412
Signed-off-by: Sam James <sam <AT> gentoo.org>

 ...rtage-3.0.39-implicit-func-decls-no-fatal.patch | 34 ++++++++++++++++++++++
 ...tage-3.0.39.ebuild => portage-3.0.39-r1.ebuild} |  1 +
 2 files changed, 35 insertions(+)

diff --git a/sys-apps/portage/files/portage-3.0.39-implicit-func-decls-no-fatal.patch b/sys-apps/portage/files/portage-3.0.39-implicit-func-decls-no-fatal.patch
new file mode 100644
index 000000000000..4a4e68f2690a
--- /dev/null
+++ b/sys-apps/portage/files/portage-3.0.39-implicit-func-decls-no-fatal.patch
@@ -0,0 +1,34 @@
+https://github.com/gentoo/portage/commit/0fdbbbdb5a80e331adf701f2b2c1f096695447c4
+
+From 0fdbbbdb5a80e331adf701f2b2c1f096695447c4 Mon Sep 17 00:00:00 2001
+From: Sam James <sam@gentoo.org>
+Date: Sun, 20 Nov 2022 23:32:08 +0000
+Subject: [PATCH] install-qa-check.d/90gcc-warnings: don't make implicit func
+ decls fatal for now
+
+We need to do this at some point (as Clang 16 and GCC 14 are doing it, and
+they indicate runtime problems anyway), but there's too much breakage for now.
+
+We did find some extra bugs though. The main issue is too much high-profile
+stuff breaks rather than the total number of bugs, wrt Portage behaviour
+changing being suitable or not.
+
+Bug: https://bugs.gentoo.org/870412
+Signed-off-by: Sam James <sam@gentoo.org>
+--- a/bin/install-qa-check.d/90gcc-warnings
++++ b/bin/install-qa-check.d/90gcc-warnings
+@@ -153,9 +153,10 @@ gcc_warn_check() {
+ 			#	always_overflow=yes
+ 			#fi
+ 
+-			if [[ ${f} == *'[-Wimplicit-function-declaration]'* ]] ; then
+-				implicit_func_decl=yes
+-			fi
++			# Disabled for now because too many failures. bug #870412.
++			#if [[ ${f} == *'[-Wimplicit-function-declaration]'* ]] ; then
++			#	implicit_func_decl=yes
++			#fi
+ 
+ 			if [[ ${always_overflow} = yes || ${implicit_func_decl} = yes ]] ; then
+ 				eerror
+

diff --git a/sys-apps/portage/portage-3.0.39.ebuild b/sys-apps/portage/portage-3.0.39-r1.ebuild
similarity index 99%
rename from sys-apps/portage/portage-3.0.39.ebuild
rename to sys-apps/portage/portage-3.0.39-r1.ebuild
index 48ca5c0728ae..040a60847373 100644
--- a/sys-apps/portage/portage-3.0.39.ebuild
+++ b/sys-apps/portage/portage-3.0.39-r1.ebuild
@@ -85,6 +85,7 @@ pkg_pretend() {
 
 python_prepare_all() {
 	local PATCHES=(
+		"${FILESDIR}"/${P}-implicit-func-decls-no-fatal.patch
 	)
 
 	distutils-r1_python_prepare_all