public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Matt Turner" <mattst88@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/catalyst:wip/mattst88 commit in: targets/support/
Date: Sun, 20 Nov 2022 01:43:30 +0000 (UTC)	[thread overview]
Message-ID: <1668908601.4524aa8d8861b6526caa347a5ee5b46884c6098a.mattst88@gentoo> (raw)

commit:     4524aa8d8861b6526caa347a5ee5b46884c6098a
Author:     Matt Turner <mattst88 <AT> gentoo <DOT> org>
AuthorDate: Sun Nov 20 00:02:56 2022 +0000
Commit:     Matt Turner <mattst88 <AT> gentoo <DOT> org>
CommitDate: Sun Nov 20 01:43:21 2022 +0000
URL:        https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=4524aa8d

targets: Fix KEYWORDS vs `uname -m` confusion

We've had difficulties keeping straight KEYWORDS (e.g. "hppa") vs `uname
-m` output in the past, and I suspect I've made it worse over time.

Fix the issues I spotted, and add a catch-all for architectures we are
missing support for, so if ISO/netboot/etc creation doesn't silently
fail.

Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org>

 targets/support/bootloader-setup.sh | 13 +++++++------
 targets/support/create-iso.sh       | 30 ++++++++++++++++--------------
 targets/support/netboot-final.sh    |  8 ++++++--
 targets/support/pre-kmerge.sh       |  2 +-
 4 files changed, 30 insertions(+), 23 deletions(-)

diff --git a/targets/support/bootloader-setup.sh b/targets/support/bootloader-setup.sh
index 08d25b59..6ca3e38a 100755
--- a/targets/support/bootloader-setup.sh
+++ b/targets/support/bootloader-setup.sh
@@ -56,10 +56,7 @@ case ${clst_hostarch} in
 			((bctr=${bctr}+1))
 		done
 	;;
-	arm)
-		# NO SOFTLEVEL SUPPORT YET
-	;;
-	hppa)
+	hppa*)
 		# NO SOFTLEVEL SUPPORT YET
 		mkdir -p $1/boot
 
@@ -81,7 +78,7 @@ case ${clst_hostarch} in
 			echo "--recoverykernel=boot/${x}" >> ${icfg}
 		done
 	;;
-	amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
+	aarch64*|amd64|ia64|ppc*|powerpc*|sparc*|x86)
 		kern_subdir=/boot
 		iacfg=$1/boot/grub/grub.cfg
 		mkdir -p $1/boot/grub
@@ -119,7 +116,7 @@ case ${clst_hostarch} in
 			echo "" >> ${iacfg}
 		done
 	;;
-	mips)
+	mips*)
 		# NO SOFTLEVEL SUPPORT YET
 
 		# Mips is an interesting arch -- where most archs will
@@ -179,5 +176,9 @@ case ${clst_hostarch} in
 		[ -e "${1}/sash64" ] && mv ${1}/sash64 ${scratch}/arcload
 		[ -e "${1}/arc.cf" ] && mv ${1}/arc.cf ${scratch}/arcload
 		;;
+	*)
+		echo "Boot loader support for ${clst_hostarch} is unimplemented"
+		exit 1
+	;;
 esac
 exit $?

diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
index 8eada6a7..8412f6fb 100755
--- a/targets/support/create-iso.sh
+++ b/targets/support/create-iso.sh
@@ -10,7 +10,7 @@ case ${clst_hostarch} in
 		cdmaker="xorriso"
 		cdmakerpkg="dev-libs/libisoburn"
 		;;
-	mips)
+	mips*)
 		cdmaker="sgibootcd"
 		cdmakerpkg="sys-boot/sgibootcd"
 		;;
@@ -18,7 +18,7 @@ case ${clst_hostarch} in
 		cdmaker="grub-mkrescue"
 		cdmakerpkg="dev-libs/libisoburn and sys-boot/grub:2"
 		;;
-	amd64|arm64|ia64|x86)
+	aarch64*|amd64|ia64|x86)
 		cdmaker="grub-mkrescue"
 		# grub-mkrescue requires:
 		#  xorriso from libisoburn
@@ -49,28 +49,28 @@ then
 				amd64)
 					clst_iso_volume_id="Gentoo Linux - AMD64"
 				;;
-				arm)
+				arm*)
 					clst_iso_volume_id="Gentoo Linux - ARM"
 				;;
-				arm64)
+				aarch64*)
 					clst_iso_volume_id="Gentoo Linux - ARM64"
 				;;
-				hppa)
-					clst_iso_volume_id="Gentoo Linux - HPPA"
-				;;
 				ia64)
 					clst_iso_volume_id="Gentoo Linux - IA64"
 				;;
 				m68k)
 					clst_iso_volume_id="Gentoo Linux - M68K"
 				;;
-				mips)
+				mips*)
 					clst_iso_volume_id="Gentoo Linux - MIPS"
 				;;
+				hppa*)
+					clst_iso_volume_id="Gentoo Linux - HPPA"
+				;;
 				ppc*|powerpc*)
 					clst_iso_volume_id="Gentoo Linux - PowerPC"
 				;;
-				s390)
+				s390*)
 					clst_iso_volume_id="Gentoo Linux - S390"
 				;;
 				sh)
@@ -126,16 +126,14 @@ case ${clst_hostarch} in
 		echo ">> xorriso -as genisofs -alpha-boot boot/bootlx -R -l -J -V \"${clst_iso_volume_id}\" -o \"${1}\" \"${clst_target_path}\""
 		xorriso -as genisofs -alpha-boot boot/bootlx -R -l -J -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}" || die "Cannot make ISO image"
 	;;
-	arm)
-	;;
-	hppa)
+	hppa*)
 		echo ">> Running mkisofs to create iso image...."
 		run_mkisofs -R -l -J -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/
 		pushd "${clst_target_path}/"
 		palo -f boot/palo.conf -C "${1}"
 		popd
 	;;
-	mips)
+	mips*)
 		if [[ ${clst_fstype} != squashfs ]]; then
 			die "SGI LiveCD(s) only support the 'squashfs' fstype!"
 		fi
@@ -191,7 +189,7 @@ case ${clst_hostarch} in
 		# o=	output image (burnable to CD; readable by fdisk)
 		/usr/bin/sgibootcd c=${cfg} o=${clst_iso}
 	;;
-	amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
+	aarch64*|amd64|ia64|ppc*|powerpc*|sparc*|x86)
 		isoroot_checksum
 
 		extra_opts=("-joliet" "-iso-level" "3")
@@ -202,5 +200,9 @@ case ${clst_hostarch} in
 		echo ">> Running grub-mkrescue to create iso image...."
 		grub-mkrescue "${extra_opts[@]}" -o "${1}" "${clst_target_path}"
 	;;
+	*)
+		echo "ISO support for ${clst_hostarch} is unimplemented"
+		exit 1
+	;;
 esac
 exit  $?

diff --git a/targets/support/netboot-final.sh b/targets/support/netboot-final.sh
index 7a26e0f4..3071f698 100755
--- a/targets/support/netboot-final.sh
+++ b/targets/support/netboot-final.sh
@@ -20,7 +20,7 @@ rmdir ${clst_target_path}/boot
 # Any post-processing necessary for each architecture can be done here.  This
 # may include things like sparc's elftoaout, x86's PXE boot, etc.
 case ${clst_hostarch} in
-	hppa)
+	hppa*)
 		# Only one kernel should be there
 		kname=${clst_boot_kernel[0]}
 		rm -f ${clst_target_path}/${kname}-hppa.lif
@@ -36,7 +36,7 @@ case ${clst_hostarch} in
 
 		;;
 	sparc*)
-		if [ "${clst_subarch}" == "sparc" ]; then
+		if [[ ${clst_hostarch} == sparc* ]]; then
 			piggyback=piggyback
 		else
 			piggyback=piggyback64
@@ -46,5 +46,9 @@ case ${clst_hostarch} in
 			${piggyback} ${clst_target_path}/${x}-a.out ${clst_target_path}/kernels/misc/System-${x}.map ${clst_target_path}/kernels/misc/${x}.igz
 		done
 		;;
+	*)
+		echo "Netboot support for ${clst_hostarch} is unimplemented"
+		exit 1
+	;;
 esac
 exit $?

diff --git a/targets/support/pre-kmerge.sh b/targets/support/pre-kmerge.sh
index 0dfc835e..4a14fe8d 100755
--- a/targets/support/pre-kmerge.sh
+++ b/targets/support/pre-kmerge.sh
@@ -4,7 +4,7 @@ RUN_DEFAULT_FUNCS="yes"
 
 source /tmp/chroot-functions.sh
 
-if [[ ${clst_hostarch} == hppa ]]; then
+if [[ ${clst_hostarch} == hppa* ]]; then
 	for i in ${clst_boot_kernel}; do
 		case ${i} in
 			*32)


             reply	other threads:[~2022-11-20  1:43 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20  1:43 Matt Turner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-11 14:47 [gentoo-commits] proj/catalyst:wip/mattst88 commit in: targets/support/ Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2023-05-11 14:47 Matt Turner
2022-11-28 20:38 Matt Turner
2022-11-28 20:38 Matt Turner
2022-11-28 20:38 Matt Turner
2022-11-22  3:49 Matt Turner
2022-11-22  3:49 Matt Turner
2022-11-20  0:21 Matt Turner
2022-11-20  0:21 Matt Turner
2022-11-20  0:21 Matt Turner
2022-11-20  0:21 Matt Turner
2022-11-17 23:42 [gentoo-commits] proj/catalyst:master " Matt Turner
2022-11-20  0:21 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2022-11-17 23:42 [gentoo-commits] proj/catalyst:master " Matt Turner
2022-11-20  0:21 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2022-01-30 20:42 Matt Turner
2022-01-30 20:42 Matt Turner
2021-07-29 22:00 [gentoo-commits] proj/catalyst:master " Matt Turner
2022-01-30 20:42 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2021-07-29  1:22 [gentoo-commits] proj/catalyst:master " Matt Turner
2022-01-30 20:42 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2021-06-10  0:48 Matt Turner
2020-12-19 19:56 Matt Turner
2020-12-19 19:56 Matt Turner
2020-10-29 21:00 Matt Turner
2020-10-29 21:00 Matt Turner
2020-10-29 21:00 Matt Turner
2020-10-29 21:00 Matt Turner
2020-10-29 21:00 Matt Turner
2020-10-28 20:51 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-28 20:51 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-22 18:06 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-22 18:06 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-22 18:06 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-21 17:58 [gentoo-commits] proj/catalyst:master " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-10-20  8:30 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-10-29 21:00 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-05-21 20:25 [gentoo-commits] proj/catalyst:master " Matt Turner
2020-05-20  1:52 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-05-20  3:39 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-05-20  1:52 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-05-17  3:26 [gentoo-commits] proj/catalyst:master " Matt Turner
2020-05-16  6:55 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner
2020-05-16  6:54 [gentoo-commits] proj/catalyst:pending/mattst88 " Matt Turner
2020-05-16  6:55 ` [gentoo-commits] proj/catalyst:wip/mattst88 " Matt Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1668908601.4524aa8d8861b6526caa347a5ee5b46884c6098a.mattst88@gentoo \
    --to=mattst88@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox