public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Matt Turner" <mattst88@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: gnome-extra/libgda/
Date: Sat, 19 Nov 2022 01:44:29 +0000 (UTC)	[thread overview]
Message-ID: <1668822259.d2f4f02f49acb86e7281e5569db0a0922d5da1b4.mattst88@gentoo> (raw)

commit:     d2f4f02f49acb86e7281e5569db0a0922d5da1b4
Author:     James Le Cuirot <chewi <AT> gentoo <DOT> org>
AuthorDate: Sun Nov 13 14:10:39 2022 +0000
Commit:     Matt Turner <mattst88 <AT> gentoo <DOT> org>
CommitDate: Sat Nov 19 01:44:19 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2f4f02f

gnome-extra/libgda: Detect BerkDB in the right way with configure flags

Upstream has a proper way to do this without appending to CPPFLAGS. This method
will even work when cross-compiling after db-use.eclass has been fixed.

Signed-off-by: James Le Cuirot <chewi <AT> gentoo.org>
Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org>

 gnome-extra/libgda/libgda-5.2.9-r1.ebuild | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/gnome-extra/libgda/libgda-5.2.9-r1.ebuild b/gnome-extra/libgda/libgda-5.2.9-r1.ebuild
index 3cb270db2bec..1aca92fcec07 100644
--- a/gnome-extra/libgda/libgda-5.2.9-r1.ebuild
+++ b/gnome-extra/libgda/libgda-5.2.9-r1.ebuild
@@ -4,7 +4,7 @@
 EAPI=8
 GNOME2_EAUTORECONF="yes"
 
-inherit db-use flag-o-matic gnome2 java-pkg-opt-2 vala
+inherit db-use gnome2 java-pkg-opt-2 vala
 
 DESCRIPTION="GNOME database access library"
 HOMEPAGE="https://www.gnome-db.org/"
@@ -78,8 +78,6 @@ pkg_setup() {
 }
 
 src_prepare() {
-	use berkdb && append-cppflags "-I$(db_includedir)"
-
 	# They need python2
 	sed -e '/SUBDIRS =/ s/trml2html//' \
 		-e '/SUBDIRS =/ s/trml2pdf//' \
@@ -114,6 +112,15 @@ src_prepare() {
 }
 
 src_configure() {
+	local bdbroot bdbinc bdblib
+
+	if use berkdb; then
+		bdbinc=$(db_includedir)
+		bdbroot=${bdbinc%/include/*}
+		bdbinc=${bdbinc#${bdbroot}/}
+		bdblib=$(get_libdir)
+	fi
+
 	use vala && vala_setup
 
 	# Upstream broken configure handling for UI library introspection and vala bindings if passing a choice with use_enable - https://gitlab.gnome.org/GNOME/libgda/issues/158
@@ -123,7 +130,9 @@ src_configure() {
 		--disable-default-binary \
 		--disable-static \
 		--enable-system-sqlite \
-		$(use_with berkdb bdb /usr) \
+		$(use_with berkdb bdb "${bdbroot}") \
+		$(use_with berkdb bdb-includedir-name "${bdbinc}") \
+		$(use_with berkdb bdb-libdir-name "${bdblib}") \
 		$(use_with canvas goocanvas) \
 		$(use_enable debug) \
 		$(use_with firebird firebird /usr) \


             reply	other threads:[~2022-11-19  1:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19  1:44 Matt Turner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-01 19:26 [gentoo-commits] repo/gentoo:master commit in: gnome-extra/libgda/ Andreas K. Hüttel
2024-10-29 22:13 Sam James
2024-10-29 15:39 Sam James
2023-05-29 21:25 Sam James
2023-05-18 12:17 Andreas Sturmlechner
2022-12-12 21:06 James Le Cuirot
2022-12-12 17:52 Arthur Zamarin
2022-12-12  1:59 Sam James
2022-11-19  1:44 Matt Turner
2022-10-30 22:29 Matt Turner
2022-04-16 12:25 Yixun Lan
2021-04-21 18:51 Sam James
2020-10-03 16:06 Pacho Ramos
2020-09-19 20:38 Pacho Ramos
2020-09-19 20:04 Pacho Ramos
2019-02-11 18:25 Brian Evans
2018-12-31 21:49 Mart Raudsepp
2018-12-30 11:28 Mart Raudsepp
2018-12-28 16:24 Mart Raudsepp
2018-12-28 11:06 Mart Raudsepp
2018-11-13 22:08 Mart Raudsepp
2018-11-13 20:29 Craig Andrews
2017-11-26 23:02 David Seifert
2017-02-15 20:38 Mart Raudsepp
2016-10-08  9:51 Pacho Ramos
2016-03-06 18:58 Mikle Kolyada
2016-02-08  9:54 Patrick Lauer
2016-02-01 21:05 Pacho Ramos
2016-01-03 16:03 Gilles Dartiguelongue
2015-12-26  5:39 Dennis Lamm
2015-09-07 21:11 Mikle Kolyada
2015-08-31  0:22 Alexandre Rostovtsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1668822259.d2f4f02f49acb86e7281e5569db0a0922d5da1b4.mattst88@gentoo \
    --to=mattst88@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox