From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C3F5F158020 for ; Thu, 10 Nov 2022 07:17:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EEC7DE091D; Thu, 10 Nov 2022 07:17:10 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D384EE091D for ; Thu, 10 Nov 2022 07:17:10 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E8A58340F0E for ; Thu, 10 Nov 2022 07:17:09 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 73B9B599 for ; Thu, 10 Nov 2022 07:17:08 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1668064622.2b94b64306230dc3595150c5bba87ec0763d93a3.sam@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/ X-VCS-Repository: proj/devmanual X-VCS-Files: general-concepts/ebuild-revisions/text.xml X-VCS-Directories: general-concepts/ebuild-revisions/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 2b94b64306230dc3595150c5bba87ec0763d93a3 X-VCS-Branch: master Date: Thu, 10 Nov 2022 07:17:08 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 36730537-6021-4eee-8971-b3bafe0834bb X-Archives-Hash: 90124023b03405917215337c5aeaa574 commit: 2b94b64306230dc3595150c5bba87ec0763d93a3 Author: Sam James gentoo org> AuthorDate: Tue Nov 8 04:31:16 2022 +0000 Commit: Sam James gentoo org> CommitDate: Thu Nov 10 07:17:02 2022 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=2b94b643 general-concepts/ebuild-revisions: note which build-time fixes need a new revision Signed-off-by: Sam James gentoo.org> general-concepts/ebuild-revisions/text.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index fc5ba7c..b2fa57f 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -85,7 +85,11 @@ of thumb could be used as a guideline:
  • adding a patch to fix a build-time issue that prevented users from building the package (since it does not affect users who already - managed to build it), + managed to build it) unless: it affected runtime behaviour in some way + (e.g. -Wformat or -Wimplicit-function-declaration fixes); + the package may have been miscompiled, or the change is substantial + (if adding a huge patch to fix a problem, the chances of an unexpected + issue being introduced by it are larger).
  • adding a trivial documentation fix,