From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
Date: Thu, 10 Nov 2022 07:17:08 +0000 (UTC) [thread overview]
Message-ID: <1668064622.2b94b64306230dc3595150c5bba87ec0763d93a3.sam@gentoo> (raw)
commit: 2b94b64306230dc3595150c5bba87ec0763d93a3
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Nov 8 04:31:16 2022 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Nov 10 07:17:02 2022 +0000
URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=2b94b643
general-concepts/ebuild-revisions: note which build-time fixes need a new revision
Signed-off-by: Sam James <sam <AT> gentoo.org>
general-concepts/ebuild-revisions/text.xml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml
index fc5ba7c..b2fa57f 100644
--- a/general-concepts/ebuild-revisions/text.xml
+++ b/general-concepts/ebuild-revisions/text.xml
@@ -85,7 +85,11 @@ of thumb could be used as a guideline:
<li>
adding a patch to fix a build-time issue that prevented users from
building the package (since it does not affect users who already
- managed to build it),
+ managed to build it) unless: it affected runtime behaviour in some way
+ (e.g. <c>-Wformat</c> or <c>-Wimplicit-function-declaration</c> fixes);
+ the package may have been miscompiled, or the change is substantial
+ (if adding a huge patch to fix a problem, the chances of an unexpected
+ issue being introduced by it are larger).
</li>
<li>adding a trivial documentation fix,</li>
<li>
next reply other threads:[~2022-11-10 7:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 7:17 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-29 17:40 [gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/ Ulrich Müller
2024-10-29 17:40 Ulrich Müller
2023-08-26 5:43 Ulrich Müller
2023-01-14 20:24 Sam James
2022-11-10 7:17 Sam James
2021-09-24 14:07 Ulrich Müller
2021-09-24 12:00 Joonas Niilola
2021-09-24 12:00 Joonas Niilola
2021-09-24 12:00 Joonas Niilola
2021-09-24 12:00 Joonas Niilola
2021-07-03 16:21 Ulrich Müller
2021-07-03 16:21 Ulrich Müller
2017-09-25 4:23 Göktürk Yüksek
2017-09-25 4:23 Göktürk Yüksek
2017-09-25 4:23 Göktürk Yüksek
2017-09-25 4:23 Göktürk Yüksek
2015-05-09 15:22 Ulrich Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1668064622.2b94b64306230dc3595150c5bba87ec0763d93a3.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox