[gentoo-commits] proj/portage:master commit in: /, bin/install-qa-check.d/

["Sam James" <sam@gentoo.org>]

commit:     739e8de006c6c2a247edef3e616fcdecba28edc8
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Nov  9 07:38:53 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Nov  9 07:38:53 2022 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=739e8de0

install-qa-check.d/90gcc-warnings: drop some conversion warnings for now

While I want to keep these, Bash triggers them with a trick it uses
to force truncation in random.c, and I can't really justify FEATURES=stricter
stopping Bash from installing.

Signed-off-by: Sam James <sam <AT> gentoo.org>

 NEWS                                  |  4 ----
 bin/install-qa-check.d/90gcc-warnings | 13 +++++++++----
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/NEWS b/NEWS
index 5ee6e3bd1..2480f55a8 100644
--- a/NEWS
+++ b/NEWS
@@ -30,10 +30,6 @@ Features:
   * -Wincompatible-function-pointer-types (Clang, becomes fatal in Clang 16)
     (note we already have -Wincompatible-pointer-types in the list for GCC)
   * -Wundefined-reinterpret-cast (Clang, C++ strict aliasing)
-  * -Wint-conversion
-  * -Wint-to-pointer-cast
-  * -Wpointer-to-int-cast
-  * -Wint-to-void-pointer-cast
   * -Wcast-function-type-strict (Clang, CFI)
   * Further -Wformat matches for missing specifiers.
     In future, we may warn on all -Wformat (in particular because of e.g.

diff --git a/bin/install-qa-check.d/90gcc-warnings b/bin/install-qa-check.d/90gcc-warnings
index 845a83b08..7a27b5aaa 100644
--- a/bin/install-qa-check.d/90gcc-warnings
+++ b/bin/install-qa-check.d/90gcc-warnings
@@ -66,14 +66,19 @@ gcc_warn_check() {
 			# the address of ... will never be NULL and likes
 			# (uses of function refs & string constants in conditionals)
 			'warning: .*\[-Waddress\]'
+
+			# TODO: we want to enable these but bash currently triggers
+			# them with a trick in random.c where it intentionally wants
+			# some truncation :(
+			#
 			# warning: assignment/initialization to ... from ... makes integer from pointer without cast
-			'warning: .*\[-Wint-conversion\]'
+			#'warning: .*\[-Wint-conversion\]'
 			# warning: cast to ... from integer of different size (or smaller size)
-			'warning: .*\[-Wint-to-pointer-cast\]'
+			#'warning: .*\[-Wint-to-pointer-cast\]'
 			# warning: cast to ... from (smaller) integer type
-			'warning: .*\[-Wint-to-void-pointer-cast\]'
+			#'warning: .*\[-Wint-to-void-pointer-cast\]'
 			# warning: cast from ... to integer of different size
-			'warning: .*\[-Wpointer-to-int-cast\]'
+			#'warning: .*\[-Wpointer-to-int-cast\]'
 
 			# -Wformat
 			# TODO: comment out some time in future for time_t & LFS preparedness