[gentoo-commits] proj/portage:master commit in: /, bin/install-qa-check.d/

["Sam James" <sam@gentoo.org>]

commit:     c4df46e3da5fee516dba000ade492c2462db99fd
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Nov  9 03:36:39 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Nov  9 03:38:13 2022 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=c4df46e3

install-qa-check.d/90gcc-warnings: update outdated -Wformat pattern

This only covers missing specifiers. We may add generic -Wformat (as commented
out) for time_t & LFS stuff later on, but I don't want to do it in portage 3.0.39
as we're adding enough new stuff here.

Signed-off-by: Sam James <sam <AT> gentoo.org>

 NEWS                                  | 3 +++
 bin/install-qa-check.d/90gcc-warnings | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index cf3487e4b..6fe36cbe0 100644
--- a/NEWS
+++ b/NEWS
@@ -30,6 +30,9 @@ Features:
   * -Wint-to-pointer-cast
   * -Wpointer-to-int-cast
   * -Wint-to-void-pointer-cast
+  * Further -Wformat matches for missing specifiers.
+    In future, we may warn on all -Wformat (in particular because of e.g.
+    time_t & LFS).
 
 * install-qa-check.d: 90gcc-warnings: Always die on -Wimplicit-function-declaration
   and remove bin/check-implicit-pointer-usage.py of dubious licencing (it was

diff --git a/bin/install-qa-check.d/90gcc-warnings b/bin/install-qa-check.d/90gcc-warnings
index cdffcd029..d8322871b 100644
--- a/bin/install-qa-check.d/90gcc-warnings
+++ b/bin/install-qa-check.d/90gcc-warnings
@@ -69,8 +69,12 @@ gcc_warn_check() {
 			# warning: cast from ... to integer of different size
 			'warning: .*\[-Wpointer-to-int-cast\]'
 
-			# outdated?
+			# -Wformat
+			# TODO: comment out some time in future for time_t & LFS preparedness
+			#'warning: .*\[-Wformat=\]'
+			# -Wformat variants
 			'warning: .*too few arguments for format'
+			'warning: .*missing sentinel in function call.*\[-Wformat=\]'
 			# format ... expects a matching ... argument
 			# (iow, too few arguments for format in new wording :))
 			'warning: .*matching.*\[-Wformat=\]'